From: Jonathan S. Katz <jkatz@postgresql.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-www@postgresql.org
Subject: Re: bad style for SECURITY DEFINER
Date: Tue, 14 Dec 2021 14:07:54 -0500
Message-ID: <70c4681a-b834-b694-ce2e-956a40fa7772@postgresql.org> (raw)
In-Reply-To: <3BBA1EE5-BDC7-44D5-9062-2E1CFDEB1DFC@yesql.se>
References: <20211213001707.GR17618@telsasoft.com>
<236bee0a-b624-b35d-516a-da7e4c3d2358@enterprisedb.com>
<212DF319-94A5-4827-9F78-74D29C888717@yesql.se>
<20211213140110.GU17618@telsasoft.com>
<3686660c-02a4-7b06-98e9-34a30bb7be08@postgresql.org>
<49328270-4191-4915-ABD4-16AFE6905AE3@yesql.se>
<3a1e4ece-d593-a8aa-3b23-280a8fd2eeb4@postgresql.org>
<3BBA1EE5-BDC7-44D5-9062-2E1CFDEB1DFC@yesql.se>
On 12/14/21 4:27 AM, Daniel Gustafsson wrote:
>> On 13 Dec 2021, at 23:14, Jonathan S. Katz <jkatz@postgresql.org> wrote:
>>
>> On 12/13/21 4:43 PM, Daniel Gustafsson wrote:
>>
>>> The margin issue looks right but I think the font-size should match the rest of
>>> the title.
>>
>> Please see attached and below for revision.
>
> I think this looks much better, and it matches how the PDF's are rendered.
>
>> I'm not thrilled about the !important override that's needed to deal with another !important, but I don't want to try to unweave the !important nest given the lack of overall cases of a code block nested within h2 title tags.
>
> Agreed on both counts.
Thanks for the review, and thanks to Justin for the report. I've pushed
this up. It should be available on the next cache refresh.
Thanks,
Jonathan
Attachments:
[application/pgp-signature] OpenPGP_signature (839B, ../70c4681a-b834-b694-ce2e-956a40fa7772@postgresql.org/2-OpenPGP_signature)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: jkatz@postgresql.org, daniel@yesql.se, pryzby@telsasoft.com, peter.eisentraut@enterprisedb.com, pgsql-www@postgresql.org
Subject: Re: bad style for SECURITY DEFINER
In-Reply-To: <70c4681a-b834-b694-ce2e-956a40fa7772@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox