public inbox for [email protected]  
help / color / mirror / Atom feed
startup message -> StartupMessage
6+ messages / 3 participants
[nested] [flat]

* startup message -> StartupMessage
@ 2016-06-09 12:38 Dmitry Igrishin <[email protected]>
  2016-06-22 22:53 ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
  0 siblings, 1 reply; 6+ messages in thread

From: Dmitry Igrishin @ 2016-06-09 12:38 UTC (permalink / raw)
  To: pgsql-docs

Hi,

At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
The StartupMessage instead of "startup message" may looks better for
the reader (at least for me).

-- 
// Dmitry.


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: startup message -> StartupMessage
  2016-06-09 12:38 startup message -> StartupMessage Dmitry Igrishin <[email protected]>
@ 2016-06-22 22:53 ` Bruce Momjian <[email protected]>
  2016-06-23 04:47   ` Re: startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  0 siblings, 1 reply; 6+ messages in thread

From: Bruce Momjian @ 2016-06-22 22:53 UTC (permalink / raw)
  To: Dmitry Igrishin <[email protected]>; +Cc: pgsql-docs

On Thu, Jun  9, 2016 at 03:38:40PM +0300, Dmitry Igrishin wrote:
> Hi,
> 
> At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
> The StartupMessage instead of "startup message" may looks better for
> the reader (at least for me).

Uh, where exactly?  Here?

	To begin a session, a frontend opens a connection to the server and
	sends a startup message.

In that case, it is highlighting it is a startup message, not the exact
message identifier.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+                     Ancient Roman grave inscription +


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: startup message -> StartupMessage
  2016-06-09 12:38 startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  2016-06-22 22:53 ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
@ 2016-06-23 04:47   ` Dmitry Igrishin <[email protected]>
  2016-06-23 13:24     ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
  0 siblings, 1 reply; 6+ messages in thread

From: Dmitry Igrishin @ 2016-06-23 04:47 UTC (permalink / raw)
  To: Bruce Momjian <[email protected]>; +Cc: pgsql-docs

2016-06-23 1:53 GMT+03:00 Bruce Momjian <[email protected]>:
> On Thu, Jun  9, 2016 at 03:38:40PM +0300, Dmitry Igrishin wrote:
>> Hi,
>>
>> At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
>> The StartupMessage instead of "startup message" may looks better for
>> the reader (at least for me).
>
> Uh, where exactly?  Here?
I suggest everywhere on this page.
>
>         To begin a session, a frontend opens a connection to the server and
>         sends a startup message.
>
> In that case, it is highlighting it is a startup message, not the exact
> message identifier.
Yes, but see the next sentence: "This message includes the names of
the user and of the database the user wants to connect to; it also
identifies the particular protocol version to be used." So, it's about
the StartupMessage exactly.


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: startup message -> StartupMessage
  2016-06-09 12:38 startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  2016-06-22 22:53 ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
  2016-06-23 04:47   ` Re: startup message -> StartupMessage Dmitry Igrishin <[email protected]>
@ 2016-06-23 13:24     ` Bruce Momjian <[email protected]>
  2016-06-23 13:38       ` Re: startup message -> StartupMessage Tom Lane <[email protected]>
  0 siblings, 1 reply; 6+ messages in thread

From: Bruce Momjian @ 2016-06-23 13:24 UTC (permalink / raw)
  To: Dmitry Igrishin <[email protected]>; +Cc: pgsql-docs

On Thu, Jun 23, 2016 at 07:47:10AM +0300, Dmitry Igrishin wrote:
> 2016-06-23 1:53 GMT+03:00 Bruce Momjian <[email protected]>:
> > On Thu, Jun  9, 2016 at 03:38:40PM +0300, Dmitry Igrishin wrote:
> >> Hi,
> >>
> >> At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
> >> The StartupMessage instead of "startup message" may looks better for
> >> the reader (at least for me).
> >
> > Uh, where exactly?  Here?
> I suggest everywhere on this page.
> >
> >         To begin a session, a frontend opens a connection to the server and
> >         sends a startup message.
> >
> > In that case, it is highlighting it is a startup message, not the exact
> > message identifier.
> Yes, but see the next sentence: "This message includes the names of
> the user and of the database the user wants to connect to; it also
> identifies the particular protocol version to be used." So, it's about
> the StartupMessage exactly.

OK, how is this attached doc patch?

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+                     Ancient Roman grave inscription +


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Attachments:

  [text/x-diff] protocol.diff (1.9K, 2-protocol.diff)
  download | inline diff:
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
new file mode 100644
index 9c96d8f..04d6780
*** a/doc/src/sgml/protocol.sgml
--- b/doc/src/sgml/protocol.sgml
***************
*** 93,99 ****
     length of the rest of the message (this length count includes itself, but
     not the message-type byte).  The remaining contents of the message are
     determined by the message type.  For historical reasons, the very first
!    message sent by the client (the startup message) has no initial
     message-type byte.
    </para>
  
--- 93,99 ----
     length of the rest of the message (this length count includes itself, but
     not the message-type byte).  The remaining contents of the message are
     determined by the message type.  For historical reasons, the very first
!    message sent by the client (StartupMessage) has no initial
     message-type byte.
    </para>
  
***************
*** 213,221 ****
  
     <para>
      To begin a session, a frontend opens a connection to the server and sends
!     a startup message.  This message includes the names of the user and of the
      database the user wants to connect to; it also identifies the particular
!     protocol version to be used.  (Optionally, the startup message can include
      additional settings for run-time parameters.)
      The server then uses this information and
      the contents of its configuration files (such as
--- 213,222 ----
  
     <para>
      To begin a session, a frontend opens a connection to the server and sends
!     a startup message (StartupMessage).  This message includes the names
!     of the user and of the
      database the user wants to connect to; it also identifies the particular
!     protocol version to be used.  (Optionally, StartupMessage can include
      additional settings for run-time parameters.)
      The server then uses this information and
      the contents of its configuration files (such as


^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: startup message -> StartupMessage
  2016-06-09 12:38 startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  2016-06-22 22:53 ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
  2016-06-23 04:47   ` Re: startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  2016-06-23 13:24     ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
@ 2016-06-23 13:38       ` Tom Lane <[email protected]>
  2016-06-23 14:23         ` Re: startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  0 siblings, 1 reply; 6+ messages in thread

From: Tom Lane @ 2016-06-23 13:38 UTC (permalink / raw)
  To: Bruce Momjian <[email protected]>; +Cc: Dmitry Igrishin <[email protected]>; pgsql-docs

Bruce Momjian <[email protected]> writes:
> On Thu, Jun 23, 2016 at 07:47:10AM +0300, Dmitry Igrishin wrote:
>> Yes, but see the next sentence: "This message includes the names of
>> the user and of the database the user wants to connect to; it also
>> identifies the particular protocol version to be used." So, it's about
>> the StartupMessage exactly.

> OK, how is this attached doc patch?

I do not think these are improvements.  This is introductory text,
not some kind of formal-language specification.

			regards, tom lane


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: startup message -> StartupMessage
  2016-06-09 12:38 startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  2016-06-22 22:53 ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
  2016-06-23 04:47   ` Re: startup message -> StartupMessage Dmitry Igrishin <[email protected]>
  2016-06-23 13:24     ` Re: startup message -> StartupMessage Bruce Momjian <[email protected]>
  2016-06-23 13:38       ` Re: startup message -> StartupMessage Tom Lane <[email protected]>
@ 2016-06-23 14:23         ` Dmitry Igrishin <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: Dmitry Igrishin @ 2016-06-23 14:23 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Bruce Momjian <[email protected]>; pgsql-docs

2016-06-23 16:38 GMT+03:00 Tom Lane <[email protected]>:
> Bruce Momjian <[email protected]> writes:
>> On Thu, Jun 23, 2016 at 07:47:10AM +0300, Dmitry Igrishin wrote:
>>> Yes, but see the next sentence: "This message includes the names of
>>> the user and of the database the user wants to connect to; it also
>>> identifies the particular protocol version to be used." So, it's about
>>> the StartupMessage exactly.
>
>> OK, how is this attached doc patch?
>
> I do not think these are improvements.  This is introductory text,
> not some kind of formal-language specification.
I can agree with this asserting when the text points to some abstract
message, like "The server then sends an appropriate authentication
request message" (because there are several kinds of authentication
messages). But for the concrete messages, there are consistency like
"The frontend must now send a PasswordMessage containing the
password", or "in the normal case the backend will send some
ParameterStatus messages", except the "During this phase the backend
will attempt to apply any additional run-time parameter settings that
were given in the startup message."

-- 
// Dmitry.


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs




^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2016-06-23 14:23 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 12:38 startup message -> StartupMessage Dmitry Igrishin <[email protected]>
2016-06-22 22:53 ` Bruce Momjian <[email protected]>
2016-06-23 04:47   ` Dmitry Igrishin <[email protected]>
2016-06-23 13:24     ` Bruce Momjian <[email protected]>
2016-06-23 13:38       ` Tom Lane <[email protected]>
2016-06-23 14:23         ` Dmitry Igrishin <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox