public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: gabrielle <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] log_statement docs
Date: Thu, 25 Feb 2010 14:07:57 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Bruce Momjian <[email protected]> writes:
> gabrielle wrote:
>> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <[email protected]> wrote:
>>> Shouldn't it just say "all means all", if we think that needs to be
>>> explained?
>> 
>> I think it should say something about the "all" option.  I read &
>> re-read that section trying to figure out what the difference between
>> "mod" and "all" was, and finally asked on the irc channel.  As it
>> stands, it essentially says "there are three options to this command,
>> but we're only going to tell you about two of them." :)

> Well, if you take a look at utility.c:GetCommandLogLevel() you will see
> that ALL includes a lot more commands than just SELECT.

Yeah.  My objection was not to documenting ALL, it was to documenting it
with exactly that sentence, which seems both needlessly complicated and
subject to errors of omission.

			regards, tom lane

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] log_statement docs
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox