pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedBackground worker docs,
11+ messages / 3 participants
[nested] [flat]
* Background worker docs,
@ 2021-08-27 13:17 Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 11+ messages in thread
From: Dave Cramer @ 2021-08-27 13:17 UTC (permalink / raw)
To: Pg Docs <pgsql-docs@lists.postgresql.org>
Why is the last comma there ?
"bgw_restart_time is the interval, in seconds, that postgres should wait
before restarting the process, in case it crashes."
diff --git a/doc/src/sgml/bgworker.sgml b/doc/src/sgml/bgworker.sgml
index d34acfc220..6f13006e25 100644
--- a/doc/src/sgml/bgworker.sgml
+++ b/doc/src/sgml/bgworker.sgml
@@ -130,7 +130,7 @@ typedef struct BackgroundWorker
<para>
<structfield>bgw_restart_time</structfield> is the interval, in
seconds, that
- <command>postgres</command> should wait before restarting the process,
in
+ <command>postgres</command> should wait before restarting the process in
case it crashes. It can be any positive value,
or <literal>BGW_NEVER_RESTART</literal>, indicating not to restart the
process in case of a crash.
Dave Cramer
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
@ 2021-08-27 13:24 ` Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
0 siblings, 1 reply; 11+ messages in thread
From: Daniel Gustafsson @ 2021-08-27 13:24 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
> On 27 Aug 2021, at 15:17, Dave Cramer <davecramer@gmail.com> wrote:
>
> Why is the last comma there ?
>
> "bgw_restart_time is the interval, in seconds, that postgres should wait before restarting the process, in case it crashes."
> - <command>postgres</command> should wait before restarting the process, in
> + <command>postgres</command> should wait before restarting the process in
While not being an native english speaker, I agree that this reads better.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
@ 2021-08-27 13:26 ` Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 11+ messages in thread
From: Dave Cramer @ 2021-08-27 13:26 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
On Fri, 27 Aug 2021 at 09:24, Daniel Gustafsson <daniel@yesql.se> wrote:
> > On 27 Aug 2021, at 15:17, Dave Cramer <davecramer@gmail.com> wrote:
> >
> > Why is the last comma there ?
> >
> > "bgw_restart_time is the interval, in seconds, that postgres should wait
> before restarting the process, in case it crashes."
>
> > - <command>postgres</command> should wait before restarting the
> process, in
> > + <command>postgres</command> should wait before restarting the
> process in
>
> While not being an native english speaker, I agree that this reads better.
>
As a native English speaker, I was left wondering what else the timeout
would be used for.
Dave Cramer
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
@ 2021-08-27 13:50 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
0 siblings, 1 reply; 11+ messages in thread
From: Tom Lane @ 2021-08-27 13:50 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Daniel Gustafsson <daniel@yesql.se>; Pg Docs <pgsql-docs@lists.postgresql.org>
Dave Cramer <davecramer@gmail.com> writes:
>> - <command>postgres</command> should wait before restarting the
>> process, in
>> + <command>postgres</command> should wait before restarting the
>> process in
> As a native English speaker, I was left wondering what else the timeout
> would be used for.
Maybe s/in case/if/ ? Or s/in case/after/ ? It does seem like this
sentence needs more help than just comma-removal.
regards, tom lane
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-08-27 13:52 ` Dave Cramer <davecramer@gmail.com>
2021-08-27 13:57 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 11+ messages in thread
From: Dave Cramer @ 2021-08-27 13:52 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Daniel Gustafsson <daniel@yesql.se>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Fri, 27 Aug 2021 at 09:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Dave Cramer <davecramer@gmail.com> writes:
> >> - <command>postgres</command> should wait before restarting the
> >> process, in
> >> + <command>postgres</command> should wait before restarting the
> >> process in
>
> > As a native English speaker, I was left wondering what else the timeout
> > would be used for.
>
> Maybe s/in case/if/ ? Or s/in case/after/ ? It does seem like this
> sentence needs more help than just comma-removal.
>
In my mind "in the event that it crashes" made it clear
>
> regards, tom lane
>
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
@ 2021-08-27 13:57 ` Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:15 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 11+ messages in thread
From: Daniel Gustafsson @ 2021-08-27 13:57 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Pg Docs <pgsql-docs@lists.postgresql.org>
> On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote:
> On Fri, 27 Aug 2021 at 09:50, Tom Lane <tgl@sss.pgh.pa.us <mailto:tgl@sss.pgh.pa.us>> wrote:
> Maybe s/in case/if/ ? Or s/in case/after/ ? It does seem like this
> sentence needs more help than just comma-removal.
>
> In my mind "in the event that it crashes" made it clear
That, or “if it crashes” gets my vote.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:57 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
@ 2021-08-27 14:15 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 14:20 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 14:22 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
0 siblings, 2 replies; 11+ messages in thread
From: Tom Lane @ 2021-08-27 14:15 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Dave Cramer <davecramer@gmail.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
Daniel Gustafsson <daniel@yesql.se> writes:
> On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote:
>> In my mind "in the event that it crashes" made it clear
> That, or “if it crashes” gets my vote.
Dave's wording sounds good to me.
regards, tom lane
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:57 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:15 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-08-27 14:20 ` Dave Cramer <davecramer@gmail.com>
1 sibling, 0 replies; 11+ messages in thread
From: Dave Cramer @ 2021-08-27 14:20 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Daniel Gustafsson <daniel@yesql.se>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Fri, 27 Aug 2021 at 10:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
> > On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote:
> >> In my mind "in the event that it crashes" made it clear
>
> > That, or “if it crashes” gets my vote.
>
> Dave's wording sounds good to me.
>
> regards, tom lane
>
> revised diff
Attachments:
[application/octet-stream] bgworker_docs.patch (704B, ../../CADK3HHLN7OrfrjE=y8P3jjvSRNx+vSTSS60r9U0M1ydF82n=bQ@mail.gmail.com/3-bgworker_docs.patch)
download | inline diff:
diff --git a/doc/src/sgml/bgworker.sgml b/doc/src/sgml/bgworker.sgml
index d34acfc220..c0811935a1 100644
--- a/doc/src/sgml/bgworker.sgml
+++ b/doc/src/sgml/bgworker.sgml
@@ -130,8 +130,8 @@ typedef struct BackgroundWorker
<para>
<structfield>bgw_restart_time</structfield> is the interval, in seconds, that
- <command>postgres</command> should wait before restarting the process, in
- case it crashes. It can be any positive value,
+ <command>postgres</command> should wait before restarting the process in
+ the event that it crashes. It can be any positive value,
or <literal>BGW_NEVER_RESTART</literal>, indicating not to restart the
process in case of a crash.
</para>
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:57 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:15 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-08-27 14:22 ` Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:31 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 11+ messages in thread
From: Daniel Gustafsson @ 2021-08-27 14:22 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
> On 27 Aug 2021, at 16:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote:
>>> In my mind "in the event that it crashes" made it clear
>
>> That, or “if it crashes” gets my vote.
>
> Dave's wording sounds good to me.
I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim,
unless you’re already on it.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:57 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:15 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 14:22 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
@ 2021-08-27 14:31 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 21:14 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 11+ messages in thread
From: Tom Lane @ 2021-08-27 14:31 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Dave Cramer <davecramer@gmail.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
Daniel Gustafsson <daniel@yesql.se> writes:
> On 27 Aug 2021, at 16:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Dave's wording sounds good to me.
> I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim,
> unless you’re already on it.
Feel free, I've got other stuff on my plate right now.
regards, tom lane
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: Background worker docs,
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Re: Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:57 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:15 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 14:22 ` Re: Background worker docs, Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:31 ` Re: Background worker docs, Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-08-27 21:14 ` Daniel Gustafsson <daniel@yesql.se>
0 siblings, 0 replies; 11+ messages in thread
From: Daniel Gustafsson @ 2021-08-27 21:14 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
> On 27 Aug 2021, at 16:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 27 Aug 2021, at 16:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Dave's wording sounds good to me.
>
>> I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim,
>> unless you’re already on it.
>
> Feel free, I've got other stuff on my plate right now.
And done, thanks.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 11+ messages in thread
end of thread, other threads:[~2021-08-27 21:14 UTC | newest]
Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 13:17 Background worker docs, Dave Cramer <davecramer@gmail.com>
2021-08-27 13:24 ` Daniel Gustafsson <daniel@yesql.se>
2021-08-27 13:26 ` Dave Cramer <davecramer@gmail.com>
2021-08-27 13:50 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 13:52 ` Dave Cramer <davecramer@gmail.com>
2021-08-27 13:57 ` Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:15 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 14:20 ` Dave Cramer <davecramer@gmail.com>
2021-08-27 14:22 ` Daniel Gustafsson <daniel@yesql.se>
2021-08-27 14:31 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 21:14 ` Daniel Gustafsson <daniel@yesql.se>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox