From: Shinya11.Kato@nttdata.com
To: masao.fujii@oss.nttdata.com
To: pgsql-docs@lists.postgresql.org
Subject: RE: index items for pg_stat_progress_xxx views
Date: Tue, 1 Dec 2020 05:14:29 +0000
Message-ID: <7e0fd7d4dc83487aabd59220a1ad028c@MP-MSGSS-MBX001.msg.nttdata.co.jp> (raw)
In-Reply-To: <058732ef-03c1-5d30-c955-27dd43914a76@oss.nttdata.com>
References: <e49c2768-65d2-188a-5424-270fa29ccc84@oss.nttdata.com>
<1ab4b582811046199a3de43f52d49b4f@MP-MSGSS-MBX001.msg.nttdata.co.jp>
<5ec0801a-ed9b-630c-cad7-513049b708a3@oss.nttdata.com>
<6168075bd02a4ef18ed75153ad2a85f0@MP-MSGSS-MBX001.msg.nttdata.co.jp>
<058732ef-03c1-5d30-c955-27dd43914a76@oss.nttdata.com>
>>>>> Hi,
>>>>>
>>>>> The index items for pg_stat_progress_xxx views point to the
>>>>> "Viewing Statistics" section, but not to the dedicated section
>>>>> (e.g., "ANALYZE Progress
>>>>> Reporting") for each view. IMO this is very inconvenient when
>>>>> finding the section describing each pg_stat_progress_xxx view, from the
>index.
>>>>> So what about adding new pointer to the section for each view in the
>index?
>>>>> Patch attached.
>>>>>
>>>>> BTW, other stats views have both pointers in the index.
>>>>
>>>> When setting an <indexterm>, it's better to set the zone attribute
>>>> to indicate
>>> which section it's associated with.
>>>>
>>>> For example,
>>>> <indexterm zone="analyze-progress-reporting">
>>>> <primary>pg_stat_progress_analyze</primary>
>>>> </indexterm>
>>>
>>> Thanks for the review!
>>>
>>> I was thinking that the zone attribute doesn't need to be specified
>>> because the indexterm is defined under the section that the indexterm
>>> tries to point to. You can see the same situation at, for example,
>>> the section and indexterm of pg_stat_database. If I'm missing
>>> something, could you tell me why the zone attribute is necessary in this case?
>>
>> I looked at lines 132-137 of monitoring.sgml, and I saw that zone is set for
>indexterm after <sect1>.
>> However, I haven't found the zone set for indexterm after <sect2>, so you may
>be right.
>
>So you agree not to add zone attribute in this case?
Yes, I think it's nice.
Regards,
Shinya Kato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: Shinya11.Kato@nttdata.com, masao.fujii@oss.nttdata.com, pgsql-docs@lists.postgresql.org
Subject: RE: index items for pg_stat_progress_xxx views
In-Reply-To: <7e0fd7d4dc83487aabd59220a1ad028c@MP-MSGSS-MBX001.msg.nttdata.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox