From: Jonathan S. Katz <jkatz@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: droptablestar@gmail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Clarity in partial index example.
Date: Wed, 3 Apr 2019 18:31:47 -0400
Message-ID: <99a710f1-92e2-e5c7-52ae-a1d61cfacd30@postgresql.org> (raw)
In-Reply-To: <12858.1554330652@sss.pgh.pa.us>
References: <155432280882.722.12392985690846288230@wrigleys.postgresql.org>
<fbcb4420-881c-c1b3-4ef3-02ca38e29069@postgresql.org>
<12858.1554330652@sss.pgh.pa.us>
On 4/3/19 6:30 PM, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>> On 4/3/19 4:20 PM, PG Doc comments form wrote:
>>> Maybe I am misunderstanding the concept here but url = '/index.html' doesn't
>>> have any effect on this? If that's the case I would suggest either removing
>>> it from the first query or adding it to the second query.
>
>> You're correct, the url = '/index.html' does not affect if the partial
>> index is used in the example.
>
>> Based on how the example is set up, I'd propose using the "url"
>> parameter in both examples. I've attached a patch that does this, with
>> some additional wording around the examples.
>
> Yeah, this seems unnecessarily confusing. I tweaked your extra wording
> a bit --- I didn't like referring to the index as covering a range,
> because it's really excluding a range not including one.
You're right, that makes sense.
> Pushed.
Thanks!
Jonathan
Attachments:
[application/pgp-signature] signature.asc (832B, ../99a710f1-92e2-e5c7-52ae-a1d61cfacd30@postgresql.org/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: jkatz@postgresql.org, tgl@sss.pgh.pa.us, droptablestar@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Clarity in partial index example.
In-Reply-To: <99a710f1-92e2-e5c7-52ae-a1d61cfacd30@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox