agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedFrom: Yaroslav Saburov <y.saburov@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: generated constraint name
Date: Fri, 11 Apr 2025 11:32:45 +0300
Message-ID: <A76B1033-B4AE-4FE3-AC73-5B5303CF5071@gmail.com> (raw)
In-Reply-To: <520881.1744297980@sss.pgh.pa.us>
References: <520881.1744297980@sss.pgh.pa.us>
Thank you all.
In order not to open a new thread, (small clarification)
On the tutorial-agg page in the code example
SELECT city FROM weather WHERE temp_lo = max(temp_lo); WRONG
you need to add a comment before WRONG
> 10 квіт. 2025 р. о 18:13 Tom Lane <tgl@sss.pgh.pa.us> пише:
>
> Peter Eisentraut <peter@eisentraut.org> writes:
>>> On 07.04.25 15:34, David G. Johnston wrote:
>>> I feel like that whole parenthetical should just go away. The point of
>>> the comment is to remind the user of how identifier values work with
>>> respect to mandatory double quoting. The name itself, other than having
>>> a $, has no special importance.
>
>> I think generated constraint names were generally "$1", "$2", etc. at
>> some point, instead of the more readable ones you get today. But this
>> must be ancient.
>
> Good point. A bit of git-blame'ing shows that this documentation
> wording appeared in e560dd353 of 2003-11-05, but we changed the
> generation rule to not be "$n" in 45616f5bb of 2004-06-10.
> (Oddly, I moved this documentation text around in 2005 without
> noticing it was obsolete; or perhaps I did realize that but figured
> it was still applicable to versions in the field.)
>
> I concur with David that we should just drop the para. It's merely
> confusing now. If you have a generated constraint name, it won't
> require double-quoting unless your table or column name does, and
> if they do you are doubtless already quite familiar with how
> quoting works.
>
> regards, tom lane
view thread (9+ messages) latest in thread
Message-ID: <A76B1033-B4AE-4FE3-AC73-5B5303CF5071@gmail.com>
Permalink: ../A76B1033-B4AE-4FE3-AC73-5B5303CF5071@gmail.com/
Also on: postgresql.org/message-id/A76B1033-B4AE-4FE3-AC73-5B5303CF5071@gmail.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: y.saburov@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, david.g.johnston@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: generated constraint name
In-Reply-To: <A76B1033-B4AE-4FE3-AC73-5B5303CF5071@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox