public inbox for [email protected]
help / color / mirror / Atom feedmisleading lang_name case in CREATE FUNCTION doc.
6+ messages / 3 participants
[nested] [flat]
* misleading lang_name case in CREATE FUNCTION doc.
@ 2013-10-11 08:37 Marc Mamin <[email protected]>
2013-11-13 11:56 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Marc Mamin @ 2013-10-11 08:37 UTC (permalink / raw)
To: pgsql-docs
Hi,
you might want to lowercase the language names in order to be compatible with the case restriction introduced in 9.2.
or add a sentence like
'when using single quotes, the names are case sensitive (with is lowercase for most (all?) languages).
regards,
Marc Mamin
http://www.postgresql.org/docs/9.3/static/sql-createfunction.html
lang_name
The name of the language that the function is implemented in.
Can be SQL, C, internal, or the name of a user-defined procedural language.
For backward compatibility, the name can be enclosed by single quotes.
http://www.postgresql.org/docs/current/static/release-9-2.html
No longer forcibly lowercase procedural language names in CREATE FUNCTION (Robert Haas)
While unquoted language identifiers are still lowercased,
strings and quoted identifiers are no longer forcibly down-cased.
Thus for example CREATE FUNCTION ... LANGUAGE 'C' will no longer work;
it must be spelled 'c', or better omit the quotes.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: misleading lang_name case in CREATE FUNCTION doc.
2013-10-11 08:37 misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
@ 2013-11-13 11:56 ` Peter Eisentraut <[email protected]>
2013-11-13 14:02 ` Re: misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Peter Eisentraut @ 2013-11-13 11:56 UTC (permalink / raw)
To: Marc Mamin <[email protected]>; +Cc: pgsql-docs
On Fri, 2013-10-11 at 08:37 +0000, Marc Mamin wrote:
> Hi,
> you might want to lowercase the language names in order to be
> compatible with the case restriction introduced in 9.2.
> or add a sentence like
> 'when using single quotes, the names are case sensitive (with is
> lowercase for most (all?) languages).
Yeah, I'm having trouble coming up with a wording that is sufficiently
brief. We don't want the backward compatibility text to be longer than
the main description, I think.
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: misleading lang_name case in CREATE FUNCTION doc.
2013-10-11 08:37 misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
2013-11-13 11:56 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
@ 2013-11-13 14:02 ` Marc Mamin <[email protected]>
2013-11-26 18:32 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Marc Mamin @ 2013-11-13 14:02 UTC (permalink / raw)
To: 'Peter Eisentraut' <[email protected]>; +Cc: pgsql-docs
> From: Peter Eisentraut [mailto:[email protected]]
> Sent: Mittwoch, 13. November 2013 12:56
> On Fri, 2013-10-11 at 08:37 +0000, Marc Mamin wrote:
> > Hi,
> > you might want to lowercase the language names in order to be
> > compatible with the case restriction introduced in 9.2.
> > or add a sentence like
> > 'when using single quotes, the names are case sensitive (with is
> > lowercase for most (all?) languages).
>
> Yeah, I'm having trouble coming up with a wording that is sufficiently
> brief. We don't want the backward compatibility text to be longer than
> the main description, I think.
>
something like :?
The name of the language that the function is implemented in.
Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
Single quotes are optional, they required correct case when used.
regards,
Marc Mamin
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: misleading lang_name case in CREATE FUNCTION doc.
2013-10-11 08:37 misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
2013-11-13 11:56 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
2013-11-13 14:02 ` Re: misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
@ 2013-11-26 18:32 ` Peter Eisentraut <[email protected]>
2013-11-26 19:28 ` Re: misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Peter Eisentraut @ 2013-11-26 18:32 UTC (permalink / raw)
To: Marc Mamin <[email protected]>; +Cc: pgsql-docs
On 11/13/13, 9:02 AM, Marc Mamin wrote:
> something like :?
>
> The name of the language that the function is implemented in.
> Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
> Single quotes are optional, they required correct case when used.
That would make the deprecated syntax more prominent than the
non-deprecated one. We want to get rid of the single quotes.
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: misleading lang_name case in CREATE FUNCTION doc.
2013-10-11 08:37 misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
2013-11-13 11:56 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
2013-11-13 14:02 ` Re: misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
2013-11-26 18:32 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
@ 2013-11-26 19:28 ` Marc Mamin <[email protected]>
2014-02-13 22:07 ` Re: misleading lang_name case in CREATE FUNCTION doc. Bruce Momjian <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Marc Mamin @ 2013-11-26 19:28 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: pgsql-docs
>Von: Peter Eisentraut [[email protected]]
>>On 11/13/13, 9:02 AM, Marc Mamin wrote:
>> something like :?
>>
>> The name of the language that the function is implemented in.
>> Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
>> Single quotes are optional, they required correct case when used.
>That would make the deprecated syntax more prominent than the
>non-deprecated one. We want to get rid of the single quotes.
Ok, next try :)
The name of the language that the function is implemented in.
Can be sql, c, internal, or the name of a user-defined procedural language.
Single quotes are deprecated. They require correct case when used.
regards,
Marc Mamin
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: misleading lang_name case in CREATE FUNCTION doc.
2013-10-11 08:37 misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
2013-11-13 11:56 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
2013-11-13 14:02 ` Re: misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
2013-11-26 18:32 ` Re: misleading lang_name case in CREATE FUNCTION doc. Peter Eisentraut <[email protected]>
2013-11-26 19:28 ` Re: misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
@ 2014-02-13 22:07 ` Bruce Momjian <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2014-02-13 22:07 UTC (permalink / raw)
To: Marc Mamin <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; pgsql-docs
On Tue, Nov 26, 2013 at 07:28:17PM +0000, Marc Mamin wrote:
>
> >Von: Peter Eisentraut [[email protected]]
>
> >>On 11/13/13, 9:02 AM, Marc Mamin wrote:
> >> something like :?
> >>
> >> The name of the language that the function is implemented in.
> >> Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
> >> Single quotes are optional, they required correct case when used.
>
> >That would make the deprecated syntax more prominent than the
> >non-deprecated one. We want to get rid of the single quotes.
>
> Ok, next try :)
>
> The name of the language that the function is implemented in.
> Can be sql, c, internal, or the name of a user-defined procedural language.
> Single quotes are deprecated. They require correct case when used.
I have applied the attached patch to improve the wording. Thanks for
the report.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Attachments:
[text/x-diff] lang.diff (1.1K, 2-lang.diff)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_function.sgml b/doc/src/sgml/ref/create_function.sgml
new file mode 100644
index 81278bb..b61b978
*** a/doc/src/sgml/ref/create_function.sgml
--- b/doc/src/sgml/ref/create_function.sgml
*************** CREATE [ OR REPLACE ] FUNCTION
*** 252,261 ****
<listitem>
<para>
The name of the language that the function is implemented in.
! Can be <literal>SQL</literal>, <literal>C</literal>,
<literal>internal</literal>, or the name of a user-defined
! procedural language. For backward compatibility,
! the name can be enclosed by single quotes.
</para>
</listitem>
</varlistentry>
--- 252,261 ----
<listitem>
<para>
The name of the language that the function is implemented in.
! It can be <literal>sql</literal>, <literal>c</literal>,
<literal>internal</literal>, or the name of a user-defined
! procedural language, e.g. <literal>plpgsql</literal>. Enclosing the
! name in single quotes is deprecated and requires matching case.
</para>
</listitem>
</varlistentry>
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2014-02-13 22:07 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2013-10-11 08:37 misleading lang_name case in CREATE FUNCTION doc. Marc Mamin <[email protected]>
2013-11-13 11:56 ` Peter Eisentraut <[email protected]>
2013-11-13 14:02 ` Marc Mamin <[email protected]>
2013-11-26 18:32 ` Peter Eisentraut <[email protected]>
2013-11-26 19:28 ` Marc Mamin <[email protected]>
2014-02-13 22:07 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox