public inbox for [email protected]  
help / color / mirror / Atom feed
From: Magnus Hagander <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Jonathan S. Katz <[email protected]>
Cc: Daniel Westermann <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: Blanks in the first line before the first word in the code boxes
Date: Tue, 3 Apr 2018 15:12:12 +0200
Message-ID: <CABUevEykw8e1kgd1AYAL5n0gBOXkaBXn1rRHhPc7bHTVgPwO0Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CABUevEw3sAROjdHW0OE4-i5+uM3VMHQTixtLT+SOWGJapYtaSw@mail.gmail.com>
	<[email protected]>
	<CABUevEw9hB8r_WjZ2KHZej1NS79xnQ=3R=zDFtAYsEiJdhTGpg@mail.gmail.com>
	<[email protected]>

On Mon, Apr 2, 2018 at 5:59 PM, Peter Eisentraut <
[email protected]> wrote:

> On 4/1/18 11:55, Magnus Hagander wrote:
> > However, why does devel work fine when the others are broken. It's the
> > exact same code that's run to load the docs. The *input* to the loader
> > must also be different at some point.
>
> In devel, the raw HTML output looks like
>
> ... <pre class="synopsis">
> ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (with a line break)
>
> but before it looks like
>
> ... <pre class="synopsis">ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (without a line break).
>
> So maybe some part of the processing code thinks it should do some kind
> of "indentation" here.
>
>
I think I found the problem, and pushed a fix for it. Basically it turns
off indentation completely on pre-11 versions., I elected to keep indention
on dev because it works there, and it makes debugging any of the formatting
a lot easier.

I've pushed the fix and reloaded the 10 docs. I have not reloaded earlier
branches yet, but I'd be interested in some people reviewing a bunch of
pages in the 10 docs mainly to see if (1) it fixes all the cases, and (2)
it actually breaks some *other* cases.


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Blanks in the first line before the first word in the code boxes
  In-Reply-To: <CABUevEykw8e1kgd1AYAL5n0gBOXkaBXn1rRHhPc7bHTVgPwO0Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox