public inbox for [email protected]help / color / mirror / Atom feed
[PATCH] fix ICU explorer link in locale documentation 11+ messages / 4 participants [nested] [flat]
* [PATCH] fix ICU explorer link in locale documentation @ 2021-04-04 07:53 Anton Voloshin <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Anton Voloshin @ 2021-04-04 07:53 UTC (permalink / raw) To: [email protected] Hello, Existing Postgres documentation states in doc/src/sgml/charset.sgml: The <ulink url="https://ssl.icu-project.org/icu-bin/locexp">ICU Locale Explorer</ulink> can be used to check the details of a particular locale definition. But the link is broken (SSL certificate does not include ssl.icu-project.org as allowed name). Correct link is, I believe, https://icu4c-demos.unicode.org/icu-bin/locexp Attached patch fixes the broken link. -- Anton Voloshin Postgres Professional: https://www.postgrespro.com Russian Postgres Company diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml index 300a0d83d4..46d19ae39d 100644 --- a/doc/src/sgml/charset.sgml +++ b/doc/src/sgml/charset.sgml @@ -842,7 +842,7 @@ CREATE COLLATION german (provider = libc, locale = 'de_DE'); subtag) can be found in the <ulink url="https://github.com/unicode-org/cldr/blob/master/common/bcp47/collation.xml">CLDR repository</ulink>. - The <ulink url="https://ssl.icu-project.org/icu-bin/locexp">ICU Locale + The <ulink url="https://icu4c-demos.unicode.org/icu-bin/locexp">ICU Locale Explorer</ulink> can be used to check the details of a particular locale definition. The examples using the <literal>k*</literal> subtags require at least ICU version 54. Attachments: [text/plain] icu-explorer-link.patch (760B, 2-icu-explorer-link.patch) download | inline diff: diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml index 300a0d83d4..46d19ae39d 100644 --- a/doc/src/sgml/charset.sgml +++ b/doc/src/sgml/charset.sgml @@ -842,7 +842,7 @@ CREATE COLLATION german (provider = libc, locale = 'de_DE'); subtag) can be found in the <ulink url="https://github.com/unicode-org/cldr/blob/master/common/bcp47/collation.xml">CLDR repository</ulink>. - The <ulink url="https://ssl.icu-project.org/icu-bin/locexp">ICU Locale + The <ulink url="https://icu4c-demos.unicode.org/icu-bin/locexp">ICU Locale Explorer</ulink> can be used to check the details of a particular locale definition. The examples using the <literal>k*</literal> subtags require at least ICU version 54. ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-05-17 20:46 Magnus Hagander <[email protected]> parent: Anton Voloshin <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Magnus Hagander @ 2021-05-17 20:46 UTC (permalink / raw) To: Anton Voloshin <[email protected]>; +Cc: Pg Docs <[email protected]> On Sun, Apr 4, 2021 at 9:53 AM Anton Voloshin <[email protected]> wrote: > > Hello, > > Existing Postgres documentation states in doc/src/sgml/charset.sgml: > The <ulink url="https://ssl.icu-project.org/icu-bin/locexp">ICU Locale > Explorer</ulink> can be used to check the details of a particular locale > definition. > > But the link is broken (SSL certificate does not include > ssl.icu-project.org as allowed name). Correct link is, I believe, > https://icu4c-demos.unicode.org/icu-bin/locexp > > Attached patch fixes the broken link. https://icu4c-demos.unicode.org/icu-bin/locexp generates a 404 for me now. This might be something temporary though, because AFAICT it's where you end up when you follow the links from the ICU git repo... -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/ ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-05-27 04:10 Anton Voloshin <[email protected]> parent: Magnus Hagander <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Anton Voloshin @ 2021-05-27 04:10 UTC (permalink / raw) To: Magnus Hagander <[email protected]>; +Cc: Pg Docs <[email protected]> On 18/05/2021 03:46, Magnus Hagander wrote: > https://icu4c-demos.unicode.org/icu-bin/locexp generates a 404 for me now. > > This might be something temporary though, because AFAICT it's where > you end up when you follow the links from the ICU git repo... Yes, same 404 for me. This error has been reported on icu-issues mailing list on April 13th [1] and the reply from Stephan Pakebusch was: > This demo has been out of date (by several releases) and is being updated for ICU 69. > In the meantime there was an issue with this particular demo. > We’re looking into the problem you noted. > > I’m not sure if there’s a tracking issue for this specific, but you can follow the development on https://github.com/unicode-org/icu-demos So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is still the proper one, and eventually it will be fixed. Anyway, the old link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through "wrong domain in certificate" errors, still redirects to the same https://icu4c-demos.unicode.org/icu-bin/locexp I believe changing link in Postgres' docs is better than keeping the old one, even though they are currently both 404 one way or another. At least it would save people following that link from scary "Warning: Potential Security Risk Ahead" messages before properly 404-ing. [1] https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9... -- Anton Voloshin Postgres Professional, The Russian Postgres Company https://postgrespro.ru ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-05-27 06:59 Laurenz Albe <[email protected]> parent: Anton Voloshin <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Laurenz Albe @ 2021-05-27 06:59 UTC (permalink / raw) To: Anton Voloshin <[email protected]>; Magnus Hagander <[email protected]>; +Cc: Pg Docs <[email protected]> On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > On 18/05/2021 03:46, Magnus Hagander wrote: > > https://icu4c-demos.unicode.org/icu-bin/locexp generates a 404 for me now. > > > > This might be something temporary though, because AFAICT it's where > > you end up when you follow the links from the ICU git repo... > > Yes, same 404 for me. This error has been reported on icu-issues mailing > list on April 13th [1] and the reply from Stephan Pakebusch was: > > > This demo has been out of date (by several releases) and is being updated for ICU 69. > > In the meantime there was an issue with this particular demo. > > We’re looking into the problem you noted. > > > > I’m not sure if there’s a tracking issue for this specific, but you can follow the development on https://github.com/unicode-org/icu-demos > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > still the proper one, and eventually it will be fixed. Anyway, the old > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > "wrong domain in certificate" errors, still redirects to the same > https://icu4c-demos.unicode.org/icu-bin/locexp > > I believe changing link in Postgres' docs is better than keeping the old > one, even though they are currently both 404 one way or another. At > least it would save people following that link from scary "Warning: > Potential Security Risk Ahead" messages before properly 404-ing. > > [1] > https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9... I agree that the documentation link should be changed. There are two options: 1. Trust that they will fix it soon and change the link to https://icu4c-demos.unicode.org/icu-bin/locexp 2. Despair and remove the link from the documentation. I suggest that we wait until the end of the June 2021 commitfest and decide then. If it is still not fixed then, the second option is better - or we move it to the next commitfest. Yours, Laurenz Albe ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-09-03 19:39 Laurenz Albe <[email protected]> parent: Laurenz Albe <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Laurenz Albe @ 2021-09-03 19:39 UTC (permalink / raw) To: Anton Voloshin <[email protected]>; Magnus Hagander <[email protected]>; +Cc: Pg Docs <[email protected]> On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > > still the proper one, and eventually it will be fixed. Anyway, the old > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > > "wrong domain in certificate" errors, still redirects to the same > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > I believe changing link in Postgres' docs is better than keeping the old > > one, even though they are currently both 404 one way or another. At > > least it would save people following that link from scary "Warning: > > Potential Security Risk Ahead" messages before properly 404-ing. > > > > [1] > > https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9... > > I agree that the documentation link should be changed. > > There are two options: > > 1. Trust that they will fix it soon and change the link to > https://icu4c-demos.unicode.org/icu-bin/locexp > > 2. Despair and remove the link from the documentation. > > I suggest that we wait until the end of the June 2021 commitfest and decide then. > If it is still not fixed then, the second option is better - or we move it to > the next commitfest. It is way past that time, and the link is still broken. So I guess it would be the best to remove the link from the documentation. Yours, Laurenz Albe ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-09-27 18:31 Bruce Momjian <[email protected]> parent: Laurenz Albe <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Bruce Momjian @ 2021-09-27 18:31 UTC (permalink / raw) To: Laurenz Albe <[email protected]>; +Cc: Anton Voloshin <[email protected]>; Magnus Hagander <[email protected]>; Pg Docs <[email protected]> On Fri, Sep 3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote: > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > > > still the proper one, and eventually it will be fixed. Anyway, the old > > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > > > "wrong domain in certificate" errors, still redirects to the same > > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > > > I believe changing link in Postgres' docs is better than keeping the old > > > one, even though they are currently both 404 one way or another. At > > > least it would save people following that link from scary "Warning: > > > Potential Security Risk Ahead" messages before properly 404-ing. > > > > > > [1] > > > https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9... > > > > I agree that the documentation link should be changed. > > > > There are two options: > > > > 1. Trust that they will fix it soon and change the link to > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > 2. Despair and remove the link from the documentation. > > > > I suggest that we wait until the end of the June 2021 commitfest and decide then. > > If it is still not fixed then, the second option is better - or we move it to > > the next commitfest. > > It is way past that time, and the link is still broken. > > So I guess it would be the best to remove the link from the documentation. Should we change it to a link to the locexp source? https://github.com/unicode-org/icu-demos/tree/main/locexp This is the source for the locale explorer CGI which is on IBM's external website at: http://demo.icu-project.org/icu-bin/locexp -- Bruce Momjian <[email protected]> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion. ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-09-29 10:13 Laurenz Albe <[email protected]> parent: Bruce Momjian <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Laurenz Albe @ 2021-09-29 10:13 UTC (permalink / raw) To: Bruce Momjian <[email protected]>; +Cc: Anton Voloshin <[email protected]>; Magnus Hagander <[email protected]>; Pg Docs <[email protected]> On Mon, 2021-09-27 at 14:31 -0400, Bruce Momjian wrote: > On Fri, Sep 3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote: > > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > > > > still the proper one, and eventually it will be fixed. Anyway, the old > > > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > > > > "wrong domain in certificate" errors, still redirects to the same > > > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > > > > > I believe changing link in Postgres' docs is better than keeping the old > > > > one, even though they are currently both 404 one way or another. At > > > > least it would save people following that link from scary "Warning: > > > > Potential Security Risk Ahead" messages before properly 404-ing. > > > > > > I suggest that we wait until the end of the June 2021 commitfest and decide then. > > > If it is still not fixed then, the second option is better - or we move it to > > > the next commitfest. > > > > It is way past that time, and the link is still broken. > > > > So I guess it would be the best to remove the link from the documentation. > > Should we change it to a link to the locexp source? > > https://github.com/unicode-org/icu-demos/tree/main/locexp > > This is the source for the locale explorer CGI which is on IBM's > external website at: > > http://demo.icu-project.org/icu-bin/locexp I had a look at that and tried to build the software from source. It requires you to build ICU, and even then it failed to build for me. The build documentation is not very detailed. So I think we should not link to that. I noticed that two more external links have moved. Attached is a patch that fixes those links and removes the link to the locale explorer. Yours, Laurenz Albe Attachments: [text/x-patch] 0001-Fix-external-ICU-links.patch (2.2K, 2-0001-Fix-external-ICU-links.patch) download | inline diff: From 10c33a90a946a4337e37e54293e539e6f8cd2954 Mon Sep 17 00:00:00 2001 From: Laurenz Albe <[email protected]> Date: Wed, 29 Sep 2021 12:09:18 +0200 Subject: [PATCH] Fix external ICU links The links explaining ICU locales and ICU API details have moved. Also, remove the link to the "ICU Locale Explorer", since it is no longer available. We could have added a link to the source at https://github.com/unicode-org/icu-demos, but the build documentation is not very detailed, and an attempt to build failed due to missing headers of unspecified origin. Author: Anton Voloshin Reviewed-by: Laurenz Albe Discussion: https://postgr.es/m/[email protected] --- doc/src/sgml/charset.sgml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml index 05a6bf568f..f203c368c2 100644 --- a/doc/src/sgml/charset.sgml +++ b/doc/src/sgml/charset.sgml @@ -747,8 +747,8 @@ CREATE COLLATION german (provider = libc, locale = 'de_DE'); set that is preloaded by <command>initdb</command>. Users are encouraged to define their own collation objects that make use of these facilities to suit the sorting behavior to their requirements. - See <ulink url="http://userguide.icu-project.org/locale"></ulink> - and <ulink url="http://userguide.icu-project.org/collation/api"></ulink> for + See <ulink url="https://unicode-org.github.io/icu/userguide/locale/"></ulink> + and <ulink url="https://unicode-org.github.io/icu/userguide/collation/api.html"></ulink> for information on ICU locale naming. The set of acceptable names and attributes depends on the particular ICU version. </para> @@ -842,10 +842,6 @@ CREATE COLLATION german (provider = libc, locale = 'de_DE'); subtag) can be found in the <ulink url="https://github.com/unicode-org/cldr/blob/master/common/bcp47/collation.xml">CLDR repository</ulink>. - The <ulink url="https://ssl.icu-project.org/icu-bin/locexp">ICU Locale - Explorer</ulink> can be used to check the details of a particular locale - definition. The examples using the <literal>k*</literal> subtags require - at least ICU version 54. </para> <para> -- 2.31.1 ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-09-29 11:58 Anton Voloshin <[email protected]> parent: Laurenz Albe <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Anton Voloshin @ 2021-09-29 11:58 UTC (permalink / raw) To: Laurenz Albe <[email protected]>; Bruce Momjian <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Pg Docs <[email protected]> On 29/09/2021 17:13, Laurenz Albe wrote: > I had a look at that and tried to build the software from source. > It requires you to build ICU, and even then it failed to build for me. > The build documentation is not very detailed. > So I think we should not link to that. > > I noticed that two more external links have moved. > > Attached is a patch that fixes those links and removes the link to > the locale explorer. +1 from me on both changes. We have to remove the locale explorer link, unfortunately. -- Anton Voloshin Postgres Professional, The Russian Postgres Company https://postgrespro.ru ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-10-04 21:11 Bruce Momjian <[email protected]> parent: Anton Voloshin <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Bruce Momjian @ 2021-10-04 21:11 UTC (permalink / raw) To: Anton Voloshin <[email protected]>; +Cc: Laurenz Albe <[email protected]>; Magnus Hagander <[email protected]>; Pg Docs <[email protected]> On Wed, Sep 29, 2021 at 06:58:55PM +0700, Anton Voloshin wrote: > On 29/09/2021 17:13, Laurenz Albe wrote: > > I had a look at that and tried to build the software from source. > > It requires you to build ICU, and even then it failed to build for me. > > The build documentation is not very detailed. > > So I think we should not link to that. > > > > I noticed that two more external links have moved. > > > > Attached is a patch that fixes those links and removes the link to > > the locale explorer. > > +1 from me on both changes. We have to remove the locale explorer link, > unfortunately. Patch applied back to PG 10, where ICU was added. Thanks everyone for the work on this. -- Bruce Momjian <[email protected]> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion. ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-11-02 13:31 Laurenz Albe <[email protected]> parent: Bruce Momjian <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Laurenz Albe @ 2021-11-02 13:31 UTC (permalink / raw) To: Bruce Momjian <[email protected]>; Anton Voloshin <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Pg Docs <[email protected]> On Mon, 2021-10-04 at 17:11 -0400, Bruce Momjian wrote: > Patch applied back to PG 10, where ICU was added. Thanks everyone for > the work on this. Thanks! I think you can close the commitfest entry: https://commitfest.postgresql.org/35/3059/ Yours, Laurenz Albe ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: [PATCH] fix ICU explorer link in locale documentation @ 2021-11-03 00:33 Bruce Momjian <[email protected]> parent: Laurenz Albe <[email protected]> 0 siblings, 0 replies; 11+ messages in thread From: Bruce Momjian @ 2021-11-03 00:33 UTC (permalink / raw) To: Laurenz Albe <[email protected]>; +Cc: Anton Voloshin <[email protected]>; Magnus Hagander <[email protected]>; Pg Docs <[email protected]> On Tue, Nov 2, 2021 at 02:31:29PM +0100, Laurenz Albe wrote: > On Mon, 2021-10-04 at 17:11 -0400, Bruce Momjian wrote: > > Patch applied back to PG 10, where ICU was added. Thanks everyone for > > the work on this. > > Thanks! > > I think you can close the commitfest entry: > https://commitfest.postgresql.org/35/3059/ Done by someone else: :-) 2021-11-02 19:44:13 Anton Voloshin (a.voloshin) Closed in commitfest 2021-11 with status: Committed -- Bruce Momjian <[email protected]> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion. ^ permalink raw reply [nested|flat] 11+ messages in thread
end of thread, other threads:[~2021-11-03 00:33 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-04-04 07:53 [PATCH] fix ICU explorer link in locale documentation Anton Voloshin <[email protected]> 2021-05-17 20:46 ` Magnus Hagander <[email protected]> 2021-05-27 04:10 ` Anton Voloshin <[email protected]> 2021-05-27 06:59 ` Laurenz Albe <[email protected]> 2021-09-03 19:39 ` Laurenz Albe <[email protected]> 2021-09-27 18:31 ` Bruce Momjian <[email protected]> 2021-09-29 10:13 ` Laurenz Albe <[email protected]> 2021-09-29 11:58 ` Anton Voloshin <[email protected]> 2021-10-04 21:11 ` Bruce Momjian <[email protected]> 2021-11-02 13:31 ` Laurenz Albe <[email protected]> 2021-11-03 00:33 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox