public inbox for [email protected]  

help / color / mirror / Atom feed

From: jian he <[email protected]>
To: David G. Johnston <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: CREATE TABLE LIKE(INCLUDING COMMENTS) description ignored STATISTICS
Date: Thu, 18 Sep 2025 17:03:10 +0800
Message-ID: <CACJufxHmS+S8=4ikGW3_85TLgD_v+WXvabSXP8QGGdD+rRWNZg@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwbzmyEfdJ=LHeBEy0H1A2OYvWu-sOxsG+_qQc+ZZiOJog@mail.gmail.com>
References: <CACJufxG3M3W0Da+yRmu0Wj8mTUDTiEhtScsDFHb5xKfcDXWSZg@mail.gmail.com>
	<CAKFQuwbzmyEfdJ=LHeBEy0H1A2OYvWu-sOxsG+_qQc+ZZiOJog@mail.gmail.com>

On Sun, Sep 7, 2025 at 1:03 PM David G. Johnston
<[email protected]> wrote:
>
> On Saturday, September 6, 2025, jian he <[email protected]> wrote:
>>
>> hi.
>>
>> https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-CREATETABLE-PARMS-LIKE-OPT-COMMENTS
>> """
>> INCLUDING COMMENTS
>> Comments for the copied columns, constraints, and indexes will be copied. The
>> default behavior is to exclude comments, resulting in the copied columns and
>> constraints in the new table having no comments.
>> """
>>
>> The above description should mention that comments on extended
>> statistics will be
>> copied as well?
>>
>
> How about “If specified, existing comments on any copied elements are copied as well.” ?  Let’s fix this by removing the duplication of the list of things allowed to be copied, not by fixing the oversight the duplication permitted.
>

“If specified, existing comments on any copied elements are copied as well.”
some properties/elements don't have comments.

currently doc:
-------------------------------------------------
The optional like_option clauses specify which additional properties
of the original table to copy. Specifying INCLUDING copies the
property, specifying EXCLUDING omits the property. EXCLUDING is the
default. If multiple specifications are made for the same kind of
object, the last one is used. The available options are:

INCLUDING COMMENTS
Comments for the copied columns, constraints, and indexes will be
copied. The default behavior is to exclude comments, resulting in the
copied columns and constraints in the new table having no comments.

------------------------------------------------------------------------
The second sentence is redundant, because we already mentioned:
"EXCLUDING is the default".
So I am ok with:
"Comments for the copied columns, constraints, extended statistics and
 indexes will be copied".
the second sentence "The default behavior is to exclude comments...."
can be removed.

I also found that
https://www.postgresql.org/docs/devel/sql-createforeigntable.html
has the same problem.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: CREATE TABLE LIKE(INCLUDING COMMENTS) description ignored STATISTICS
  In-Reply-To: <CACJufxHmS+S8=4ikGW3_85TLgD_v+WXvabSXP8QGGdD+rRWNZg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox