public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Cramer <[email protected]>
To: Celinio Fer <[email protected]>
Cc: [email protected]
Subject: Re: Default value for the defaultAutoCommit property
Date: Thu, 3 Jun 2021 06:31:41 -0400
Message-ID: <CADK3HHJU+V8+yK167j-4cxb7sKrvH1zcLeyfee-Qu0AG9tc-cg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Good catch.

Thanks, I will fix that.
Dave Cramer
www.postgres.rocks


On Thu, 3 Jun 2021 at 03:49, Celinio Fer <[email protected]> wrote:

> Hi,
> I wonder if the documentation for the JDBC PostgreSQL driver is up to date
> :
> https://jdbc.postgresql.org/documentation/head/ds-cpds.html#ds-cpds-props
> It is written that the default value for the defaultAutoCommit  property
> is false.
>
> However in the source code, the default value is true :
>
> https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/ds/PGConnectionPool...
>
> private boolean defaultAutoCommit = true;
> ...
> /**
>    * Gets whether connections supplied by this pool will have autoCommit
> turned on by default. The
>    * default value is {@code true}, so that autoCommit will be turned on
> by default.
>    *
>    * @return true if connections supplied by this pool will have autoCommit
>    */
>   public boolean isDefaultAutoCommit() {
>     return defaultAutoCommit;
>   }
>
> Did i miss something ?
> Thanks
> Celinio
>
>
>

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Default value for the defaultAutoCommit property
  In-Reply-To: <CADK3HHJU+V8+yK167j-4cxb7sKrvH1zcLeyfee-Qu0AG9tc-cg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox