public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Shinya Kato <[email protected]>
Cc: [email protected]
Subject: Re: Placement of synchronized_standby_slots description in config.sgml
Date: Fri, 6 Feb 2026 09:43:50 +0900
Message-ID: <CAHGQGwF1SdYdH=1WGm3XFa9AfuPi_MB0aeYRH-7hF+nfyua9ew@mail.gmail.com> (raw)
In-Reply-To: <CAOzEurSfRnopNf-dOeUBBaiVZf3KucZej5ZhAzHB0d4NwZTRMw@mail.gmail.com>
References: <CAHGQGwE_LwgXgCrqd08OFteJqdERiF3noqOKu2vt7Kjk4vMiGg@mail.gmail.com>
	<CAOzEurSfRnopNf-dOeUBBaiVZf3KucZej5ZhAzHB0d4NwZTRMw@mail.gmail.com>

On Thu, Feb 5, 2026 at 3:47 PM Shinya Kato <[email protected]> wrote:
>
> On Fri, Jan 23, 2026 at 7:22 PM Fujii Masao <[email protected]> wrote:
> >
> > Hi,
> >
> > synchronized_standby_slots is defined in guc_parameter.dat as part of
> > the REPLICATION_PRIMARY group and appears under the "Primary Server"
> > section in postgresql.conf.sample. However, in the documentation
> > its description is placed under the "Sending Servers" section.
> >
> > Given this, it seems the description should also be under "Primary Server"
> > in the documentation. I've attached a patch that moves it there.
>
> Thank you for the patch! The patch LGTM.

Thanks for the review! I've pushed the patch.


> > Alternatively, if synchronized_standby_slots is intended to be set also
> > on a standby in cascading replication setups, then the current documentation
> > placement may be correct, and instead guc_parameter.dat and
> > postgresql.conf.sample should be updated. My understanding, though,
> > is that this parameter is normally set only on the primary. Right?
>
> You're right. PhysicalWakeupLogicalWalSnd() in walsender.c has this check:
>
>     /*
>      * If we are running in a standby, there is no need to wake up walsenders.
>      * This is because we do not support syncing slots to cascading standbys,
>      * so, there are no walsenders waiting for standbys to catch up.
>      */
>     if (RecoveryInProgress())
>         return;
>
> So this parameter is only meaningful on the primary.

Thanks for confirming this!

Regards,

-- 
Fujii Masao

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Placement of synchronized_standby_slots description in config.sgml
  In-Reply-To: <CAHGQGwF1SdYdH=1WGm3XFa9AfuPi_MB0aeYRH-7hF+nfyua9ew@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox