public inbox for [email protected]  
help / color / mirror / Atom feed
From: Shinya Kato <[email protected]>
To: Fujii Masao <[email protected]>
Cc: [email protected]
Subject: Re: Placement of synchronized_standby_slots description in config.sgml
Date: Thu, 5 Feb 2026 15:47:04 +0900
Message-ID: <CAOzEurSfRnopNf-dOeUBBaiVZf3KucZej5ZhAzHB0d4NwZTRMw@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwE_LwgXgCrqd08OFteJqdERiF3noqOKu2vt7Kjk4vMiGg@mail.gmail.com>
References: <CAHGQGwE_LwgXgCrqd08OFteJqdERiF3noqOKu2vt7Kjk4vMiGg@mail.gmail.com>

On Fri, Jan 23, 2026 at 7:22 PM Fujii Masao <[email protected]> wrote:
>
> Hi,
>
> synchronized_standby_slots is defined in guc_parameter.dat as part of
> the REPLICATION_PRIMARY group and appears under the "Primary Server"
> section in postgresql.conf.sample. However, in the documentation
> its description is placed under the "Sending Servers" section.
>
> Given this, it seems the description should also be under "Primary Server"
> in the documentation. I've attached a patch that moves it there.

Thank you for the patch! The patch LGTM.

> Alternatively, if synchronized_standby_slots is intended to be set also
> on a standby in cascading replication setups, then the current documentation
> placement may be correct, and instead guc_parameter.dat and
> postgresql.conf.sample should be updated. My understanding, though,
> is that this parameter is normally set only on the primary. Right?

You're right. PhysicalWakeupLogicalWalSnd() in walsender.c has this check:

    /*
     * If we are running in a standby, there is no need to wake up walsenders.
     * This is because we do not support syncing slots to cascading standbys,
     * so, there are no walsenders waiting for standbys to catch up.
     */
    if (RecoveryInProgress())
        return;

So this parameter is only meaningful on the primary.

-- 
Best regards,
Shinya Kato
NTT OSS Center





view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Placement of synchronized_standby_slots description in config.sgml
  In-Reply-To: <CAOzEurSfRnopNf-dOeUBBaiVZf3KucZej5ZhAzHB0d4NwZTRMw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox