public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Vignesh Raghunathan <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: Possible mistake in Section 63.6 - 9.6devel Documentation
Date: Fri, 11 Sep 2015 13:04:03 +0900
Message-ID: <CAHGQGwHTBwop0AzfWz0KNGCYeys8Wru09jwd2vUdjdY_tCZ+vw@mail.gmail.com> (raw)
In-Reply-To: <CAB7nPqSSX8yYkzHrsFDChvEpwWuMekrW2RV+yJR7WLKa6Xf4Fg@mail.gmail.com>
References: <CAD_AmVgk899Ld2=YTg=7qcOAs5OE4BL1sQ+ZR+N7LDT9MrS8Aw@mail.gmail.com>
	<CAB7nPqSV1kR6FqWf2rOVter5cXAW8oTH+DKZjwP4Meji5do5wg@mail.gmail.com>
	<CAHGQGwH9ccoz=Ryf=9ft9QfmkFkff1wAsxXdthnGu88Cvw3VpQ@mail.gmail.com>
	<CAB7nPqSSX8yYkzHrsFDChvEpwWuMekrW2RV+yJR7WLKa6Xf4Fg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On Thu, Sep 10, 2015 at 3:05 PM, Michael Paquier
<[email protected]> wrote:
> On Thu, Sep 10, 2015 at 12:42 AM, Fujii Masao <[email protected]> wrote:
>> On Tue, Jul 21, 2015 at 9:59 AM, Michael Paquier
>> <[email protected]> wrote:
>>> On Tue, Jul 21, 2015 at 6:54 AM, Vignesh Raghunathan
>>> <[email protected]> wrote:
>>>> Hello,
>>>>
>>>> It has been mentioned in Section 63.6 that the first two fields in
>>>> PageHeaderData track the most recent WAL entry related to the page. However,
>>>> I am not sure how pd_checksum is related to WAL. Could it be possible that
>>>> the sentence has been carried over from previous versions of the
>>>> documentations without considering the change to the second field in
>>>> PageHeaderData?
>>>
>>> Yes, the documentation is mistaken. The two bytes of pd_tli have been
>>> switched to pd_checksum in 9.3, hence only the first field is relevant
>>> for WAL, aka pd_lsn. Looking at this portion of the docs I think that
>>> it should be updated as attached, mentioning pd_checksum as well.
>>
>> Also the type of pd_lsn in the Table 63-3 should be PageXLogRecPtr.
>
> Yep. See attached FWIW.

Thanks! Applied.

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Possible mistake in Section 63.6 - 9.6devel Documentation
  In-Reply-To: <CAHGQGwHTBwop0AzfWz0KNGCYeys8Wru09jwd2vUdjdY_tCZ+vw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox