public inbox for [email protected]
help / color / mirror / Atom feedRewording for ALTER TABLE ... ADD table_constraint_using_index
2+ messages / 2 participants
[nested] [flat]
* Rewording for ALTER TABLE ... ADD table_constraint_using_index
@ 2015-08-26 23:31 Josh Kupershmidt <[email protected]>
2023-11-25 01:07 ` Re: [DOCS] Rewording for ALTER TABLE ... ADD table_constraint_using_index Bruce Momjian <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Josh Kupershmidt @ 2015-08-26 23:31 UTC (permalink / raw)
To: pgsql-docs
I'd like to propose the following slight rewording for the note about ALTER
TABLE ... ADD table_constraint_using_index. The existing text says one may
"install it [the existing index] as an official constraint".
The "official constraint" phrase sounds like weasel wording to me -- how is
a UNIQUE constraint more "official" than an UNIQUE index? Then "install"
makes it sound like some installation process is going on that you should
be aware of. I like "convert" slightly better instead.
Josh
diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
new file mode 100644
index 92e9ce8..784f5b4
*** a/doc/src/sgml/ref/alter_table.sgml
--- b/doc/src/sgml/ref/alter_table.sgml
*************** ALTER TABLE ALL IN TABLESPACE <replaceab
*** 320,327 ****
Adding a constraint using an existing index can be helpful in
situations where a new constraint needs to be added without blocking
table updates for a long time. To do that, create the index using
! <command>CREATE INDEX CONCURRENTLY</>, and then install it as an
! official constraint using this syntax. See the example below.
</para>
</note>
</listitem>
--- 320,327 ----
Adding a constraint using an existing index can be helpful in
situations where a new constraint needs to be added without blocking
table updates for a long time. To do that, create the index using
! <command>CREATE UNIQUE INDEX CONCURRENTLY</>, and then convert it to a
! constraint using this syntax. See the example below.
</para>
</note>
</listitem>
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Attachments:
[text/plain] alter_table_table_constraint_using_index.diff (1.1K, 3-alter_table_table_constraint_using_index.diff)
download | inline diff:
diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
new file mode 100644
index 92e9ce8..784f5b4
*** a/doc/src/sgml/ref/alter_table.sgml
--- b/doc/src/sgml/ref/alter_table.sgml
*************** ALTER TABLE ALL IN TABLESPACE <replaceab
*** 320,327 ****
Adding a constraint using an existing index can be helpful in
situations where a new constraint needs to be added without blocking
table updates for a long time. To do that, create the index using
! <command>CREATE INDEX CONCURRENTLY</>, and then install it as an
! official constraint using this syntax. See the example below.
</para>
</note>
</listitem>
--- 320,327 ----
Adding a constraint using an existing index can be helpful in
situations where a new constraint needs to be added without blocking
table updates for a long time. To do that, create the index using
! <command>CREATE UNIQUE INDEX CONCURRENTLY</>, and then convert it to a
! constraint using this syntax. See the example below.
</para>
</note>
</listitem>
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [DOCS] Rewording for ALTER TABLE ... ADD table_constraint_using_index
2015-08-26 23:31 Rewording for ALTER TABLE ... ADD table_constraint_using_index Josh Kupershmidt <[email protected]>
@ 2023-11-25 01:07 ` Bruce Momjian <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Momjian @ 2023-11-25 01:07 UTC (permalink / raw)
To: Josh Kupershmidt <[email protected]>; +Cc: pgsql-docs
On Wed, Aug 26, 2015 at 07:31:53PM -0400, Josh Kupershmidt wrote:
> I'd like to propose the following slight rewording for the note about ALTER
> TABLE ... ADDÂ table_constraint_using_index. The existing text says one may
> "install it [the existing index] as an official constraint".
>
> The "official constraint" phrase sounds like weasel wording to me -- how is a
> UNIQUE constraint more "official" than an UNIQUE index? Then "install" makes it
> sound like some installation process is going on that you should be aware of. I
> like "convert" slightly better instead.
Nine year old patch, but still valid, so applied to master.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-11-25 01:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2015-08-26 23:31 Rewording for ALTER TABLE ... ADD table_constraint_using_index Josh Kupershmidt <[email protected]>
2023-11-25 01:07 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox