public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G. Johnston <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Cc: Joe Conway <[email protected]>
Cc: [email protected]
Subject: Re: dblink_error_message return value
Date: Wed, 8 Aug 2018 09:58:43 -0700
Message-ID: <CAKFQuwYQwpS_qGdt7hWfsQnsrD9eZX0fif6tQNzhCHTZ80f-YA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Wed, Aug 8, 2018 at 8:57 AM, Tom Lane <[email protected]> wrote:

> > Secondly
> > dblink_is_busy must be first called to make dblink_error_message returns
> an
> > error message. (Tested on 9.6.9)
>
> Meh.  I see what you're getting at here, I think, but that seems like a
> completely wrong/misleading statement of the issue.  Joe, can you think of
> better phraseology?
>

I would suggest that while rewording might be useful a more beneficial
improvement would be separating the commands into "Sync/ASync" and link
back into the corresponding libpq documentation sections which dblink
provides direct SQL layer access to (and which the docs seem to have been
written under the assumption the reader was knowledgeable of that API).  It
does abstract away some of the material in the libpq docs but I think it
would be a reasonable halfway measure in lieu of spending time enhancing
the mostly obsolete dblink extension documentation.

David J.

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: dblink_error_message return value
  In-Reply-To: <CAKFQuwYQwpS_qGdt7hWfsQnsrD9eZX0fif6tQNzhCHTZ80f-YA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox