public inbox for [email protected]  
help / color / mirror / Atom feed
Omission of "(or C)" in psql's "pset title" header
10+ messages / 3 participants
[nested] [flat]

* Omission of "(or C)" in psql's "pset title" header
@ 2015-06-24 22:11  David G. Johnston <[email protected]>
  0 siblings, 3 replies; 10+ messages in thread

From: David G. Johnston @ 2015-06-24 22:11 UTC (permalink / raw)
  To: pgsql-docs

http://www.postgresql.org/docs/devel/static/app-psql.html

The other pset keywords with black-slash aliases include a "(or <letter>)"
paren after the keyword.  "title" does not (should be "C")

David J.


^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-06-30 00:09  Monica Gamazo <[email protected]>
  parent: David G. Johnston <[email protected]>
  2 siblings, 0 replies; 10+ messages in thread

From: Monica Gamazo @ 2015-06-30 00:09 UTC (permalink / raw)
  To: David G. Johnston <[email protected]>; pgsql-docs

use my whatsapp 593987847535  Atte.Ing. Mónica GamazoIngeniera en Sistemas Computacionales
GAMAZO_SYS
Celular: 0987847535
skype: monicagamazo
Pagina web: http://www.computrabajo.com.ec/cvs/gamazosys 


     El Miércoles 24 de junio de 2015 17:12, David G. Johnston <[email protected]> escribió:
   

 http://www.postgresql.org/docs/devel/static/app-psql.html

The other pset keywords with black-slash aliases include a "(or <letter>)" paren after the keyword.  "title" does not (should be "C")
David J.




^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-06-30 00:11  Monica Gamazo <[email protected]>
  parent: David G. Johnston <[email protected]>
  2 siblings, 0 replies; 10+ messages in thread

From: Monica Gamazo @ 2015-06-30 00:11 UTC (permalink / raw)
  To: David G. Johnston <[email protected]>; pgsql-docs

all commands are used in operative system linux or unix  Atte.Ing. Mónica GamazoIngeniera en Sistemas Computacionales
GAMAZO_SYS
Celular: 0987847535
skype: monicagamazo
Pagina web: http://www.computrabajo.com.ec/cvs/gamazosys 


     El Miércoles 24 de junio de 2015 17:12, David G. Johnston <[email protected]> escribió:
   

 http://www.postgresql.org/docs/devel/static/app-psql.html

The other pset keywords with black-slash aliases include a "(or <letter>)" paren after the keyword.  "title" does not (should be "C")
David J.




^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-08-27 02:02  Bruce Momjian <[email protected]>
  parent: David G. Johnston <[email protected]>
  2 siblings, 2 replies; 10+ messages in thread

From: Bruce Momjian @ 2015-08-27 02:02 UTC (permalink / raw)
  To: David G. Johnston <[email protected]>; +Cc: pgsql-docs

On Wed, Jun 24, 2015 at 06:11:20PM -0400, David G. Johnston wrote:
> http://www.postgresql.org/docs/devel/static/app-psql.html
> 
> The other pset keywords with black-slash aliases include a "(or <letter>)"
> paren after the keyword.  "title" does not (should be "C")

Attached is a patch to implement this, including a doc patch.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Attachments:

  [text/x-diff] title.diff (1.7K, 2-title.diff)
  download | inline diff:
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
new file mode 100644
index f996865..9361591
*** a/doc/src/sgml/ref/psql-ref.sgml
--- b/doc/src/sgml/ref/psql-ref.sgml
*************** lo_import 152801
*** 2336,2342 ****
            </varlistentry>
  
            <varlistentry>
!           <term><literal>title</literal></term>
            <listitem>
            <para>
            Sets the table title for any subsequently printed tables. This
--- 2336,2342 ----
            </varlistentry>
  
            <varlistentry>
!           <term><literal>title</literal> (or <literal>C</literal>)</term>
            <listitem>
            <para>
            Sets the table title for any subsequently printed tables. This
diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c
new file mode 100644
index 6181a61..293c520
*** a/src/bin/psql/command.c
--- b/src/bin/psql/command.c
*************** do_pset(const char *param, const char *v
*** 2636,2642 ****
  	}
  
  	/* set title override */
! 	else if (strcmp(param, "title") == 0)
  	{
  		free(popt->title);
  		if (!value)
--- 2636,2642 ----
  	}
  
  	/* set title override */
! 	else if (strcmp(param, "C") == 0 || strcmp(param, "title") == 0)
  	{
  		free(popt->title);
  		if (!value)
*************** printPsetInfo(const char *param, struct
*** 2836,2842 ****
  	}
  
  	/* show title override */
! 	else if (strcmp(param, "title") == 0)
  	{
  		if (popt->title)
  			printf(_("Title is \"%s\".\n"), popt->title);
--- 2836,2842 ----
  	}
  
  	/* show title override */
! 	else if (strcmp(param, "C") == 0 || strcmp(param, "title") == 0)
  	{
  		if (popt->title)
  			printf(_("Title is \"%s\".\n"), popt->title);


^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-08-27 02:51  David G. Johnston <[email protected]>
  parent: Bruce Momjian <[email protected]>
  1 sibling, 1 reply; 10+ messages in thread

From: David G. Johnston @ 2015-08-27 02:51 UTC (permalink / raw)
  To: Bruce Momjian <[email protected]>; +Cc: pgsql-docs

On Wed, Aug 26, 2015 at 10:02 PM, Bruce Momjian <[email protected]> wrote:

> On Wed, Jun 24, 2015 at 06:11:20PM -0400, David G. Johnston wrote:
> > http://www.postgresql.org/docs/devel/static/app-psql.html
> >
> > The other pset keywords with black-slash aliases include a "(or
> <letter>)"
> > paren after the keyword.  "title" does not (should be "C")
>
> Attached is a patch to implement this, including a doc patch.
>
>
​Wasn't expecting a code change - just the docs.  The docs already said the
"\C [ title ]" is a valid meta-command...

Did you maybe end up making a command line "-C 'title'" valid instead?

David J.


^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-08-27 15:13  Bruce Momjian <[email protected]>
  parent: David G. Johnston <[email protected]>
  0 siblings, 1 reply; 10+ messages in thread

From: Bruce Momjian @ 2015-08-27 15:13 UTC (permalink / raw)
  To: David G. Johnston <[email protected]>; +Cc: pgsql-docs

On Wed, Aug 26, 2015 at 10:51:09PM -0400, David G. Johnston wrote:
> On Wed, Aug 26, 2015 at 10:02 PM, Bruce Momjian <[email protected]> wrote:
> 
>     On Wed, Jun 24, 2015 at 06:11:20PM -0400, David G. Johnston wrote:
>     > http://www.postgresql.org/docs/devel/static/app-psql.html
>     >
>     > The other pset keywords with black-slash aliases include a "(or <letter>)
>     "
>     > paren after the keyword.  "title" does not (should be "C")
> 
>     Attached is a patch to implement this, including a doc patch.
> 
> 
> 
> ​Wasn't expecting a code change - just the docs.  The docs already said the "\C
> [ title ]" is a valid meta-command...
> 
> Did you maybe end up making a command line "-C 'title'" valid instead?

Obviously I am not understanding you. I thought you were looking for
\pset C to be documented, and to work:

	test=> \pset C test
	Title is "test".

That does not work in the current sources, so I had to add it.  This is
similar to how "\pset t" works as an alias for "\pset tuples_only":

	test=> \pset t
	Tuples only is on.

When our docs say:

    <term><literal>tuples_only</literal> (or <literal>t</literal>)</term>

it is not talking about using \t, but rather "\pset t" --- perhaps that
is where the confusion is coming from.  (Yeah, I know it is kind of
odd.)

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-08-27 15:50  David G. Johnston <[email protected]>
  parent: Bruce Momjian <[email protected]>
  0 siblings, 1 reply; 10+ messages in thread

From: David G. Johnston @ 2015-08-27 15:50 UTC (permalink / raw)
  To: Bruce Momjian <[email protected]>; +Cc: pgsql-docs

On Thu, Aug 27, 2015 at 11:13 AM, Bruce Momjian <[email protected]> wrote:

> On Wed, Aug 26, 2015 at 10:51:09PM -0400, David G. Johnston wrote:
> > On Wed, Aug 26, 2015 at 10:02 PM, Bruce Momjian <[email protected]>
> wrote:
> >
> >     On Wed, Jun 24, 2015 at 06:11:20PM -0400, David G. Johnston wrote:
> >     > http://www.postgresql.org/docs/devel/static/app-psql.html
> >     >
> >     > The other pset keywords with black-slash aliases include a "(or
> <letter>)
> >     "
> >     > paren after the keyword.  "title" does not (should be "C")
> >
> >     Attached is a patch to implement this, including a doc patch.
> >
> >
> >
> > ​Wasn't expecting a code change - just the docs.  The docs already said
> the "\C
> > [ title ]" is a valid meta-command...
> >
> > Did you maybe end up making a command line "-C 'title'" valid instead?
>
> Obviously I am not understanding you. I thought you were looking for
> \pset C to be documented, and to work:
>
>         test=> \pset C test
>         Title is "test".
>
> That does not work in the current sources, so I had to add it.  This is
> similar to how "\pset t" works as an alias for "\pset tuples_only":
>
>         test=> \pset t
>         Tuples only is on.
>
> When our docs say:
>
>     <term><literal>tuples_only</literal> (or <literal>t</literal>)</term>
>
> it is not talking about using \t, but rather "\pset t" --- perhaps that
> is where the confusion is coming from.  (Yeah, I know it is kind of
> odd.)
>
>
​Yes, I read that as "\pset tuples_only" and "\t" are alternate forms of
the same thing
​ and thought that "\pset title" and "\C" should be documented similarly.
Making "\pset C <label>" work doesn't seem like an improvement.

David J.


^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-08-27 16:06  Bruce Momjian <[email protected]>
  parent: David G. Johnston <[email protected]>
  0 siblings, 1 reply; 10+ messages in thread

From: Bruce Momjian @ 2015-08-27 16:06 UTC (permalink / raw)
  To: David G. Johnston <[email protected]>; +Cc: pgsql-docs

On Thu, Aug 27, 2015 at 11:50:53AM -0400, David G. Johnston wrote:
> ​Yes, I read that as "\pset tuples_only" and "\t" are alternate forms of the
> same thing
> ​ and thought that "\pset title" and "\C" should be documented similarly. 
> Making "\pset C <label>" work doesn't seem like an improvement.

Well, making \pset C is at least consistent.  We can't say "or C"
without it.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs



^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-08-27 16:16  David G. Johnston <[email protected]>
  parent: Bruce Momjian <[email protected]>
  0 siblings, 0 replies; 10+ messages in thread

From: David G. Johnston @ 2015-08-27 16:16 UTC (permalink / raw)
  To: Bruce Momjian <[email protected]>; +Cc: pgsql-docs

On Thursday, August 27, 2015, Bruce Momjian <[email protected]> wrote:

> On Thu, Aug 27, 2015 at 11:50:53AM -0400, David G. Johnston wrote:
> > ​Yes, I read that as "\pset tuples_only" and "\t" are alternate forms of
> the
> > same thing
> > ​ and thought that "\pset title" and "\C" should be documented
> similarly.
> > Making "\pset C <label>" work doesn't seem like an improvement.
>
> Well, making \pset C is at least consistent.  We can't say "or C"
> without it.
>
>
Agreed.


^ permalink  raw  reply  [nested|flat] 10+ messages in thread

* Re: Omission of "(or C)" in psql's "pset title" header
@ 2015-10-06 00:56  Bruce Momjian <[email protected]>
  parent: Bruce Momjian <[email protected]>
  1 sibling, 0 replies; 10+ messages in thread

From: Bruce Momjian @ 2015-10-06 00:56 UTC (permalink / raw)
  To: David G. Johnston <[email protected]>; +Cc: pgsql-docs

On Wed, Aug 26, 2015 at 10:02:26PM -0400, Bruce Momjian wrote:
> On Wed, Jun 24, 2015 at 06:11:20PM -0400, David G. Johnston wrote:
> > http://www.postgresql.org/docs/devel/static/app-psql.html
> > 
> > The other pset keywords with black-slash aliases include a "(or <letter>)"
> > paren after the keyword.  "title" does not (should be "C")
> 
> Attached is a patch to implement this, including a doc patch.

Patch applied.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Roman grave inscription                             +


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs




^ permalink  raw  reply  [nested|flat] 10+ messages in thread


end of thread, other threads:[~2015-10-06 00:56 UTC | newest]

Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2015-06-24 22:11 Omission of "(or C)" in psql's "pset title" header David G. Johnston <[email protected]>
2015-06-30 00:09 ` Monica Gamazo <[email protected]>
2015-06-30 00:11 ` Monica Gamazo <[email protected]>
2015-08-27 02:02 ` Bruce Momjian <[email protected]>
2015-08-27 02:51   ` David G. Johnston <[email protected]>
2015-08-27 15:13     ` Bruce Momjian <[email protected]>
2015-08-27 15:50       ` David G. Johnston <[email protected]>
2015-08-27 16:06         ` Bruce Momjian <[email protected]>
2015-08-27 16:16           ` David G. Johnston <[email protected]>
2015-10-06 00:56   ` Bruce Momjian <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox