public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G Johnston <[email protected]>
To: [email protected]
Subject: Re: disabling log_rotation_age feature.
Date: Thu, 12 Jun 2014 08:35:16 -0700 (PDT)
Message-ID: <CAKFQuwayss-PaqZ9+vCfc5h-WUKRtf7Lkn20THfWssmv1qa5eA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAHGQGwEPVu2T39Zddvh-CubJ9Ghyz4Gf1-JGqqvu5Ja7m5BJ7w@mail.gmail.com>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On Thu, Jun 12, 2014 at 10:42 AM, Tom Lane-2 [via PostgreSQL] <
[email protected]> wrote:

> Fujii Masao <[hidden email]
> <http://user/SendEmail.jtp?type=node&node=5807014&i=0>; writes:
> > On Thu, Jun 12, 2014 at 1:43 PM, Tomonari Katsumata
> > <[hidden email] <http://user/SendEmail.jtp?type=node&node=5807014&i=1>;
> wrote:
> >> The document tells us to set it to ZERO if we want to disable the
> feature.
> >> However, the feature would be disabled if we set it less than one
> minute.
>
> > That's because log_rotation_age expects the setting value in minutes.
>
> > This is not a problem only for log_rotation_age. When setting the
> parameter
> > which expects the value in seconds to less than one second, the setting
> value
> > is implicitly reset to the default.
>
> It's not "reset to default", it's set to zero due to rounding the fraction
> down.  Some GUCs interpret zero specially, some don't.
>
> I wonder if we should round fractions up instead of down in that logic?
> It might be less surprising for those GUCs where zero is special, and
> it seems like about a wash for most others.
>
>
>
​I think documenting the behavior better, which I would do as part of the
larger patch I'm working on here:

[9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
http://www.postgresql.org/message-id/[email protected]....

would be sufficient.

Green field maybe I'd say yes but given that the new behavior could turn
features on that are currently off it doesn't seem to be beneficial enough
to warrant changing.

David J.




--
View this message in context: http://postgresql.1045698.n5.nabble.com/disabling-log-rotation-age-feature-tp5806936p5807032.html
Sent from the PostgreSQL - docs mailing list archive at Nabble.com.

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: disabling log_rotation_age feature.
  In-Reply-To: <CAKFQuwayss-PaqZ9+vCfc5h-WUKRtf7Lkn20THfWssmv1qa5eA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox