Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?

public inbox for [email protected]  
help / color / mirror / Atom feed

From: David Johnston <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
Date: Tue, 9 Sep 2014 15:40:45 -0400
Message-ID: <CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwbjqT7jHAULPM0YB7x=+qpddH5bYnGmwZ+yVhNBb6SVnQ@mail.gmail.com>
	<CAKFQuwa5d3EUBGwYN1mA6FKO1K7kO+Wci8yM57QNHdEGQ9TJ9g@mail.gmail.com>
	<CAKFQuwbbOZRqmnx-XRyd+viT+MCAH6TVc0yn1aJtG5MdSNAWpA@mail.gmail.com>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On Tue, Sep 9, 2014 at 3:13 PM, Bruce Momjian <[email protected]> wrote:

> On Thu, Jun 12, 2014 at 11:32:49AM -0400, David Johnston wrote:
> > This addition still needs some work as well as the patch as a whole (see
> my
> > comments above).  The attached PDF is the page that results from "make
> html";
> > the original patch has been re-attached as well and -hackers copied
> given the
> > lack of response on -doc.
> >
> > I am hoping this change would be something that could be included in
> 9.4; I
> > believe the enhancements would be most beneficial to newcomers who are
> just
> > getting started with PostgreSQL and would be using 9.4 as their starting
> point.
>
> [hackers CC removed]
>
> I have reviewed and updated this reworking of our configuration settings
> documentation and feel it is ready for application to head and 9.4;
> attached.
>
>
Minor corrections:

First block: "
In the first section of this chapter, we
 describe how to set configuration parameters"

- remove the comma

Second Block:
- placement of the colon inside or outside of the emphasis tag is
inconsistent (string, unit, enum are inside; boolean and numeric are
outside)
- units:  "An numeric value..." -> maybe "An unadorned numeric value...

Third block:
"Hash marks (<literal>#</literal>) designate the remainder of lines as
comments." -> "...designate the remainder of the line as a comment."  I
read this at first as "remaining lines [in the file] ... "

"To embed a single quote in a parameter value, write either two quotes
(preferred) or backslash-quote." -> remove the comma
"Querying this view is the sames as" -> "the same as"
"In addition to setting global defaults or attaching" <- add a comma after
"defaults"

A few extra commas here-and-there which seem to have replaced my use of
colons but that maybe should just be removed completely.  If I didn't note
it above it seemed OK to leave in (or I missed it entirely...)

David J.

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
  In-Reply-To: <CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox