public inbox for [email protected]
help / color / mirror / Atom feedFrom: vignesh C <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Logical Replication upgrade
Date: Thu, 16 Apr 2026 12:39:09 +0530
Message-ID: <CALDaNm2_XoL7hsn6CMDC6hCpcOaLCKk_n8y1WnKS_-uJYLGwtQ@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwaWUuXJYZSMKtiXFT=kFK-sFg+pSwK0MUN-MBEEobkfBg@mail.gmail.com>
References: <[email protected]>
<CAKFQuwZ86BE49-gzFunuu=u1ieT+T6q900=1Cx=vuO9Aqv9kcg@mail.gmail.com>
<CAA4eK1LR_MjZuV31r-MOqno9-Kr0mA9zas2cxZtE=+X3RUYXbw@mail.gmail.com>
<CAKFQuwbHjB6EEdp6mmaUt4bCTYrYUdvEr44vVqhdT0OD4Z+3Qg@mail.gmail.com>
<CAA4eK1+dR-sEGM+oC7H_-7PrBJBcdM2o5-eS6JrkMBJ0FOA54Q@mail.gmail.com>
<CAKFQuwaWUuXJYZSMKtiXFT=kFK-sFg+pSwK0MUN-MBEEobkfBg@mail.gmail.com>
On Thu, 16 Apr 2026 at 11:16, David G. Johnston
<[email protected]> wrote:
>
> On Wednesday, April 15, 2026, Amit Kapila <[email protected]> wrote:
>>
>>
>> So, how about: "All slots on the old cluster must be usable, i.e.,
>> their pg_replication_slots.conflicting is false."?
>
>
> That works.
>
> Then we’d also change:
>
> The new cluster must not have permanent logical slots, i.e., there must be no slots where pg_replication_slots.temporary is false.
>
> To be:
>
> “The new cluster is only permitted to have temporary logical slots, i.e., ones where pg_replication_slots.temporary is true.”
+1 for this, the attached patch has the changes for the same.
Regards,
Vignesh
Attachments:
[application/octet-stream] 0001-Improve-slot-prerequisite-wording-for-logical-replic.patch (2.1K, ../CALDaNm2_XoL7hsn6CMDC6hCpcOaLCKk_n8y1WnKS_-uJYLGwtQ@mail.gmail.com/2-0001-Improve-slot-prerequisite-wording-for-logical-replic.patch)
download | inline diff:
From 8ab1dc768d74f264b8f5cd025fcb0ce84ced2e69 Mon Sep 17 00:00:00 2001
From: Vignesh C <[email protected]>
Date: Thu, 16 Apr 2026 12:36:34 +0530
Subject: [PATCH] Improve slot prerequisite wording for logical replication
upgrade
Rephrase the logical slot prerequisite checks in the upgrade
documentation to make the conditions easier to read.
The previous wording used negative constructions such as "there are no
slots whose ... is not true" and "must not have permanent logical
slots", which made the requirements harder to parse quickly.
Rewrite these checks using direct positive phrasing:
all slots on the old cluster must have conflicting = false, and the
new cluster may only contain temporary logical slots where temporary =
true.
This improves readability while keeping the meaning unchanged.
---
doc/src/sgml/logical-replication.sgml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 23b268273b9..b112cfde7e7 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -2785,18 +2785,17 @@ CONTEXT: processing remote data for replication origin "pg_16395" during "INSER
</listitem>
<listitem>
<para>
- All slots on the old cluster must be usable, i.e., there are no slots
- whose
+ All slots on the old cluster must be usable, i.e., their
<link linkend="view-pg-replication-slots">pg_replication_slots</link>.<structfield>conflicting</structfield>
- is not <literal>true</literal>.
+ is <literal>false</literal>.
</para>
</listitem>
<listitem>
<para>
- The new cluster must not have permanent logical slots, i.e.,
- there must be no slots where
+ The new cluster is only permitted to have temporary logical slots, i.e.,
+ ones where
<link linkend="view-pg-replication-slots">pg_replication_slots</link>.<structfield>temporary</structfield>
- is <literal>false</literal>.
+ is <literal>true</literal>.
</para>
</listitem>
</itemizedlist>
--
2.43.0
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Logical Replication upgrade
In-Reply-To: <CALDaNm2_XoL7hsn6CMDC6hCpcOaLCKk_n8y1WnKS_-uJYLGwtQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox