public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jeff Janes <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: "Alter system" command documentation
Date: Mon, 15 Jun 2015 19:34:33 -0700
Message-ID: <CAMkU=1zYXjFOpu5daLW_bDAft9GtUNVbQvQaYWJyo3hi0XEKng@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwZnoQKAi9qu_Vb6njo30x46MWZDNSExkvbs+hiOdjmHAA@mail.gmail.com>
References: <CAMkU=1xjSYan=T518E+=J4Ugg8xkymjx5a_hSFx1roB-chKyxw@mail.gmail.com>
	<[email protected]>
	<CAKFQuwZnoQKAi9qu_Vb6njo30x46MWZDNSExkvbs+hiOdjmHAA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On Mon, Jun 15, 2015 at 2:10 PM, David G. Johnston <
[email protected]> wrote:

> On Mon, Jun 15, 2015 at 4:58 PM, Euler Taveira <[email protected]>
> wrote:
>
>> On 15-06-2015 13:32, Jeff Janes wrote:
>> > From http://www.postgresql.org/docs/current/static/sql-altersystem.html
>> >
>> > "Values set with ALTER SYSTEM will be effective after the next server
>> > configuration reload (SIGHUP or pg_ctl reload), or after the next server
>> > restart in the case of parameters that can only be changed at server
>> start."
>> >
>> > Isn't it unfortunate that the command used for changing the
>> > configuration file from within SQL mentions SIGHUP and pg_ctl reload,
>> > but not "select pg_reload_conf();", as a way to activate that change?
>> >
>> SIGHUP is an implementation detail. If I were to change that sentence,
>> my preference is replace SIGHUP with pg_reload_conf.
>> ​
>>
>
> ​I ​
> disagree on SIGHUP being an implementation detail.
> ​
> ​  Using signals in IPC (inter-process communication) is a public API that
> should be documented when applicable.  Yes, various command-line and SQL
> commands and functions have been provided so that one does not have to use
> raw signals but they are still part of the public API for the application.
>
> Adding mention of pg_reload_conf may be warranted (probably is but I
> haven't made an independent evaluation) but removing SIGHUP is a separate
> concern and one that doesn't seem necessary.
>

Certainly SIGHUP should be (and is) documented elsewhere in the docs.  But
there is no reason for it to be documented on this particular page, which
is about a command we added specifically so you can make config changes
without having to drop into an OS shell.  If we are going to mention (on
this particularly page) only some of the ways to trigger a reload,
certainly the way that also doesn't require dropping into an OS shell
should be among the ones included. I don't know that pg_reload_conf()
should be the only one we mention here.  But surely it should not be the
only one we don't mention.

The cleanest way would probably be to mention this in addition to the other
two, as to mention only this one might imply the others don't work for this
purpose.  We could not mention any of them and let the person go read the
other parts of the docs on their own to find the methods used to trigger a
reload, but that seems legalistic and unhelpful.

In any event, I was mildly annoyed to go read the docs about a feature I
was aware of but never needed to use it before, and have it tell me about
two things which I already knew about but which aren't very useful in this
context (that is, not having convenient shell access at the moment), while
not telling me about the third option which actually is useful in this
context but which I didn't know how to spell (because I almost always use
the other two methods instead--except for right now).

Cheers,

Jeff

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: "Alter system" command documentation
  In-Reply-To: <CAMkU=1zYXjFOpu5daLW_bDAft9GtUNVbQvQaYWJyo3hi0XEKng@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox