public inbox for [email protected]
help / color / mirror / Atom feedTrailing semicolons on partitioning example commands
2+ messages / 2 participants
[nested] [flat]
* Trailing semicolons on partitioning example commands
@ 2018-01-26 14:27 Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Gustafsson @ 2018-01-26 14:27 UTC (permalink / raw)
To: pgsql-docs
Is there a reason for not ending all partitioning commands with semicolons in
the declarative partitioning example?
https://www.postgresql.org/docs/devel/static/ddl-partitioning.html
The two last commands with TABLESPACE clauses are ended with semicolons, the
first three arent. Attached patch adds semicolons such that all are properly
ended.
cheers ./daniel
Attachments:
[application/octet-stream] partcmd_semicolon.patch (1.2K, 2-partcmd_semicolon.patch)
download | inline diff:
From 92e1b2fe5a470eb008e3b22a5706ffde1b915009 Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <[email protected]>
Date: Fri, 26 Jan 2018 15:13:37 +0100
Subject: [PATCH] doc: End partition commands with trailing semicolon
---
doc/src/sgml/ddl.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index 3244399782..1e1f3428a6 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -3097,14 +3097,14 @@ CREATE TABLE measurement (
<programlisting>
CREATE TABLE measurement_y2006m02 PARTITION OF measurement
- FOR VALUES FROM ('2006-02-01') TO ('2006-03-01')
+ FOR VALUES FROM ('2006-02-01') TO ('2006-03-01');
CREATE TABLE measurement_y2006m03 PARTITION OF measurement
- FOR VALUES FROM ('2006-03-01') TO ('2006-04-01')
+ FOR VALUES FROM ('2006-03-01') TO ('2006-04-01');
...
CREATE TABLE measurement_y2007m11 PARTITION OF measurement
- FOR VALUES FROM ('2007-11-01') TO ('2007-12-01')
+ FOR VALUES FROM ('2007-11-01') TO ('2007-12-01');
CREATE TABLE measurement_y2007m12 PARTITION OF measurement
FOR VALUES FROM ('2007-12-01') TO ('2008-01-01')
--
2.14.1.145.gb3622a4ee
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Trailing semicolons on partitioning example commands
@ 2018-01-27 12:15 Magnus Hagander <[email protected]>
parent: Daniel Gustafsson <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Magnus Hagander @ 2018-01-27 12:15 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: pgsql-docs
On Fri, Jan 26, 2018 at 3:27 PM, Daniel Gustafsson <[email protected]> wrote:
> Is there a reason for not ending all partitioning commands with semicolons
> in
> the declarative partitioning example?
>
> https://www.postgresql.org/docs/devel/static/ddl-partitioning.html
>
> The two last commands with TABLESPACE clauses are ended with semicolons,
> the
> first three arent. Attached patch adds semicolons such that all are
> properly
> ended.
>
I cant see one, since all the other examples do.
Thus, pushed. Thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2018-01-27 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 14:27 Trailing semicolons on partitioning example commands Daniel Gustafsson <[email protected]>
2018-01-27 12:15 ` Magnus Hagander <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox