public inbox for [email protected]  

help / color / mirror / Atom feed

From: Matheus Alcantara <[email protected]>
To: Fujii Masao <[email protected]>
To: [email protected]
Subject: Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs
Date: Thu, 19 Feb 2026 12:09:57 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwHSOSGcaYDvHF8EYCUCfGPjbRwGFsJ23cx5KbJ1X6JouQ@mail.gmail.com>
References: <CAHGQGwHSOSGcaYDvHF8EYCUCfGPjbRwGFsJ23cx5KbJ1X6JouQ@mail.gmail.com>

On Tue Feb 17, 2026 at 11:36 AM -03, Fujii Masao wrote:
> Hi,
>
>> Comments for the copied columns, constraints, and indexes will be copied.
>
> The above current description of INCLUDING COMMENTS in the CREATE TABLE docs
> appears inaccurate and incomplete. It says that comments on constraints are
> copied, but in practice only comments on CHECK and NOT NULL constraints
> are copied; comments on other constraints (such as primary keys) are not.
> In addition, comments on extended statistics are copied, but this is not
> documented.
>
> The CREATE FOREIGN TABLE docs has a similar omission: comments on extended
> statistics are also copied, but this is not mentioned.
>
> Therefore I'd like to propose the attached patch to clarify the actual behavior
> of INCLUDING COMMENTS. Thoughts?
>

Hi, thanks for the patch.

The changes make sense to me, it sounds more clear. I've performed some
tests and the documentation seems correct about what comments are
actually copied.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox