From: 周志勤 <joe.zhou@dualhelios.com>
To: David G. Johnston <david.g.johnston@gmail.com>
To: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: Re: Mismatch for connection key/value pair between documentation and code?
Date: Wed, 17 Jul 2024 09:20:49 +0800
Message-ID: <EB76814E921479DE+202407170918484697461@dualhelios.com> (raw)
References: <172110569327.736585.18068265437149291546@wrigleys.postgresql.org>
<CAKFQuwb7ScOPsFqV281m2SBumso7oYN+HWFKDeFrGMLQZA9FRg@mail.gmail.com>
Hi David,
Thanks for your clarification.
Best regards,
Joe
joe.zhou@dualhelios.com
From: David G. Johnston
Date: 2024-07-16 22:20
To: joe.zhou@dualhelios.com; pgsql-docs@lists.postgresql.org
Subject: Re: Mismatch for connection key/value pair between documentation and code?
On Monday, July 15, 2024, PG Doc comments form <noreply@postgresql.org> wrote:
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/libpq-connect.html
Description:
For the following document regarding connect string, it is not aligned with
the code.
https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING
e.g. Timeout for connection
"connect_timeout
Maximum time to wait while connecting, in seconds (write as a decimal
integer, e.g., 10).
However in the code:
https://github.com/npgsql/npgsql/blob/docs/src/Npgsql/NpgsqlConnectionStringBuilder.cs,
starting L789 to L812 (latest version when I raise this ticket).
The name is Timeout instead of connect_timeout, and there's no logic
regarding 2 second check
Probably this third-party module is not using the libpq API. Or at minimum not that aspect of the API.
David J.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: joe.zhou@dualhelios.com, david.g.johnston@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Re: Mismatch for connection key/value pair between documentation and code?
In-Reply-To: <EB76814E921479DE+202407170918484697461@dualhelios.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox