public inbox for [email protected]help / color / mirror / Atom feed
RE: doc: Document how to run regression tests with custom server settings 3+ messages / 2 participants [nested] [flat]
* RE: doc: Document how to run regression tests with custom server settings @ 2021-06-21 07:43 [email protected] <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: [email protected] @ 2021-06-21 07:43 UTC (permalink / raw) To: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Hi I was doing regression testing according to the PG-doc at [1]. The modification at 854434c5 seems not correct, could you please take a check at it? >make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB" The above command reported an error like this: failed: FATAL: parameter "log_checkpoints" cannot be changed now IMHO, as a sighup GUC, log_checkpoints can't be set in PGOPTIONS, is that correct? >make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf" pg_regress: could not open "test_postgresql.conf" to read extra config: No such file or directory I fixed above problem using command like this: make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf" Maybe we can change doc description to tell user he/she should specify the location of " test_postgresql.conf", thoughts? [1] https://www.postgresql.org/docs/devel/regress-run.html Regards, Tang ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: doc: Document how to run regression tests with custom server settings @ 2021-06-30 02:15 Craig Ringer <[email protected]> parent: [email protected] <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Craig Ringer @ 2021-06-30 02:15 UTC (permalink / raw) To: [email protected] <[email protected]>; +Cc: [email protected] <[email protected]>; [email protected] <[email protected]> On Mon, 21 Jun 2021 at 15:43, [email protected] < [email protected]> wrote: > Hi > > I was doing regression testing according to the PG-doc at [1]. > The modification at 854434c5 seems not correct, could you please take a > check at it? > > >make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB" > > The above command reported an error like this: > failed: FATAL: parameter "log_checkpoints" cannot be changed now > > IMHO, as a sighup GUC, log_checkpoints can't be set in PGOPTIONS, is that > correct? > > >make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf" > > pg_regress: could not open "test_postgresql.conf" to read extra config: No > such file or directory > > I fixed above problem using command like this: > make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf" > > Maybe we can change doc description to tell user he/she should specify the > location of " test_postgresql.conf", thoughts? > > [1] https://www.postgresql.org/docs/devel/regress-run.html Yes, that'd make a lot of sense. PGOPTIONS is more suited for client settings. Willing to cook up a quick patch? -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services ^ permalink raw reply [nested|flat] 3+ messages in thread
* RE: doc: Document how to run regression tests with custom server settings @ 2021-07-01 06:48 [email protected] <[email protected]> parent: Craig Ringer <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: [email protected] @ 2021-07-01 06:48 UTC (permalink / raw) To: Craig Ringer <[email protected]>; +Cc: [email protected] <[email protected]>; [email protected] <[email protected]> On Wednesday, June 30, 2021 11:15 AM, Craig Ringer [email protected]<mailto:[email protected]> wrote >Yes, that'd make a lot of sense. > >PGOPTIONS is more suited for client settings. > >Willing to cook up a quick patch? Thanks for replying. Here is my patch to fix the doc issue. Kindly to take at check. Regards, Tang Attachments: [application/octet-stream] 0001-minor-fix-for-regress-example.patch (1.1K, 3-0001-minor-fix-for-regress-example.patch) download | inline diff: From e3c3b3422d66f48e2397af247ad831f6fc6cf373 Mon Sep 17 00:00:00 2001 From: tanghy <[email protected]> Date: Thu, 1 Jul 2021 15:40:06 +0900 Subject: [PATCH] minor fix for regress example diff --git a/doc/src/sgml/regress.sgml b/doc/src/sgml/regress.sgml index cb401a45b3..5e8fa29f9e 100644 --- a/doc/src/sgml/regress.sgml +++ b/doc/src/sgml/regress.sgml @@ -359,14 +359,14 @@ make check LANG=C ENCODING=EUC_JP set in the <varname>PGOPTIONS</varname> environment variable (for settings that allow this): <screen> -make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB" +make check PGOPTIONS="-c geqo=off -c work_mem=50MB" </screen> When running against a temporary installation, custom settings can also be set by supplying a pre-written <filename>postgresql.conf</filename>: <screen> echo 'log_checkpoints = on' > test_postgresql.conf echo 'work_mem = 50MB' >> test_postgresql.conf -make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf" +make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf" </screen> </para> -- 2.31.1.windows.1 ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-07-01 06:48 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-06-21 07:43 RE: doc: Document how to run regression tests with custom server settings [email protected] <[email protected]> 2021-06-30 02:15 ` Craig Ringer <[email protected]> 2021-07-01 06:48 ` [email protected] <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox