From: tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Cc: peter@eisentraut.org <peter@eisentraut.org>
Cc: Craig Ringer <craig.ringer@2ndquadrant.com>
Subject: [Doc] Tiny fix for regression tests example
Date: Fri, 23 Jul 2021 06:12:02 +0000
Message-ID: <OS0PR01MB6113954B883ACEB2DDC973F2FBE59@OS0PR01MB6113.jpnprd01.prod.outlook.com> (raw)
Hi
When reading PG DOC, found some example code not correct as it said.
https://www.postgresql.org/docs/devel/regress-run.html
Here's a tiny fix in regress.sgml.
-make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB"
+make check PGOPTIONS="-c geqo=off -c work_mem=50MB"
log_checkpoints couldn't be set in PGOPTIONS.
Replace log_checkpoints with geqo in the example code.
-make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf"
+make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf"
User needs to specify $(pwd) to let the command execute as expected.
The above example code is added by Peter in PG14. So I think we need to apply this fix at PG14/master.
I proposed this fix at pgsql-docs@lists.postgresql.org<mailto:pgsql-docs@lists.postgresql.org> at [1]. But no reply except Craig. So I please allow me to post the patch at Hackers’ mail list again in case the fix is missed.
[1] https://www.postgresql.org/message-id/OS0PR01MB6113FA937648B8F7A372359BFB009%40OS0PR01MB6113.jpnprd0...
Regards,
Tang
Attachments:
[application/octet-stream] 0001-minor-fix-for-regress-example.patch (1.1K, ../OS0PR01MB6113954B883ACEB2DDC973F2FBE59@OS0PR01MB6113.jpnprd01.prod.outlook.com/3-0001-minor-fix-for-regress-example.patch)
download | inline diff:
From e3c3b3422d66f48e2397af247ad831f6fc6cf373 Mon Sep 17 00:00:00 2001
From: tanghy <tanghy.fnst@fujitsu.com>
Date: Thu, 1 Jul 2021 15:40:06 +0900
Subject: [PATCH] minor fix for regress example
diff --git a/doc/src/sgml/regress.sgml b/doc/src/sgml/regress.sgmlindex cb401a45b3..5e8fa29f9e 100644--- a/doc/src/sgml/regress.sgml+++ b/doc/src/sgml/regress.sgml@@ -359,14 +359,14 @@ make check LANG=C ENCODING=EUC_JP
set in the <varname>PGOPTIONS</varname> environment variable (for settings
that allow this):
<screen>
-make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB"+make check PGOPTIONS="-c geqo=off -c work_mem=50MB"
</screen>
When running against a temporary installation, custom settings can also be
set by supplying a pre-written <filename>postgresql.conf</filename>:
<screen>
echo 'log_checkpoints = on' > test_postgresql.conf
echo 'work_mem = 50MB' >> test_postgresql.conf
-make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf"+make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf"
</screen>
</para>
--
2.31.1.windows.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tanghy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, pgsql-docs@lists.postgresql.org, peter@eisentraut.org, craig.ringer@2ndquadrant.com
Subject: Re: [Doc] Tiny fix for regression tests example
In-Reply-To: <OS0PR01MB6113954B883ACEB2DDC973F2FBE59@OS0PR01MB6113.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox