public inbox for [email protected]  

help / color / mirror / Atom feed

From: [email protected] <[email protected]>
To: Tom Lane <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Michael Paquier <[email protected]>
Subject: RE: pg_type_d.h location incorrect
Date: Thu, 27 May 2021 06:13:36 +0000
Message-ID: <OS0PR01MB61139DA2FBBBB092F5371265FB239@OS0PR01MB6113.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<OS0PR01MB6113637F7DBED4565902A460FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<[email protected]>
	<OS0PR01MB61131DD84072DC0DC5E3E003FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<[email protected]>
	<[email protected]>

On Thursday, May 27, 2021 10:58 AM, Tom Lane <[email protected]> wrote
>So I ended up with the attached --- what do you think?

The doc-fix LGTM. 
But I couldn't apply the patch at HEAD(2941138e60). Maybe you did the fix at a branch other than HEAD?

>Also, looking at this, I note that "~/.pg_service.conf" is still a
>platform-ism.  We could make that slightly better by writing
>"$HOME/.pg_service.conf", but is that good enough?

Agreed. Besides, A lot of places in current Doc have been useing ~/.pg_*** already.
IMHO, it's good to keep the consistency.

Regards,
Tang

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: RE: pg_type_d.h location incorrect
  In-Reply-To: <OS0PR01MB61139DA2FBBBB092F5371265FB239@OS0PR01MB6113.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox