public inbox for [email protected]  

help / color / mirror / Atom feed

From: Greg Smith <[email protected]>
To: [email protected]
Subject: Re: [PATCHES] [PERFORM] Direct I/O issues
Date: Sat, 25 Nov 2006 04:34:52 -0500 (EST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Fri, 24 Nov 2006, Bruce Momjian wrote:

> OK, I modified test_fsync.c by copying the defines from xlog.c, and
> fixed the O_DIRECT alignment and check write()/fsync().

I just tested your new test_fsync as included in the 8.2rc1, and it's 
working perfectly for me now on Linux.  All the O_SYNC writes using 
O_DIRECT are reporting realistic timings.  I'm happy that this code is 
working as it should and appreciate the quick response.  I still think the 
wal_sync_method documentation deserves an update noting that O_DIRECT is 
used when available with the sync write methods.

--
* Greg Smith [email protected] http://www.gregsmith.com Baltimore, MD

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCHES] [PERFORM] Direct I/O issues
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox