public inbox for [email protected]
help / color / mirror / Atom feedchange float4 to floating point about type of autovacuum_vacuum_insert_scale_factor
2+ messages / 2 participants
[nested] [flat]
* change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor
@ 2021-06-16 05:22 [email protected]
2021-06-25 06:17 ` Re: change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor Peter Eisentraut <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: [email protected] @ 2021-06-16 05:22 UTC (permalink / raw)
To: [email protected]
Hi
As shown below, the argument types of autovacuum_vacuum_insert_scale_factor and toast.autovacuum_vacuum_insert_scale_factor are different from the others.
---
autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor (floating point)
autovacuum_vacuum_insert_scale_factor, toast.autovacuum_vacuum_insert_scale_factor (float4)
autovacuum_analyze_scale_factor (floating point)
autovacuum_vacuum_cost_delay, toast.autovacuum_vacuum_cost_delay (floating point)
https://www.postgresql.org/docs/devel/sql-createtable.html
---
In addition, there is this statement.
---
autovacuum_vacuum_insert_scale_factor (floating point)
https://www.postgresql.org/docs/devel/runtime-config-autovacuum.html#GUC-AUTOVACUUM-VACUUM-INSERT-SC...
---
So, I thought it was better to be consistent with "floating point", and I created the patch.
A similar argument can be found here.
https://www.postgresql.org/message-id/[email protected]...
Best Regards,
Shinya Kato
Attachments:
[application/octet-stream] change_float4_to_floating_point.patch (913B, 2-change_float4_to_floating_point.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
index c6d0a35e50..65d3a33ac9 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -1558,7 +1558,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
</varlistentry>
<varlistentry id="reloption-autovacuum-vacuum-insert-scale-factor" xreflabel="autovacuum_vacuum_insert_scale_factor">
- <term><literal>autovacuum_vacuum_insert_scale_factor</literal>, <literal>toast.autovacuum_vacuum_insert_scale_factor</literal> (<type>float4</type>)
+ <term><literal>autovacuum_vacuum_insert_scale_factor</literal>, <literal>toast.autovacuum_vacuum_insert_scale_factor</literal> (<type>floating point</type>)
<indexterm>
<primary><varname>autovacuum_vacuum_insert_scale_factor</varname> </primary>
<secondary>storage parameter</secondary>
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor
2021-06-16 05:22 change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor [email protected]
@ 2021-06-25 06:17 ` Peter Eisentraut <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Peter Eisentraut @ 2021-06-25 06:17 UTC (permalink / raw)
To: [email protected]; [email protected]
On 16.06.21 07:22, [email protected] wrote:
> As shown below, the argument types of autovacuum_vacuum_insert_scale_factor and toast.autovacuum_vacuum_insert_scale_factor are different from the others.
> ---
> autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor (floating point)
> autovacuum_vacuum_insert_scale_factor, toast.autovacuum_vacuum_insert_scale_factor (float4)
> autovacuum_analyze_scale_factor (floating point)
> autovacuum_vacuum_cost_delay, toast.autovacuum_vacuum_cost_delay (floating point)
> https://www.postgresql.org/docs/devel/sql-createtable.html
> ---
>
> So, I thought it was better to be consistent with "floating point", and I created the patch.
committed
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-06-25 06:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 05:22 change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor [email protected]
2021-06-25 06:17 ` Peter Eisentraut <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox