From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: iphatiey5eu2au6@pasms.be
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: temporary file size clarification
Date: Fri, 25 Nov 2022 15:14:04 -0500
Message-ID: <Y4EiDDnoS3C8PtK3@momjian.us> (raw)
In-Reply-To: <77B1C264-8B26-484A-9FE2-8DE82C71EAE4@yesql.se>
References: <166859439833.632.13122583000472281400@wrigleys.postgresql.org>
<Y353x4D2FLPgrc3A@momjian.us>
<77B1C264-8B26-484A-9FE2-8DE82C71EAE4@yesql.se>
On Thu, Nov 24, 2022 at 10:14:20AM +0100, Daniel Gustafsson wrote:
> > On 23 Nov 2022, at 20:43, Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Wed, Nov 16, 2022 at 10:26:38AM +0000, PG Doc comments form wrote:
> >> The following documentation comment has been logged on the website:
> >>
> >> Page: https://www.postgresql.org/docs/14/runtime-config-logging.html
> >> Description:
> >>
> >> The setting log_temp_files will enable logging of the usage of temporary
> >> files, including their size in the log files. The setting is given in
> >> kilobytes, which is clearly documented. However, I could not find any clear
> >> documentation that describes the unit of size that is used in the logfiles
> >> themselves, the log line is something like "profiles@profiles LOG:
> >> temporary file: path "base/pgsql_tmp/pgsql_tmp31863.1", size 3137536" but
> >> there is no size unit in the logfile or in the settings documentation. Can
> >> you add whether the log line is in bytes/kilobytes/megabytes?
> >
> > Uh, I believe it is simply in bytes.
>
> It is, the relevant code path for the logging is:
>
> if ((size / 1024) >= log_temp_files)
> ereport(LOG,
> (errmsg("temporary file: path \"%s\", size %lu",
> path, (unsigned long) size)));
>
> I don't think it's a bad idea to specify the unit in the documentation though,
> as suggested by the OP. Since the setting considers a value without unit as
> kb, and the logged value is without unit, there is room for confusion.
>
> How about something like the attached?
+1
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Embrace your flaws. They make you human, rather than perfect,
which you will never be.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, daniel@yesql.se, iphatiey5eu2au6@pasms.be, pgsql-docs@lists.postgresql.org
Subject: Re: temporary file size clarification
In-Reply-To: <Y4EiDDnoS3C8PtK3@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox