public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: [email protected]
To: [email protected]
Subject: Re: Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix
Date: Wed, 9 Mar 2022 15:04:05 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi Leslie,

On Sat, Mar 05, 2022 at 10:15:33AM +0000, PG Doc comments form wrote:
> "ALTER ROUTINE" and "DROP ROUTINE" are not listed in the "Event Trigger
> Firing Matrix" documentation page, even though these tags seem supported
> from PostgreSQL 11 onwards.
> 
> It would be really useful to mention them, since alterations and deletions
> of functions and procedures through ALTER ROUTINE and DROP ROUTINE commands
> won't be caught by a trigger firing only on "ALTER PROCEDURE" and "ALTER
> FUNCTION" tags (respectively "DROP PROCEDURE" and "DROP FUNCTION" tags).

Thanks for the report.  Indeed, the table is missing that ALTER
ROUTINE would fire the events ddl_command_start and ddl_command_end.
DROP ROUTINE fires on sql_drop, ddl_command_start and
ddl_command_end.  I have applied a patch to add this information
to the docs down to 11.

Regards,
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox