pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feed[PATCH] doc/queries.sgml: add missing comma
8+ messages / 6 participants
[nested] [flat]
* [PATCH] doc/queries.sgml: add missing comma
@ 2021-10-18 09:17 Drew DeVault <sir@cmpwn.com>
0 siblings, 1 reply; 8+ messages in thread
From: Drew DeVault @ 2021-10-18 09:17 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: Drew DeVault <sir@cmpwn.com>
Minor grammatical fix.
---
doc/src/sgml/queries.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/queries.sgml b/doc/src/sgml/queries.sgml
index 516fbcbf37..0f3d9ce7f8 100644
--- a/doc/src/sgml/queries.sgml
+++ b/doc/src/sgml/queries.sgml
@@ -2172,7 +2172,7 @@ SELECT sum(n) FROM t;
<note>
<para>
- Strictly speaking, this process is iteration not recursion, but
+ Strictly speaking, this process is iteration, not recursion, but
<literal>RECURSIVE</literal> is the terminology chosen by the SQL standards
committee.
</para>
--
2.33.1
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [PATCH] doc/queries.sgml: add missing comma
@ 2021-10-19 21:33 Tom Lane <tgl@sss.pgh.pa.us>
parent: Drew DeVault <sir@cmpwn.com>
0 siblings, 1 reply; 8+ messages in thread
From: Tom Lane @ 2021-10-19 21:33 UTC (permalink / raw)
To: Drew DeVault <sir@cmpwn.com>; +Cc: pgsql-docs@lists.postgresql.org
Drew DeVault <sir@cmpwn.com> writes:
> Minor grammatical fix.
Hmm, I'm not sure that reads any better than before.
> <para>
> - Strictly speaking, this process is iteration not recursion, but
> + Strictly speaking, this process is iteration, not recursion, but
> <literal>RECURSIVE</literal> is the terminology chosen by the SQL standards
... although I think this text is mine, so naturally I'd think
that. Anyone else have an opinion?
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [PATCH] doc/queries.sgml: add missing comma
@ 2021-10-20 01:41 David G. Johnston <david.g.johnston@gmail.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 8+ messages in thread
From: David G. Johnston @ 2021-10-20 01:41 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Drew DeVault <sir@cmpwn.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Tue, Oct 19, 2021 at 2:33 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Drew DeVault <sir@cmpwn.com> writes:
> > Minor grammatical fix.
>
> Hmm, I'm not sure that reads any better than before.
>
> > <para>
> > - Strictly speaking, this process is iteration not recursion, but
> > + Strictly speaking, this process is iteration, not recursion, but
> > <literal>RECURSIVE</literal> is the terminology chosen by the SQL
> standards
>
> ... although I think this text is mine, so naturally I'd think
> that. Anyone else have an opinion?
>
>
If I read that aloud to myself there is a comma after iteration.
That said, given that a comma and a "but" later we use the word "RECURSIVE"
the clarification that the process isn't recursion seems redundant. If one
knows what it means to be "recursive" then they will understand the
juxtaposition of "iteration" and "recursive" just fine. If they do not, I
don't think adding the word "recursion" is going to make much difference.
Thus:
Strictly speaking, this process is iteration, but
<literal>RECURSIVE</literal> is the terminology chosen by the SQL standards
committee."
Because the above sounds just fine, I'd argue that if one does leave "not
recursion" it should be set off by a comma.
David J.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [PATCH] doc/queries.sgml: add missing comma
@ 2021-10-20 03:51 Michael Paquier <michael@paquier.xyz>
parent: David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 0 replies; 8+ messages in thread
From: Michael Paquier @ 2021-10-20 03:51 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Drew DeVault <sir@cmpwn.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Tue, Oct 19, 2021 at 06:41:54PM -0700, David G. Johnston wrote:
> On Tue, Oct 19, 2021 at 2:33 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> ... although I think this text is mine, so naturally I'd think
>> that. Anyone else have an opinion?
>
> If I read that aloud to myself there is a comma after iteration.
Agreed, adding a comma feels more natural. Non-native speaker here,
however.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../YW+SQ6qQfjYAS9QP@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [PATCH] doc/queries.sgml: add missing comma
@ 2022-08-18 18:10 Bruce Momjian <bruce@momjian.us>
parent: David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 8+ messages in thread
From: Bruce Momjian @ 2022-08-18 18:10 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Drew DeVault <sir@cmpwn.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Tue, Oct 19, 2021 at 06:41:54PM -0700, David G. Johnston wrote:
> On Tue, Oct 19, 2021 at 2:33 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Drew DeVault <sir@cmpwn.com> writes:
> > Minor grammatical fix.
>
> Hmm, I'm not sure that reads any better than before.
>
> > <para>
> > - Strictly speaking, this process is iteration not recursion, but
> > + Strictly speaking, this process is iteration, not recursion, but
> > <literal>RECURSIVE</literal> is the terminology chosen by the SQL
> standards
>
> ... although I think this text is mine, so naturally I'd think
> that. Anyone else have an opinion?
>
>
>
> If I read that aloud to myself there is a comma after iteration.
>
> That said, given that a comma and a "but" later we use the word "RECURSIVE" the
> clarification that the process isn't recursion seems redundant. If one knows
> what it means to be "recursive" then they will understand the juxtaposition of
> "iteration" and "recursive" just fine. If they do not, I don't think adding
> the word "recursion" is going to make much difference.
>
> Thus:
> Strictly speaking, this process is iteration, but <literal>RECURSIVE</literal>
> is the terminology chosen by the SQL standards committee."
>
> Because the above sounds just fine, I'd argue that if one does leave "not
> recursion" it should be set off by a comma.
I went with new wording, which should make this even clearer; patch
attached.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
Attachments:
[text/x-diff] recursion.diff (481B, ../../Yv6AqJuvnP3HelUP@momjian.us/2-recursion.diff)
download | inline diff:
diff --git a/doc/src/sgml/queries.sgml b/doc/src/sgml/queries.sgml
index 516fbcbf37..51b752709e 100644
--- a/doc/src/sgml/queries.sgml
+++ b/doc/src/sgml/queries.sgml
@@ -2172,7 +2172,7 @@ SELECT sum(n) FROM t;
<note>
<para>
- Strictly speaking, this process is iteration not recursion, but
+ Strictly speaking, this process is iterative, not recursive, but
<literal>RECURSIVE</literal> is the terminology chosen by the SQL standards
committee.
</para>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [PATCH] doc/queries.sgml: add missing comma
@ 2022-08-24 17:58 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 8+ messages in thread
From: Peter Eisentraut @ 2022-08-24 17:58 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; David G. Johnston <david.g.johnston@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Drew DeVault <sir@cmpwn.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
On 18.08.22 20:10, Bruce Momjian wrote:
>> Thus:
>> Strictly speaking, this process is iteration, but <literal>RECURSIVE</literal>
>> is the terminology chosen by the SQL standards committee."
>>
>> Because the above sounds just fine, I'd argue that if one does leave "not
>> recursion" it should be set off by a comma.
> I went with new wording, which should make this even clearer; patch
> attached.
I think this whole note is a bit misleading, like the SQL people don't
know what recursion is. The point is that the query is defined
recursively. The evaluation process is iterative. Those two are not
contradictions.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [PATCH] doc/queries.sgml: add missing comma
@ 2022-08-30 18:18 Bruce Momjian <bruce@momjian.us>
parent: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Momjian @ 2022-08-30 18:18 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; Drew DeVault <sir@cmpwn.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Wed, Aug 24, 2022 at 07:58:04PM +0200, Peter Eisentraut wrote:
> On 18.08.22 20:10, Bruce Momjian wrote:
> > > Thus:
> > > Strictly speaking, this process is iteration, but <literal>RECURSIVE</literal>
> > > is the terminology chosen by the SQL standards committee."
> > >
> > > Because the above sounds just fine, I'd argue that if one does leave "not
> > > recursion" it should be set off by a comma.
> > I went with new wording, which should make this even clearer; patch
> > attached.
>
> I think this whole note is a bit misleading, like the SQL people don't know
> what recursion is. The point is that the query is defined recursively. The
> evaluation process is iterative. Those two are not contradictions.
Okay, makes sense. Here is an updated patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
Attachments:
[text/x-diff] recursion.diff (563B, ../../Yw5UgsYGPGYsXsaW@momjian.us/2-recursion.diff)
download | inline diff:
diff --git a/doc/src/sgml/queries.sgml b/doc/src/sgml/queries.sgml
index 1428d99d0f..4c5a83c9cb 100644
--- a/doc/src/sgml/queries.sgml
+++ b/doc/src/sgml/queries.sgml
@@ -2172,9 +2172,8 @@ SELECT sum(n) FROM t;
<note>
<para>
- Strictly speaking, this process is iteration not recursion, but
- <literal>RECURSIVE</literal> is the terminology chosen by the SQL standards
- committee.
+ While <literal>RECURSIVE</literal> allows queries to be specified
+ recursively, internally all queries are evaluated iteratively.
</para>
</note>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [PATCH] doc/queries.sgml: add missing comma
@ 2022-09-03 01:58 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 8+ messages in thread
From: Bruce Momjian @ 2022-09-03 01:58 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; Drew DeVault <sir@cmpwn.com>; Pg Docs <pgsql-docs@lists.postgresql.org>
On Tue, Aug 30, 2022 at 02:18:42PM -0400, Bruce Momjian wrote:
> On Wed, Aug 24, 2022 at 07:58:04PM +0200, Peter Eisentraut wrote:
> > On 18.08.22 20:10, Bruce Momjian wrote:
> > > > Thus:
> > > > Strictly speaking, this process is iteration, but <literal>RECURSIVE</literal>
> > > > is the terminology chosen by the SQL standards committee."
> > > >
> > > > Because the above sounds just fine, I'd argue that if one does leave "not
> > > > recursion" it should be set off by a comma.
> > > I went with new wording, which should make this even clearer; patch
> > > attached.
> >
> > I think this whole note is a bit misleading, like the SQL people don't know
> > what recursion is. The point is that the query is defined recursively. The
> > evaluation process is iterative. Those two are not contradictions.
>
> Okay, makes sense. Here is an updated patch.
Patch applied back to PG 10.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2022-09-03 01:58 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 09:17 [PATCH] doc/queries.sgml: add missing comma Drew DeVault <sir@cmpwn.com>
2021-10-19 21:33 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-10-20 01:41 ` David G. Johnston <david.g.johnston@gmail.com>
2021-10-20 03:51 ` Michael Paquier <michael@paquier.xyz>
2022-08-18 18:10 ` Bruce Momjian <bruce@momjian.us>
2022-08-24 17:58 ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
2022-08-30 18:18 ` Bruce Momjian <bruce@momjian.us>
2022-09-03 01:58 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox