From: Bruce Momjian <bruce@momjian.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: mark.a.sloan@gmail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: pg_upgrade doc uses inconsistent versions within the doc.
Date: Tue, 26 Sep 2023 16:26:05 -0400
Message-ID: <ZRM+XeYQYZFIKDSn@momjian.us> (raw)
In-Reply-To: <CAKFQuwZhjKW=wny8h+dh+EtctjAekjfA20qBroZ9Y_1Sbp_u2w@mail.gmail.com>
References: <169506804412.3727336.8571753495127355296@wrigleys.postgresql.org>
<ZRMWQCnV1lCAV7ES@momjian.us>
<CAKFQuwZhjKW=wny8h+dh+EtctjAekjfA20qBroZ9Y_1Sbp_u2w@mail.gmail.com>
On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote:
> On Tue, Sep 26, 2023 at 10:35 AM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Mon, Sep 18, 2023 at 08:14:04PM +0000, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/16/pgupgrade.html
> > Description:
> >
> > I feel like for readability the pg_upgrade doc should use the same
> > old_version and new_version examples when showing examples throughout the
> > doc page.
> >
> > as an exmaple I'm looking at :
> > https://www.postgresql.org/docs/current/pgupgrade.html
> >
> > in some places the example commands use v9.6 and v16. (see step 8)
> >
> > but in other places it mixes versions v9.5 and v9.6 (see step 11 sub step
> 8)
>
> Good point. I came up with the attached patch. It uses 9.6 and current
>
>
> I would get rid of any mentions of our old pre-v10 versioning scheme in the
> current documentation.
Good point, how is this attached patch?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
[text/x-diff] upgrade_version.diff (3.1K, ../ZRM+XeYQYZFIKDSn@momjian.us/2-upgrade_version.diff)
download | inline diff:diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgmlindex bea0d1b93f..5dd2c446f7 100644--- a/doc/src/sgml/ref/pgupgrade.sgml+++ b/doc/src/sgml/ref/pgupgrade.sgml@@ -40,9 +40,9 @@ PostgreSQL documentation
<application>pg_upgrade</application> (formerly called <application>pg_migrator</application>) allows data
stored in <productname>PostgreSQL</productname> data files to be upgraded to a later <productname>PostgreSQL</productname>
major version without the data dump/restore typically required for
- major version upgrades, e.g., from 9.5.8 to 9.6.4 or from 10.7 to 11.2.- It is not required for minor version upgrades, e.g., from 9.6.2 to 9.6.3- or from 10.1 to 10.2.+ major version upgrades, e.g., from 12.14 to 13.10 or from 14.9 to 15.5.+ It is not required for minor version upgrades, e.g., from 12.7 to 12.8+ or from 14.1 to 14.5.
</para>
<para>
@@ -390,14 +390,14 @@ make prefix=/usr/local/pgsql.new install
Make sure both database servers are stopped using, on Unix, e.g.:
<programlisting>
-pg_ctl -D /opt/PostgreSQL/9.6 stop+pg_ctl -D /opt/PostgreSQL/12 stop
pg_ctl -D /opt/PostgreSQL/&majorversion; stop
</programlisting>
or on Windows, using the proper service names:
<programlisting>
-NET STOP postgresql-9.6+NET STOP postgresql-12
NET STOP postgresql-&majorversion;
</programlisting>
</para>
@@ -473,9 +473,9 @@ SET PATH=%PATH%;C:\Program Files\PostgreSQL\&majorversion;\bin;
<programlisting>
pg_upgrade.exe
- --old-datadir "C:/Program Files/PostgreSQL/9.6/data"+ --old-datadir "C:/Program Files/PostgreSQL/12/data"
--new-datadir "C:/Program Files/PostgreSQL/&majorversion;/data"
- --old-bindir "C:/Program Files/PostgreSQL/9.6/bin"+ --old-bindir "C:/Program Files/PostgreSQL/12/bin"
--new-bindir "C:/Program Files/PostgreSQL/&majorversion;/bin"
</programlisting>
@@ -605,8 +605,8 @@ rsync --archive --delete --hard-links --size-only --no-inc-recursive old_cluster
remote directory, e.g.,
<programlisting>
-rsync --archive --delete --hard-links --size-only --no-inc-recursive /opt/PostgreSQL/9.5 \- /opt/PostgreSQL/9.6 standby.example.com:/opt/PostgreSQL+rsync --archive --delete --hard-links --size-only --no-inc-recursive /opt/PostgreSQL/12 \+ /opt/PostgreSQL/&majorversion; standby.example.com:/opt/PostgreSQL
</programlisting>
You can verify what the command will do using
@@ -635,8 +635,8 @@ rsync --archive --delete --hard-links --size-only --no-inc-recursive /opt/Postgr
<application>rsync</application> command for each tablespace directory, e.g.:
<programlisting>
-rsync --archive --delete --hard-links --size-only --no-inc-recursive /vol1/pg_tblsp/PG_9.5_201510051 \- /vol1/pg_tblsp/PG_9.6_201608131 standby.example.com:/vol1/pg_tblsp+rsync --archive --delete --hard-links --size-only --no-inc-recursive /vol1/pg_tblsp/PG_12_201909212 \+ /vol1/pg_tblsp/PG_&majorversion;_202307071 standby.example.com:/vol1/pg_tblsp
</programlisting>
If you have relocated <filename>pg_wal</filename> outside the data
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, david.g.johnston@gmail.com, mark.a.sloan@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: pg_upgrade doc uses inconsistent versions within the doc.
In-Reply-To: <ZRM+XeYQYZFIKDSn@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox