From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: suchithjn22@gmail.com, PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: The documentation for storage type 'plain' actually allows single byte header
Date: Tue, 31 Oct 2023 09:10:56 -0400
Message-ID: <ZUD84FfPPWv2A-ip@momjian.us> (raw)
In-Reply-To: <ZTSB6JcPcpta3AGc@momjian.us>
References: <167336599095.2667301.15497893107226841625@wrigleys.postgresql.org>
<d99b3e0beebdde0741d28035aaea7f4af56fa050.camel@cybertec.at>
<ZRdNjrI6lUQbD90Y@momjian.us>
<4977c12e127250fe9777ae57f6f5884b8f5c84ae.camel@cybertec.at>
<1421365.1696027552@sss.pgh.pa.us>
<ZTMt1XxPmZekFXBL@momjian.us>
<ZTSBPankJQ9_kfXF@momjian.us>
<ZTSB6JcPcpta3AGc@momjian.us>
On Sat, Oct 21, 2023 at 09:59:04PM -0400, Bruce Momjian wrote:
> On Sat, Oct 21, 2023 at 09:56:13PM -0400, Bruce Momjian wrote:
> > I did some more research. It turns out that the source slot/planSlot is
> > populating its pg_attribute information via makeTargetEntry() and it
> > has no concept of a storage type.
> >
> > Digging further, I found that we cannot get rid of the the use of
> > att->attstorage != TYPSTORAGE_PLAIN in macros ATT_IS_PACKABLE and
> > VARLENA_ATT_IS_PACKABLE macros in src/backend/access/common/heaptuple.c
> > because there are internal uses of fill_val() that can't handle packed
> > varlena headers.
> >
> > I ended up with a doc patch that adds a C comment about this odd
> > behavior and removes doc text about PLAIN storage not using packed
> > headers.
>
> Oops, patch attached.
Patch applied to all supported versions.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, pgsql-hackers@postgresql.org
Subject: Re: The documentation for storage type 'plain' actually allows single byte header
In-Reply-To: <ZUD84FfPPWv2A-ip@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox