pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedFix sequence membership command in PG19 release notes
7+ messages / 4 participants
[nested] [flat]
Commits from this thread:
2026-10-27 6add85f412 doc PG 19 relnotes: improve some "enable" wording
2026-10-27 3cca684cec doc PG 19 relnotes: mention when ALTER SUBSCRIPTION affects item
* Fix sequence membership command in PG19 release notes
@ 2026-10-16 11:33 rh@vonng.com
2026-10-22 15:58 ` Re: Fix sequence membership command in PG19 release notes vignesh C <vignesh21@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: rh@vonng.com @ 2026-10-16 11:33 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
The PG19 release-note entry about synchronizing sequence membership [1]
attributes that operation to REFRESH SEQUENCES. It should refer to
REFRESH PUBLICATION.
REFRESH PUBLICATION adds and removes sequence entries in
pg_subscription_rel. REFRESH SEQUENCES instead resets existing sequence
entries to INIT for value resynchronization, without changing which
sequences are subscribed.
This matches the ALTER SUBSCRIPTION reference [2] and the documentation
clarification committed as 19fbb47ef685 [3]. That commit did not update
release-19.sgml.
The attached one-line patch changes the command name in that sentence.
It is based on REL_19_STABLE at a66ab9a9d382 and passes git apply --check.
Regards,
Ruohang Feng
Vonng@PGSTY
[1] https://www.postgresql.org/docs/19/release-19.html#RELEASE-19-LOGICAL
[2] https://www.postgresql.org/docs/19/sql-altersubscription.html#SQL-ALTERSUBSCRIPTION-PARAMS-REFRESH-S...
[3] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=19fbb47ef6854b1e3a7311ed2f4e765426e7a...
Attachments:
doc-fix-sequence-membership-command.patch (application/octet-stream, 391B) download
diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml
index d80582a8ddf3..e102b4300814 100644
--- a/doc/src/sgml/release-19.sgml
+++ b/doc/src/sgml/release-19.sgml
@@ -1564,7 +1564,7 @@
</para>
<para>
-This is enabled with the <literal>REFRESH SEQUENCES</literal> clause.
+This is enabled with the <literal>REFRESH PUBLICATION</literal> clause.
</para>
</listitem>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Fix sequence membership command in PG19 release notes
2026-10-16 11:33 Fix sequence membership command in PG19 release notes rh@vonng.com
@ 2026-10-22 15:58 ` vignesh C <vignesh21@gmail.com>
2026-10-27 03:17 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 7+ messages in thread
From: vignesh C @ 2026-10-22 15:58 UTC (permalink / raw)
To: rh@vonng.com; +Cc: pgsql-docs@lists.postgresql.org
On Fri, 16 Oct 2026 at 17:03, <rh@vonng.com> wrote:
>
> The PG19 release-note entry about synchronizing sequence membership [1]
> attributes that operation to REFRESH SEQUENCES. It should refer to
> REFRESH PUBLICATION.
>
> REFRESH PUBLICATION adds and removes sequence entries in
> pg_subscription_rel. REFRESH SEQUENCES instead resets existing sequence
> entries to INIT for value resynchronization, without changing which
> sequences are subscribed.
>
> This matches the ALTER SUBSCRIPTION reference [2] and the documentation
> clarification committed as 19fbb47ef685 [3]. That commit did not update
> release-19.sgml.
>
> The attached one-line patch changes the command name in that sentence.
> It is based on REL_19_STABLE at a66ab9a9d382 and passes git apply --check.
Thanks for the patch, one suggestion, how about we mention something like:
This is done by REFRESH PUBLICATION and by ADD PUBLICATION, DROP
PUBLICATION, and SET PUBLICATION, which add newly published sequences
to the subscription and remove dropped ones. REFRESH SEQUENCES does
not change which sequences are subscribed.
Regards,
Vignesh
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Fix sequence membership command in PG19 release notes
2026-10-16 11:33 Fix sequence membership command in PG19 release notes rh@vonng.com
2026-10-22 15:58 ` Re: Fix sequence membership command in PG19 release notes vignesh C <vignesh21@gmail.com>
@ 2026-10-27 03:17 ` Bruce Momjian <bruce@momjian.us>
2026-10-27 04:25 ` Re: Fix sequence membership command in PG19 release notes Peter Smith <smithpb2250@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Bruce Momjian @ 2026-10-27 03:17 UTC (permalink / raw)
To: vignesh C <vignesh21@gmail.com>; +Cc: rh@vonng.com; pgsql-docs@lists.postgresql.org
On Thu, Oct 22, 2026 at 09:28:31PM +0530, vignesh C wrote:
> On Fri, 16 Oct 2026 at 17:03, <rh@vonng.com> wrote:
> >
> > The PG19 release-note entry about synchronizing sequence membership [1]
> > attributes that operation to REFRESH SEQUENCES. It should refer to
> > REFRESH PUBLICATION.
> >
> > REFRESH PUBLICATION adds and removes sequence entries in
> > pg_subscription_rel. REFRESH SEQUENCES instead resets existing sequence
> > entries to INIT for value resynchronization, without changing which
> > sequences are subscribed.
> >
> > This matches the ALTER SUBSCRIPTION reference [2] and the documentation
> > clarification committed as 19fbb47ef685 [3]. That commit did not update
> > release-19.sgml.
> >
> > The attached one-line patch changes the command name in that sentence.
> > It is based on REL_19_STABLE at a66ab9a9d382 and passes git apply --check.
>
> Thanks for the patch, one suggestion, how about we mention something like:
> This is done by REFRESH PUBLICATION and by ADD PUBLICATION, DROP
> PUBLICATION, and SET PUBLICATION, which add newly published sequences
> to the subscription and remove dropped ones. REFRESH SEQUENCES does
> not change which sequences are subscribed.
Okay, I have applied the attached patch based on your instructions. Let
me know if I need to change anything.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
Attachments:
REL_19_STABLE.diff (text/x-diff, 1.1K) download
diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml
index 7d723995575..12704e568b1 100644
--- a/doc/src/sgml/release-19.sgml
+++ b/doc/src/sgml/release-19.sgml
@@ -1542,8 +1542,7 @@ Allow sequence values stored in subscribers to match the publisher (Vignesh C)
</para>
<para>
-This is enabled during <link linkend="sql-createsubscription"><command>CREATE SUBSCRIPTION</command></link>, <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... REFRESH PUBLICATION</command></link>, and <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... REFRESH SEQUENCES</command></link>. The latter only updates values, not sequence
-existence. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
+This is enabled during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
</para>
</listitem>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Fix sequence membership command in PG19 release notes
2026-10-16 11:33 Fix sequence membership command in PG19 release notes rh@vonng.com
2026-10-22 15:58 ` Re: Fix sequence membership command in PG19 release notes vignesh C <vignesh21@gmail.com>
2026-10-27 03:17 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
@ 2026-10-27 04:25 ` Peter Smith <smithpb2250@gmail.com>
2026-10-27 21:47 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Smith @ 2026-10-27 04:25 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: vignesh C <vignesh21@gmail.com>; rh@vonng.com; pgsql-docs@lists.postgresql.org
On Tue, Oct 27, 2026 at 2:17 PM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Thu, Oct 22, 2026 at 09:28:31PM +0530, vignesh C wrote:
> > On Fri, 16 Oct 2026 at 17:03, <rh@vonng.com> wrote:
> > >
> > > The PG19 release-note entry about synchronizing sequence membership [1]
> > > attributes that operation to REFRESH SEQUENCES. It should refer to
> > > REFRESH PUBLICATION.
> > >
> > > REFRESH PUBLICATION adds and removes sequence entries in
> > > pg_subscription_rel. REFRESH SEQUENCES instead resets existing sequence
> > > entries to INIT for value resynchronization, without changing which
> > > sequences are subscribed.
> > >
> > > This matches the ALTER SUBSCRIPTION reference [2] and the documentation
> > > clarification committed as 19fbb47ef685 [3]. That commit did not update
> > > release-19.sgml.
> > >
> > > The attached one-line patch changes the command name in that sentence.
> > > It is based on REL_19_STABLE at a66ab9a9d382 and passes git apply --check.
> >
> > Thanks for the patch, one suggestion, how about we mention something like:
> > This is done by REFRESH PUBLICATION and by ADD PUBLICATION, DROP
> > PUBLICATION, and SET PUBLICATION, which add newly published sequences
> > to the subscription and remove dropped ones. REFRESH SEQUENCES does
> > not change which sequences are subscribed.
>
> Okay, I have applied the attached patch based on your instructions. Let
> me know if I need to change anything.
>
Hi.
I just saw this change.
Personally, I find all those "This is enabled" bullets in this Logical
Replication section to be potentially misleading because SUBSCRIPTION
"enabled" or "disabled" [1] is an entirely different and unrelated
concept to the sequence support.
IMO all those points might be better expressed like
"This occurs during ....", or
"This happens when ...."
"This is achieved by ..." or
etc.
e.g. choose anything that avoids the word "enabled"
------
Allow sequence values stored in subscribers to match the publisher
(Vignesh C) § § §
* This is enabled during CREATE SUBSCRIPTION, ALTER SUBSCRIPTION ...
REFRESH PUBLICATION, and ALTER SUBSCRIPTION ... REFRESH SEQUENCES. The
latter only updates values, not sequence existence. Function
pg_get_sequence_data() allows inspection of sequence synchronization.
Allow CREATE/ALTER PUBLICATION to publish all sequences (Vignesh C,
Tomas Vondra) §
* This is enabled with the ALL SEQUENCES clause.
Allow ALTER SUBSCRIPTION on publications to synchronize the existence
of sequences on subscribers to match the publisher (Vignesh C) §
* This is enabled with the REFRESH SEQUENCES clause.
------
======
[1] https://www.postgresql.org/docs/current/sql-createsubscription.html#SQL-CREATESUBSCRIPTION-PARAMS-WI...
Kind Regards,
Peter Smith.
Fujitsu Australia
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Fix sequence membership command in PG19 release notes
2026-10-16 11:33 Fix sequence membership command in PG19 release notes rh@vonng.com
2026-10-22 15:58 ` Re: Fix sequence membership command in PG19 release notes vignesh C <vignesh21@gmail.com>
2026-10-27 03:17 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
2026-10-27 04:25 ` Re: Fix sequence membership command in PG19 release notes Peter Smith <smithpb2250@gmail.com>
@ 2026-10-27 21:47 ` Bruce Momjian <bruce@momjian.us>
2026-10-27 22:30 ` Re: Fix sequence membership command in PG19 release notes Peter Smith <smithpb2250@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Bruce Momjian @ 2026-10-27 21:47 UTC (permalink / raw)
To: Peter Smith <smithpb2250@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; rh@vonng.com; pgsql-docs@lists.postgresql.org
On Tue, Oct 27, 2026 at 03:25:31PM +1100, Peter Smith wrote:
> I just saw this change.
>
> Personally, I find all those "This is enabled" bullets in this Logical
> Replication section to be potentially misleading because SUBSCRIPTION
> "enabled" or "disabled" [1] is an entirely different and unrelated
> concept to the sequence support.
>
> IMO all those points might be better expressed like
>
> "This occurs during ....", or
> "This happens when ...."
> "This is achieved by ..." or
> etc.
>
> e.g. choose anything that avoids the word "enabled"
I adjusted two places where "enable" was not the right word; applied
patch attached.
For these two sentences that you mentioned:
* This is enabled with the ALL SEQUENCES clause.
* This is enabled with the REFRESH SEQUENCES clause.
I realize "enabled" could be an overused concept in this text, but using
something like:
This occurs during the ALL SEQUENCES clause.
This happens when the ALL SEQUENCES clause.
This is achieved by the ALL SEQUENCES clause.
seem much less clear than the existing text.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
Attachments:
REL_19_STABLE.diff (text/x-diff, 1.2K) download
diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml
index 094668ff953..275d727ceb4 100644
--- a/doc/src/sgml/release-19.sgml
+++ b/doc/src/sgml/release-19.sgml
@@ -599,7 +599,7 @@ Author: Tom Lane <tgl@sss.pgh.pa.us>
<listitem>
<para>
-Enable proper optimizer statistics for functions returning boolean values (Tom Lane)
+Add proper optimizer statistics for functions returning boolean values (Tom Lane)
<ulink url="&commit_baseurl;1eccb9315">§</ulink>
</para>
</listitem>
@@ -1570,7 +1570,7 @@ Allow sequence values stored in subscribers to match the publisher (Vignesh C)
</para>
<para>
-This is enabled during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
+This occurs during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
</para>
</listitem>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Fix sequence membership command in PG19 release notes
2026-10-16 11:33 Fix sequence membership command in PG19 release notes rh@vonng.com
2026-10-22 15:58 ` Re: Fix sequence membership command in PG19 release notes vignesh C <vignesh21@gmail.com>
2026-10-27 03:17 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
2026-10-27 04:25 ` Re: Fix sequence membership command in PG19 release notes Peter Smith <smithpb2250@gmail.com>
2026-10-27 21:47 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
@ 2026-10-27 22:30 ` Peter Smith <smithpb2250@gmail.com>
2026-10-27 22:33 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Smith @ 2026-10-27 22:30 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: vignesh C <vignesh21@gmail.com>; rh@vonng.com; pgsql-docs@lists.postgresql.org
On Wed, Oct 28, 2026 at 8:47 AM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Tue, Oct 27, 2026 at 03:25:31PM +1100, Peter Smith wrote:
> > I just saw this change.
> >
> > Personally, I find all those "This is enabled" bullets in this Logical
> > Replication section to be potentially misleading because SUBSCRIPTION
> > "enabled" or "disabled" [1] is an entirely different and unrelated
> > concept to the sequence support.
> >
> > IMO all those points might be better expressed like
> >
> > "This occurs during ....", or
> > "This happens when ...."
> > "This is achieved by ..." or
> > etc.
> >
> > e.g. choose anything that avoids the word "enabled"
>
> I adjusted two places where "enable" was not the right word; applied
> patch attached.
>
> For these two sentences that you mentioned:
>
> * This is enabled with the ALL SEQUENCES clause.
> * This is enabled with the REFRESH SEQUENCES clause.
>
> I realize "enabled" could be an overused concept in this text, but using
> something like:
>
> This occurs during the ALL SEQUENCES clause.
> This happens when the ALL SEQUENCES clause.
> This is achieved by the ALL SEQUENCES clause.
>
> seem much less clear than the existing text.
Oh, I didn't mean for those suggestions to be taken literally. The
ellipsis "..." and "etc." were supposed to mean -- choose any
replacement wording you want that avoids saying "enabled".
e.g.
This is done using the ALL SEQUENCES clause.
This is done using the REFRESH SEQUENCES clause.
(or whatever)
======
Kind Regards,
Peter Smith.
Fujitsu Australia
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Fix sequence membership command in PG19 release notes
2026-10-16 11:33 Fix sequence membership command in PG19 release notes rh@vonng.com
2026-10-22 15:58 ` Re: Fix sequence membership command in PG19 release notes vignesh C <vignesh21@gmail.com>
2026-10-27 03:17 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
2026-10-27 04:25 ` Re: Fix sequence membership command in PG19 release notes Peter Smith <smithpb2250@gmail.com>
2026-10-27 21:47 ` Re: Fix sequence membership command in PG19 release notes Bruce Momjian <bruce@momjian.us>
2026-10-27 22:30 ` Re: Fix sequence membership command in PG19 release notes Peter Smith <smithpb2250@gmail.com>
@ 2026-10-27 22:33 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 7+ messages in thread
From: Bruce Momjian @ 2026-10-27 22:33 UTC (permalink / raw)
To: Peter Smith <smithpb2250@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; rh@vonng.com; pgsql-docs@lists.postgresql.org
On Wed, Oct 28, 2026 at 09:30:12AM +1100, Peter Smith wrote:
> > I realize "enabled" could be an overused concept in this text, but using
> > something like:
> >
> > This occurs during the ALL SEQUENCES clause.
> > This happens when the ALL SEQUENCES clause.
> > This is achieved by the ALL SEQUENCES clause.
> >
> > seem much less clear than the existing text.
>
> Oh, I didn't mean for those suggestions to be taken literally. The
> ellipsis "..." and "etc." were supposed to mean -- choose any
> replacement wording you want that avoids saying "enabled".
>
> e.g.
> This is done using the ALL SEQUENCES clause.
> This is done using the REFRESH SEQUENCES clause.
Uh, "This is done" seems very imprecise. Even "This is accomplished"
seems worse.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-10-27 22:33 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-10-16 11:33 Fix sequence membership command in PG19 release notes rh@vonng.com
2026-10-22 15:58 ` vignesh C <vignesh21@gmail.com>
2026-10-27 03:17 ` Bruce Momjian <bruce@momjian.us>
2026-10-27 04:25 ` Peter Smith <smithpb2250@gmail.com>
2026-10-27 21:47 ` Bruce Momjian <bruce@momjian.us>
2026-10-27 22:30 ` Peter Smith <smithpb2250@gmail.com>
2026-10-27 22:33 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox