pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Peter Smith <smithpb2250@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: rh@vonng.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Fix sequence membership command in PG19 release notes
Date: Tue, 27 Oct 2026 17:47:25 -0400
Message-ID: <auEb7WwTL58dnSU2@momjian.us> (raw)
In-Reply-To: <CAHut+Ptos+tgMUJyEMUboYss+qN2_PPwjDNAwOcHf1n72J2BQQ@mail.gmail.com>
References: <BF65B113-46A1-40F4-A4B0-76E90EFD7F00@vonng.com>
	<CALDaNm1agomELtDDqdF4KnAp6s6nKBMjU7VpmKQGh_o69XQTkg@mail.gmail.com>
	<auAXuMcMFgcF2aTc@momjian.us>
	<CAHut+Ptos+tgMUJyEMUboYss+qN2_PPwjDNAwOcHf1n72J2BQQ@mail.gmail.com>

On Tue, Oct 27, 2026 at 03:25:31PM +1100, Peter Smith wrote:
> I just saw this change.
> 
> Personally, I find all those "This is enabled" bullets in this Logical
> Replication section to be potentially misleading because SUBSCRIPTION
> "enabled" or "disabled" [1] is an entirely different and unrelated
> concept to the sequence support.
> 
> IMO all those points might be better expressed like
> 
> "This occurs during ....", or
> "This happens when ...."
> "This is achieved by ..." or
> etc.
> 
> e.g. choose anything that avoids the word "enabled"

I adjusted two places where "enable" was not the right word;  applied
patch attached.

For these two sentences that you mentioned:

	* This is enabled with the ALL SEQUENCES clause.
	* This is enabled with the REFRESH SEQUENCES clause.

I realize "enabled" could be an overused concept in this text, but using
something like:

	This occurs during the ALL SEQUENCES clause.
	This happens when the ALL SEQUENCES clause.
	This is achieved by the ALL SEQUENCES clause.

seem much less clear than the existing text.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

Attachments:

REL_19_STABLE.diff (text/x-diff, 1.2K) download diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml index 094668ff953..275d727ceb4 100644 --- a/doc/src/sgml/release-19.sgml +++ b/doc/src/sgml/release-19.sgml @@ -599,7 +599,7 @@ Author: Tom Lane <tgl@sss.pgh.pa.us> <listitem> <para> -Enable proper optimizer statistics for functions returning boolean values (Tom Lane) +Add proper optimizer statistics for functions returning boolean values (Tom Lane) <ulink url="&commit_baseurl;1eccb9315">&sect;</ulink> </para> </listitem> @@ -1570,7 +1570,7 @@ Allow sequence values stored in subscribers to match the publisher (Vignesh C) </para> <para> -This is enabled during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization. +This occurs during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization. </para> </listitem>

view thread (7+ messages)  latest in thread

Message-ID: <auEb7WwTL58dnSU2@momjian.us>
Permalink:  ../auEb7WwTL58dnSU2@momjian.us/
Also on:    postgresql.org/message-id/auEb7WwTL58dnSU2@momjian.us

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: bruce@momjian.us, smithpb2250@gmail.com, vignesh21@gmail.com, rh@vonng.com, pgsql-docs@lists.postgresql.org
  Subject: Re: Fix sequence membership command in PG19 release notes
  In-Reply-To: <auEb7WwTL58dnSU2@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox