pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Christophe Courtois <christophe.courtois@dalibo.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-docs@postgresql.org
Subject: Re: intagg.sgml: example wrongly named and does not compile
Date: Fri, 21 Apr 2017 18:07:13 +0200
Message-ID: <ba54d8fa-603f-c789-2bc4-e6e86b7b01b2@dalibo.com> (raw)
In-Reply-To: <15516.1492789516@sss.pgh.pa.us>
References: <aa7cfd73-0d8d-596a-b684-39faa479afa5@dalibo.com>
	<15516.1492789516@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>

Le 21/04/2017 à 17:45, Tom Lane a écrit :
> Christophe Courtois <christophe.courtois@dalibo.com> writes:
>> I've found out that the example in intagg.sgml is wrongly named: the
>> one-to-many table is a many-to-many.
> Well, it'd depend on how it was used.  The example clearly intends that
> it be one-to-many, and I'm not sure it still makes sense without that
> restriction.  Maybe better to add a unique constraint on
> one_to_many(left)?

Perhaps the whole example can be simplified to get rid of the "left"
table, but I didn't intend to rewrite it.

>> And my colleague Thibaut Madeleine has seen that the "CREATE TABLE
>> right" and "CREATE TABLE left" examples cannot compile due to the
>> reserved words.
> Ouch.  Shows you how old this module is :-(

Indeed.

>> I propose the attached patch to fix that.
> Um, the attached file seems empty from here.

Ooops, sorry. It is attached.




-- 
Christophe Courtois
Consultant Dalibo
http://dalibo.com/  -  http://dalibo.org/

-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

Attachments:

  [text/x-patch] intagg.sgml.patch (3.7K, ../ba54d8fa-603f-c789-2bc4-e6e86b7b01b2@dalibo.com/2-intagg.sgml.patch)
  download | inline diff:
--- intagg.sgml.HEAD	2016-11-17 09:41:53.173988630 +0100
+++ intagg.sgml	2017-04-21 16:29:10.421996579 +0200
@@ -54,20 +54,23 @@
   <title>Sample Uses</title>
 
   <para>
-   Many database systems have the notion of a one to many table. Such a table
+   Many database systems have the notion of a many to many table. Such a table
    usually sits between two indexed tables, for example:
 
 <programlisting>
-CREATE TABLE left (id INT PRIMARY KEY, ...);
-CREATE TABLE right (id INT PRIMARY KEY, ...);
-CREATE TABLE one_to_many(left INT REFERENCES left, right INT REFERENCES right);
+CREATE TABLE left_table  (id INT PRIMARY KEY, ...);
+CREATE TABLE right_table (id INT PRIMARY KEY, ...);
+CREATE TABLE many_to_many(id_left  INT REFERENCES left_table, 
+                          id_right INT REFERENCES right_table);
 </programlisting>
 
   It is typically used like this:
 
 <programlisting>
-SELECT right.* from right JOIN one_to_many ON (right.id = one_to_many.right)
-  WHERE one_to_many.left = <replaceable>item</>;
+SELECT right_table.* 
+FROM right_table 
+JOIN many_to_many ON (right_table.id = many_to_many.id_right)
+WHERE many_to_many.id_left = <replaceable>item</>;
 </programlisting>
 
   This will return all the items in the right hand table for an entry
@@ -76,7 +79,7 @@
 
  <para>
   Now, this methodology can be cumbersome with a very large number of
-  entries in the <structname>one_to_many</> table.  Often,
+  entries in the <structname>many_to_many</> table.  Often,
   a join like this would result in an index scan
   and a fetch for each right hand entry in the table for a particular
   left hand entry. If you have a very dynamic system, there is not much you
@@ -85,9 +88,9 @@
 
 <programlisting>
 CREATE TABLE summary AS
-  SELECT left, int_array_aggregate(right) AS right
-  FROM one_to_many
-  GROUP BY left;
+  SELECT id_left, int_array_aggregate(id_right) AS rights
+  FROM many_to_many
+  GROUP BY id_left;
 </programlisting>
 
   This will create a table with one row per left item, and an array
@@ -95,33 +98,35 @@
   the array; that's why there is an array enumerator.  You can do
 
 <programlisting>
-SELECT left, int_array_enum(right) FROM summary WHERE left = <replaceable>item</>;
+SELECT id_left, int_array_enum(rights) FROM summary WHERE id_left = <replaceable>item</>;
 </programlisting>
 
   The above query using <function>int_array_enum</> produces the same results
   as
 
 <programlisting>
-SELECT left, right FROM one_to_many WHERE left = <replaceable>item</>;
+SELECT id_left, id_right FROM many_to_many WHERE id_left = <replaceable>item</>;
 </programlisting>
 
   The difference is that the query against the summary table has to get
   only one row from the table, whereas the direct query against
-  <structname>one_to_many</> must index scan and fetch a row for each entry.
+  <structname>many_to_many</> must index scan and fetch a row for each entry.
  </para>
 
  <para>
   On one system, an <command>EXPLAIN</> showed a query with a cost of 8488 was
   reduced to a cost of 329.  The original query was a join involving the
-  <structname>one_to_many</> table, which was replaced by:
+  <structname>many_to_many</> table, which was replaced by:
 
 <programlisting>
-SELECT right, count(right) FROM
-  ( SELECT left, int_array_enum(right) AS right
-    FROM summary JOIN (SELECT left FROM left_table WHERE left = <replaceable>item</>) AS lefts
-         ON (summary.left = lefts.left)
+SELECT id_right, count(id_right) FROM
+  ( SELECT id_left, int_array_enum(rights) AS id_right
+    FROM summary 
+    JOIN (SELECT id FROM left_table 
+          WHERE id = <replaceable>item</>) AS lefts
+    ON (summary.id_left = lefts.id)
   ) AS list
-  GROUP BY right
+  GROUP BY id_right
   ORDER BY count DESC;
 </programlisting>
  </para>

view thread (6+ messages)  latest in thread

Message-ID: <ba54d8fa-603f-c789-2bc4-e6e86b7b01b2@dalibo.com>
Permalink:  ../ba54d8fa-603f-c789-2bc4-e6e86b7b01b2@dalibo.com/
Also on:    postgresql.org/message-id/ba54d8fa-603f-c789-2bc4-e6e86b7b01b2@dalibo.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: christophe.courtois@dalibo.com, tgl@sss.pgh.pa.us
  Subject: Re: intagg.sgml: example wrongly named and does not compile
  In-Reply-To: <ba54d8fa-603f-c789-2bc4-e6e86b7b01b2@dalibo.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox