pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alex <cdalxndr@yahoo.com>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Invalid idle_in_transaction_session_timeout data type
Date: Thu, 11 Mar 2021 12:23:29 +0000
Message-ID: <c0e06b0927222.cf42cafcd23b9@yahoo.com> (raw)
References: <11783b8644ae5.7f3aa1e3b18b4.ref@yahoo.com>
	<11783b8644ae5.7f3aa1e3b18b4@yahoo.com>
	<20210311.211047.1106690547580793701.t-ishii@gmail.com>

In my opinion, it would be more clear if "Numeric with Unit" would be 
specified on that property documentation, so that I can search more about 
what that means (eventually a link pointing to details).
I saw "(integer)" so I assumed `show idle_in_transaction_session_timeout ` 
will return an integer.
To actually deduce its format I should read much more documentation, and 
the average user usually fast searches and scans documents only for 
keywords.
Tatsuo Ishii wrote:
https://www.postgresql.org/docs/13/runtime-config-client.html 
<https://www.postgresql.org/docs/13/runtime-config-client.html; 
<https://www.postgresql.org/docs/13/runtime-config-client.html 
<https://www.postgresql.org/docs/13/runtime-config-client.html; > shows
that `idle_in_transaction_session_timeout` is integer, bug you can set
text values '30s' and `show idle_in_transaction_session_timeout`
returns `30s` not an integer.
Documentation should be updated to include this data field format.
The documentation says:
"If this value is specified without units, it is taken as milliseconds."
If the value is specified with units, it follows the rule described here:
https://www.postgresql.org/docs/13/config-setting.html 
<https://www.postgresql.org/docs/13/config-setting.html; 
"Numeric with Unit: Some numeric parameters have an implicit unit,
because they describe quantities of memory or time. The unit might be
bytes, kilobytes, blocks (typically eight kilobytes), milliseconds,
seconds, or minutes."
:
:
"Valid time units are us (microseconds), ms (milliseconds), s
(seconds), min (minutes), h (hours), and d (days)."
So I see no problem with the document.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php 
<http://www.sraoss.co.jp/index_en.php; 
Japanese:http://www.sraoss.co.jp <http://www.sraoss.co.jp; 

view thread (9+ messages)  latest in thread

Message-ID: <c0e06b0927222.cf42cafcd23b9@yahoo.com>
Permalink:  ../c0e06b0927222.cf42cafcd23b9@yahoo.com/
Also on:    postgresql.org/message-id/c0e06b0927222.cf42cafcd23b9@yahoo.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: cdalxndr@yahoo.com, ishii@sraoss.co.jp, pgsql-bugs@lists.postgresql.org
  Subject: Re: Invalid idle_in_transaction_session_timeout data type
  In-Reply-To: <c0e06b0927222.cf42cafcd23b9@yahoo.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox