pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: yanliang lei <msdnchina@163.com>
To: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: suggest about bpchar  data type in the document
Date: Wed, 28 Sep 2022 08:15:57 +0200
Message-ID: <ccdfa054d8c26b94cf522ef7ceec0112c8f523a2.camel@cybertec.at> (raw)
In-Reply-To: <41fe0ea52f9803649ae876d4d14b2b7ca89ffc06.camel@cybertec.at>
References: <120b3084.56b6.1833b5ffe4b.Coremail.msdnchina@163.com>
	<41fe0ea52f9803649ae876d4d14b2b7ca89ffc06.camel@cybertec.at>

On Wed, 2022-09-14 at 18:48 +0200, Laurenz Albe wrote:
> On Wed, 2022-09-14 at 17:41 +0800, yanliang lei wrote:
> > I hope that:
> > 
> >  in the  https://www.postgresql.org/docs/14/datatype-characterin.html ,It needs to be written clearly  “bpchar” data type,
> > 
> > and in the above url, Only mentioned “blank padded” ,If someone does not know  this knowledge point
> > (blank padded =bp),he/she  will make a detour in the study of  character datatype。
> > 
> > so,To make the document more friendly, I suggest that: in the  https://www.postgresql.org/docs/14/datatype-characterin.htm
> > It needs to be written clearly  “bpchar” data type。
> 
> +1
> 
> I think that adding "bpchar(n)" in table 8.4 would be a good thing.

Here is a patch for that.

Yours,
Laurenz Albe

Attachments:

  [text/x-patch] 0001-Document-bpchar-as-character-data-type.patch (1.2K, ../ccdfa054d8c26b94cf522ef7ceec0112c8f523a2.camel@cybertec.at/2-0001-Document-bpchar-as-character-data-type.patch)
  download | inline diff:
From f5cb97a9ff7f7d0df5f8fe8a8403b5298465784e Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.albe@cybertec.at>
Date: Wed, 28 Sep 2022 08:14:11 +0200
Subject: [PATCH] Document "bpchar" as character data type

"bpchar" is our internal name for "character", but it should
be documented as an alternative name to avoid confusion.

Per request from Yanliang Lei.

Discussion: https://postgr.es/m/120b3084.56b6.1833b5ffe4b.Coremail.msdnchina@163.com
---
 doc/src/sgml/datatype.sgml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml
index 0258b192e0..b844e379b9 100644
--- a/doc/src/sgml/datatype.sgml
+++ b/doc/src/sgml/datatype.sgml
@@ -1169,7 +1169,7 @@ SELECT '52093.89'::money::numeric::float8;
         <entry>variable-length with limit</entry>
        </row>
        <row>
-        <entry><type>character(<replaceable>n</replaceable>)</type>, <type>char(<replaceable>n</replaceable>)</type></entry>
+        <entry><type>character(<replaceable>n</replaceable>)</type>, <type>char(<replaceable>n</replaceable>)</type>, <type>bpchar(<replaceable>n</replaceable>)</type></entry>
         <entry>fixed-length, blank padded</entry>
        </row>
        <row>
-- 
2.37.3



view thread (7+ messages)  latest in thread

Message-ID: <ccdfa054d8c26b94cf522ef7ceec0112c8f523a2.camel@cybertec.at>
Permalink:  ../ccdfa054d8c26b94cf522ef7ceec0112c8f523a2.camel@cybertec.at/
Also on:    postgresql.org/message-id/ccdfa054d8c26b94cf522ef7ceec0112c8f523a2.camel@cybertec.at

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: laurenz.albe@cybertec.at, msdnchina@163.com, pgsql-docs@lists.postgresql.org
  Subject: Re: suggest about bpchar  data type in the document
  In-Reply-To: <ccdfa054d8c26b94cf522ef7ceec0112c8f523a2.camel@cybertec.at>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox