From: Tomas Vondra <tomas@vondra.me>
To: Egor Rogov <e.rogov@postgrespro.ru>
To: pgsql-docs@lists.postgresql.org
Subject: Re: Parallel index build for BRIN
Date: Tue, 17 Dec 2024 15:52:25 +0100
Message-ID: <ce1aeb37-a001-4e08-a319-3be9b07f5ee1@vondra.me> (raw)
In-Reply-To: <33844913-7031-35ec-52e5-11908f2453fe@postgrespro.ru>
References: <114e2d5d-125e-07d8-94aa-5ad175fb7443@postgrespro.ru>
<009f4101-29a2-850e-6767-72a9104ec89a@postgrespro.ru>
<908b63e1-4b79-2889-98d1-1909cac39785@postgrespro.ru>
<733bf5ec-2bb9-4e51-805d-b5e33a37609c@vondra.me>
<61ed20a9-6b75-4f2e-b87f-0daf1b3fdf5a@vondra.me>
<33844913-7031-35ec-52e5-11908f2453fe@postgrespro.ru>
On 12/17/24 07:40, Egor Rogov wrote:
> On 16.12.2024 21:24, Tomas Vondra wrote:
>
>> On 12/9/24 19:54, Tomas Vondra wrote:
>>> On 12/8/24 16:00, Egor Rogov wrote:
>>>> Hi,
>>>>
>>>> ...
>>>>
>>>> I've spotted another mention of B-tree being the only AM that supports
>>>> parallel builds: comment in src/backend/catalog/index.c. As this
>>>> mention
>>>> is not visible to the users, I'd propose removing it altogether rather
>>>> than fixing it. Updated patch is attached.
>>>>
>>> Thanks for noticing this and the patches. You're right, this should have
>>> been updated with the BRIN parallel builds. I'll get this committed
>>> sometime the week.
>>>
>> I've pushed the doc fix, and backpatched it to PG 17.
>
>
> Thanks so much, Tomas!
>
> Please note that the comment in src/backend/catalog/index.c remains
> unchanged:
>
>
> --- a/src/backend/catalog/index.c
> +++ b/src/backend/catalog/index.c
> @@ -2988,8 +2988,7 @@ index_build(Relation heapRelation,
> Assert(PointerIsValid(indexRelation->rd_indam->ambuildempty));
>
> /*
> - * Determine worker process details for parallel CREATE INDEX.
> Currently,
> - * only btree has support for parallel builds.
> + * Determine worker process details for parallel CREATE INDEX.
> *
> * Note that planner considers parallel safety for us.
> */
>
Oh, thanks for noticing that. I'm not sure why I missed that, I must
have used the first patch by mistake.
Anyway, I found another obsolete comment in planner.c, so I fixed that
too and pushed.
Thanks
--
Tomas Vondra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tomas@vondra.me, e.rogov@postgrespro.ru, pgsql-docs@lists.postgresql.org
Subject: Re: Parallel index build for BRIN
In-Reply-To: <ce1aeb37-a001-4e08-a319-3be9b07f5ee1@vondra.me>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox