pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: andast@kth.se
To: pgsql-docs@lists.postgresql.org
Subject: Re: Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.
Date: Wed, 25 Sep 2019 00:11:00 +0200
Message-ID: <d0ecd3a3-3e90-1817-5921-19dc98d040a6@2ndquadrant.com> (raw)
In-Reply-To: <156924954640.1117.6309209869705522549@wrigleys.postgresql.org>
References: <156924954640.1117.6309209869705522549@wrigleys.postgresql.org>

On 2019-09-23 16:39, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/11/source-format.html
> Description:
> 
> This sentence in the style guide feels outdated. // style comments have been
> in the ANSI C standard for almost 20 years now (C99 was accepted as ANSI
> standard in may 2000). I suggest rewording this to "Do not use C99 style
> comments (// comments). Strict C89 compilers do not accept them." or come up
> with some other reason for /**/ style being preferred to // style since I'm
> not entierly convinced postgres compiles on C89 anyways.

PostgreSQL 12 requires C99, so those guidelines should probably be
rephrased from "because old compilers don't accept it" to "because we
like it that way".

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (5+ messages)  latest in thread

Message-ID: <d0ecd3a3-3e90-1817-5921-19dc98d040a6@2ndquadrant.com>
Permalink:  ../d0ecd3a3-3e90-1817-5921-19dc98d040a6@2ndquadrant.com/
Also on:    postgresql.org/message-id/d0ecd3a3-3e90-1817-5921-19dc98d040a6@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, andast@kth.se, pgsql-docs@lists.postgresql.org
  Subject: Re: Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.
  In-Reply-To: <d0ecd3a3-3e90-1817-5921-19dc98d040a6@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox