pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: pgsql-docs@lists.postgresql.org
Subject: Re: The description for pg_replication_slots.restart_lsn
Date: Thu, 25 Jun 2020 09:42:47 +0900
Message-ID: <d6517043-606c-a953-bc66-bca101c5a604@oss.nttdata.com> (raw)
In-Reply-To: <6497f1e9-3148-c5da-7e49-b2fddad9a42f@oss.nttdata.com>
References: <6497f1e9-3148-c5da-7e49-b2fddad9a42f@oss.nttdata.com>



On 2020/06/17 23:47, Fujii Masao wrote:
> Hi,
> 
> The document explains that restart_lsn column in pg_replication_slots view is:
> 
>      The address (LSN) of oldest WAL which still might be required by
>      the consumer of this slot and thus won't be automatically removed
>      during checkpoints.
> 
> But the latter part is not true in v13 thanks to max_slot_wal_keep_size.
> I think that we need to update it as follows. Thought?
> 
>      The address (LSN) of oldest WAL which still might be required by
>      the consumer of this slot and thus won't be automatically removed
>      during checkpoints unless this LSN gets behind more than
>      max_slot_wal_keep_size from the current LSN.
> 
> Patch attached.

Barring any objection, I will commit this patch.

Regards,


-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (5+ messages)  latest in thread

Message-ID: <d6517043-606c-a953-bc66-bca101c5a604@oss.nttdata.com>
Permalink:  ../d6517043-606c-a953-bc66-bca101c5a604@oss.nttdata.com/
Also on:    postgresql.org/message-id/d6517043-606c-a953-bc66-bca101c5a604@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, pgsql-docs@lists.postgresql.org
  Subject: Re: The description for pg_replication_slots.restart_lsn
  In-Reply-To: <d6517043-606c-a953-bc66-bca101c5a604@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox