From: btkatsuragiyu <btkatsuragiyu@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-docs@postgresql.org
Subject: Re: Fix the example in the document of file-fdw
Date: Mon, 14 Sep 2020 16:10:03 +0900
Message-ID: <fccb0907a64286534b7077f0ea8ddae5@oss.nttdata.com> (raw)
In-Reply-To: <20200914050716.GC2183@paquier.xyz>
References: <0cd5a9ebbec58bb16fd3f6eb20e401d9@oss.nttdata.com>
<3b42a115-ebc9-d800-f51f-b5bf7a84201b@oss.nttdata.com>
<20200914050716.GC2183@paquier.xyz>
On 2020-09-14 14:07, Michael Paquier wrote:
> On Mon, Sep 14, 2020 at 11:33:23AM +0900, Fujii Masao wrote:
>> On 2020/09/14 11:19, btkatsuragiyu wrote:
>>> This patch fixes the DDL in the document of file-fdw.
>>
>> Thanks for the patch! LGTM. I will commit it.
>
> Hmm. Instead of keeping a copy-paste of the same table in both
> config.sgml and file-fdw.sgml, why not having only one?
I agree with this comment.
> It seems to me that we could just have the file_fdw doc refer to the
> main
> configuration, and it is not difficult to guess how the CREATE TABLE
> query needs to be changed to map with foreign table.
However, I think showing complete DDL including SERVER pglog and OPTIONS
would be helpful
to users who are not familiar with this feature.
Regards,
Yuta Katsuragi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: btkatsuragiyu@oss.nttdata.com, michael@paquier.xyz, masao.fujii@oss.nttdata.com
Subject: Re: Fix the example in the document of file-fdw
In-Reply-To: <fccb0907a64286534b7077f0ea8ddae5@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox