pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Christoph Moench-Tegeder <cmt@burggraben.net>
Cc: klaus.mailinglists@pernau.at
Cc: pgsql-general@postgresql.org
Subject: Re: PANIC: could not flush dirty data: Cannot allocate memory
Date: Mon, 14 Nov 2022 23:05:23 -0500
Message-ID: <1004346.1668485123@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKG+Lc8OhTSot3Eh-qfyuarJ15G7O==AfcS_Yz6dnPGwDew@mail.gmail.com>
References: <ec01f7af535c0c38711a317cba2aa310@pernau.at>
	<Y3K4+z5fP9mNElMj@elch.exwg.net>
	<CA+hUKG+Lc8OhTSot3Eh-qfyuarJ15G7O==AfcS_Yz6dnPGwDew@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> It has been argued before that we might have been over-zealous
> applying the PANIC promotion logic to sync_file_range().  It's used to
> start asynchronous writeback to make the later fsync() call fast, so
> it's "only a hint", but I have no idea if it could report a writeback
> error from the kernel that would then be consumed and not reported to
> the later fsync(), so I defaulted to assuming that it could.

Certainly, if it reports EIO, we should panic.  But maybe not for
ENOMEM?  One would assume that that means that the request didn't
get queued for lack of in-kernel memory space ... in which case
"nothing happened".

			regards, tom lane





view thread (12+ messages)  latest in thread

Message-ID: <1004346.1668485123@sss.pgh.pa.us>
Permalink:  ../1004346.1668485123@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1004346.1668485123@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, cmt@burggraben.net, klaus.mailinglists@pernau.at
  Subject: Re: PANIC: could not flush dirty data: Cannot allocate memory
  In-Reply-To: <1004346.1668485123@sss.pgh.pa.us>
  References: <ec01f7af535c0c38711a317cba2aa310@pernau.at> <Y3K4+z5fP9mNElMj@elch.exwg.net> <CA+hUKG+Lc8OhTSot3Eh-qfyuarJ15G7O==AfcS_Yz6dnPGwDew@mail.gmail.com> <1004346.1668485123@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox