From: Vincas Dargis <vindrg@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-general <pgsql-general@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: Issues cross-compiling libpq 14.x to MacOS armv8
Date: Thu, 2 Dec 2021 20:36:34 +0200
Message-ID: <12a6243a-826c-e8b9-0716-61fc5aa9d229@gmail.com> (raw)
In-Reply-To: <1636357.1638307994@sss.pgh.pa.us>
References: <0dc14a31-acaf-8cae-0df4-a87339b22bd9@gmail.com>
<1628170.1638302387@sss.pgh.pa.us>
<47B78E57-3D0F-4616-BF52-C07FA76AF0A7@yesql.se>
<1633127.1638306242@sss.pgh.pa.us>
<1636357.1638307994@sss.pgh.pa.us>
Thanks Tom!
Should we expect this fix in the next 14 patch release, or only in 15.x?
If latter, I would add this patch into Conan package itself, to make it work earlier.
On 2021-11-30 23:33, Tom Lane wrote:
> I wrote:
>> It seems like a useful test when *not* cross compiling, which is most
>> of the time. I'd just wrap that bit in
>> if test "$cross_compiling" = no; then
>
> Or actually, since we should print something, it looks like this will do:
>
> diff --git a/configure.ac b/configure.ac
> index a5c10b8d56..7257afda20 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2287,6 +2287,8 @@ if test x"$with_ssl" = x"openssl" ; then
> AC_MSG_RESULT([OpenSSL])
> elif test x"$PORTNAME" = x"win32" ; then
> AC_MSG_RESULT([Windows native])
> +elif test x"$cross_compiling" = x"yes"; then
> + AC_MSG_RESULT([assuming /dev/urandom])
> else
> AC_MSG_RESULT([/dev/urandom])
> AC_CHECK_FILE([/dev/urandom], [], [])
>
> Off to see if I can verify that before pushing.
>
> regards, tom lane
>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-general@postgresql.org
Cc: vindrg@gmail.com, tgl@sss.pgh.pa.us, daniel@yesql.se, magnus@hagander.net, michael@paquier.xyz
Subject: Re: Issues cross-compiling libpq 14.x to MacOS armv8
In-Reply-To: <12a6243a-826c-e8b9-0716-61fc5aa9d229@gmail.com>
References: <0dc14a31-acaf-8cae-0df4-a87339b22bd9@gmail.com> <1628170.1638302387@sss.pgh.pa.us> <47B78E57-3D0F-4616-BF52-C07FA76AF0A7@yesql.se> <1633127.1638306242@sss.pgh.pa.us> <1636357.1638307994@sss.pgh.pa.us> <12a6243a-826c-e8b9-0716-61fc5aa9d229@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox