From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: adrian.klaver@aklaver.com
Cc: frazer@frazermclean.co.uk
Cc: pgsql-general@postgresql.org
Subject: Re: Unexpected interval comparison
Date: Wed, 05 Apr 2017 23:31:40 -0400
Message-ID: <15484.1491449500@sss.pgh.pa.us> (raw)
In-Reply-To: <20170406.120745.33533430.horiguchi.kyotaro@lab.ntt.co.jp>
References: <20170405.200723.102041631.horiguchi.kyotaro@lab.ntt.co.jp>
<27982.1491421870@sss.pgh.pa.us>
<385.1491426413@sss.pgh.pa.us>
<20170406.120745.33533430.horiguchi.kyotaro@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-general>
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> By the way the adt directory is, as suggested by the name,
> storing files with names of SQL data types so "int128.c" among
> then seems incongruous. Is "int128_test.c" acceptable? int16.c
> will be placed there in case we support int16 or hugeint on SQL.
After further reflection I've decided to put int128.h in
src/include/common/, thinking that maybe someday it will be useful
on client side too. Also I've changed the test harness file to
be src/tools/testint128.c, so that it won't be confused with code
meant to be part of the backend.
> Back to 9.5 seems reasonable to me.
I poked around and noticed that before 9.4, we did not attempt
to guard against overflows in interval calculations at all.
So backpatch to 9.4 seems pretty defensible. The non-HAVE_INT128
code works fine in 9.4.
I've just about finished adjusting the patch for the back
branches, and will push in a little bit.
regards, tom lane
--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-general@postgresql.org
Cc: tgl@sss.pgh.pa.us, horiguchi.kyotaro@lab.ntt.co.jp, adrian.klaver@aklaver.com, frazer@frazermclean.co.uk
Subject: Re: Unexpected interval comparison
In-Reply-To: <15484.1491449500@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox