public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Sebastien Flaesch <[email protected]>
Cc: Adrian Klaver <[email protected]>
Cc: M Tarkeshwar Rao <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
Date: Fri, 21 Mar 2025 14:56:12 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwZOCZB19s_mup7CDqLoTyH3Q5dAf7Qf8uR-pwoN47yKMA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwZYCktj5Ect4f5Mx1OejCRbQ+MoKWQN+F=2Oid5M=3E7Q@mail.gmail.com>
	<[email protected]>
	<CAKFQuwZOCZB19s_mup7CDqLoTyH3Q5dAf7Qf8uR-pwoN47yKMA@mail.gmail.com>

"David G. Johnston" <[email protected]> writes:
> On Thu, Mar 20, 2025 at 2:56 PM Tom Lane <[email protected]> wrote:
>> That's documented elsewhere, I believe.  For the foo_d.h files,
>> I think it'd be sufficient to do something like 0001 attached.

> WFM.  Thanks.

Thanks for looking at it.

>> Also, while checking out the results, I noticed that pg_class.h
>> has an "extern" in the wrong place: it's exposed to client code
>> which can have no use for it.  That extern doesn't mention any
>> backend-only typedefs, so it's fairly harmless, but it's still
>> a clear example of somebody not reading the memo.  Hence 0002.

> Maybe tack this onto genbki.h?

> diff --git a/src/include/catalog/genbki.h b/src/include/catalog/genbki.h
> index 26e205529d..4a1567a46b 100644
> --- a/src/include/catalog/genbki.h
> +++ b/src/include/catalog/genbki.h
> @@ -146,4 +146,6 @@
>   */
>  #undef EXPOSE_TO_CLIENT_CODE

> +/* Additional backend-only code is placed after the client-code section. */
> +
>  #endif                                                 /* GENBKI_H */

Doubt that would help ...

			regards, tom lane

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: After upgrading libpq, the same function(PQftype) call returns a different OID
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox