From: Martin Kalcher <martin.kalcher@aboutsource.net>
To: Andres Freund <andres@anarazel.de>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()
Date: Thu, 22 Sep 2022 17:40:17 +0200
Message-ID: <193caac5-941e-58b8-65e6-351f777ebd25@aboutsource.net> (raw)
In-Reply-To: <20220922152320.ukx6teo7wa7cuwkv@awork3.anarazel.de>
References: <CAEZATCVOJHxWOG7DvEjkL_Y-h6f-HK-VkFpsdP76pa6y7xsW7Q@mail.gmail.com>
<459f6008-90bc-bc52-6f11-e68570e03ac0@aboutsource.net>
<CAEZATCXCFyr_cpkMygqSiiiHXgZWaXSumwL9=Xz5n7wwzBvaEw@mail.gmail.com>
<583b6409-df52-86d1-8c0a-ce8e74863ad7@aboutsource.net>
<036ba529-1f25-d7b5-c5ad-e6c852d928df@aboutsource.net>
<alpine.DEB.2.22.394.2207240929220.1359119@pseudo>
<f5af7698-d1eb-bdf4-9969-82b18ab4f8cf@aboutsource.net>
<alpine.DEB.2.22.394.2207242132460.1359119@pseudo>
<fe7a6a81-5c1b-aaae-922f-cb86be324373@aboutsource.net>
<8fabf9e7-3422-58b0-93f6-d0976d4679df@aboutsource.net>
<20220922152320.ukx6teo7wa7cuwkv@awork3.anarazel.de>
Am 22.09.22 um 17:23 schrieb Andres Freund:
> Hi,
>
> On 2022-08-04 07:46:10 +0200, Martin Kalcher wrote:
>> Patch update without merge conflicts.
>
> Due to the merge of the meson based build, this patch needs to be adjusted. See
> https://cirrus-ci.com/build/6580671765282816
> Looks like it'd just be adding user_prng.c to
> src/backend/utils/adt/meson.build's list.
>
> Greetings,
>
> Andres Freund
Hi Andres,
thanks for the heads up. Adjusted patch is attached.
- Martin
Attachments:v4-0001-Introduce-array_shuffle-and-array_sample.patch (text/x-patch, 18.1K) download
From 3c4a939abf8d29bcf666e49ecb042ade42b36c2c Mon Sep 17 00:00:00 2001
From: Martin Kalcher <martin.kalcher@aboutsource.net>
Date: Sun, 17 Jul 2022 18:06:04 +0200
Subject: [PATCH v4] Introduce array_shuffle() and array_sample()
* array_shuffle() shuffles the elements of an array.
* array_sample() chooses n elements from an array by random.
The new functions share its prng state with random() and thus interoperate
with setseed().
---
doc/src/sgml/func.sgml | 40 +++++-
src/backend/utils/adt/Makefile | 1 +
src/backend/utils/adt/array_userfuncs.c | 176 ++++++++++++++++++++++++
src/backend/utils/adt/float.c | 37 +----
src/backend/utils/adt/meson.build | 1 +
src/backend/utils/adt/user_prng.c | 87 ++++++++++++
src/include/catalog/pg_proc.dat | 6 +
src/include/utils/user_prng.h | 19 +++
src/test/regress/expected/arrays.out | 66 +++++++++
src/test/regress/sql/arrays.sql | 16 +++
10 files changed, 414 insertions(+), 35 deletions(-)
create mode 100644 src/backend/utils/adt/user_prng.c
create mode 100644 src/include/utils/user_prng.h
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgmlindex e1fe4fec57..2a96fc323a 100644--- a/doc/src/sgml/func.sgml+++ b/doc/src/sgml/func.sgml@@ -1820,7 +1820,8 @@ repeat('Pg', 4) <returnvalue>PgPgPgPg</returnvalue>
<returnvalue>void</returnvalue>
</para>
<para>
- Sets the seed for subsequent <literal>random()</literal> calls;+ Sets the seed for subsequent calls to random functions, like+ <literal>random()</literal> or <literal>array_shuffle()</literal>;
argument must be between -1.0 and 1.0, inclusive
</para>
<para>
@@ -1838,7 +1839,8 @@ repeat('Pg', 4) <returnvalue>PgPgPgPg</returnvalue>
applications; see the <xref linkend="pgcrypto"/> module for a more
secure alternative.
If <function>setseed()</function> is called, the series of results of
- subsequent <function>random()</function> calls in the current session+ subsequent calls to random functions, like <function>random()</function> or+ <function>array_shuffle()</function>, in the current session
can be repeated by re-issuing <function>setseed()</function> with the same
argument.
Without any prior <function>setseed()</function> call in the same
@@ -18468,6 +18470,40 @@ SELECT NULLIF(value, '(none)') ...
</para></entry>
</row>
+ <row>+ <entry role="func_table_entry"><para role="func_signature">+ <indexterm>+ <primary>array_sample</primary>+ </indexterm>+ <function>array_sample</function> ( <parameter>array</parameter> <type>anyarray</type>, <parameter>n</parameter> <type>integer</type> )+ <returnvalue>anyarray</returnvalue>+ </para>+ <para>+ Returns <parameter>n</parameter> randomly chosen elements from <parameter>array</parameter> in selection order.+ </para>+ <para>+ <literal>array_sample(ARRAY[[1,2],[3,4],[5,6]], 2)</literal>+ <returnvalue>{{5,6},{1,2}}</returnvalue>+ </para></entry>+ </row>++ <row>+ <entry role="func_table_entry"><para role="func_signature">+ <indexterm>+ <primary>array_shuffle</primary>+ </indexterm>+ <function>array_shuffle</function> ( <type>anyarray</type> )+ <returnvalue>anyarray</returnvalue>+ </para>+ <para>+ Shuffles the first dimension of the array.+ </para>+ <para>+ <literal>array_shuffle(ARRAY[[1,2],[3,4],[5,6]])</literal>+ <returnvalue>{{5,6},{1,2},{3,4}}</returnvalue>+ </para></entry>+ </row>+
<row>
<entry role="func_table_entry"><para role="func_signature">
<indexterm id="function-array-to-string">
diff --git a/src/backend/utils/adt/Makefile b/src/backend/utils/adt/Makefileindex 0de0bbb1b8..17b57a5569 100644--- a/src/backend/utils/adt/Makefile+++ b/src/backend/utils/adt/Makefile@@ -110,6 +110,7 @@ OBJS = \
tsvector.o \
tsvector_op.o \
tsvector_parser.o \
+ user_prng.o \
uuid.o \
varbit.o \
varchar.o \
diff --git a/src/backend/utils/adt/array_userfuncs.c b/src/backend/utils/adt/array_userfuncs.cindex ca70590d7d..c4a2117df7 100644--- a/src/backend/utils/adt/array_userfuncs.c+++ b/src/backend/utils/adt/array_userfuncs.c@@ -17,6 +17,7 @@
#include "utils/array.h"
#include "utils/builtins.h"
#include "utils/lsyscache.h"
+#include "utils/user_prng.h"
#include "utils/typcache.h"
@@ -902,3 +903,178 @@ array_positions(PG_FUNCTION_ARGS)
PG_RETURN_DATUM(makeArrayResult(astate, CurrentMemoryContext));
}
++/*+ * Produce array with n randomly chosen items from given array in random order.+ *+ * array: array object to examine (must not be NULL)+ * n: number of items (must not be greater than the size of the arrays first dimension)+ * elmtyp, elmlen, elmbyval, elmalign: info for the datatype of the items+ *+ * NOTE: it would be cleaner to look up the elmlen/elmbval/elmalign info+ * from the system catalogs, given the elmtyp. However, the caller is+ * in a better position to cache this info across multiple uses, or even+ * to hard-wire values if the element type is hard-wired.+ */+static ArrayType *+array_shuffle_n(ArrayType *array, int n,+ Oid elmtyp, int elmlen, bool elmbyval, char elmalign)+{+ ArrayType *result;+ int ndim,+ *dims,+ *lbs,+ rdims[MAXDIM],+ nelm,+ nitem,+ i,+ j,+ k;+ Datum elm,+ *elms,+ *ielms,+ *jelms;+ bool nul,+ *nuls,+ *inuls,+ *jnuls;++ ndim = ARR_NDIM(array);+ dims = ARR_DIMS(array);+ lbs = ARR_LBOUND(array);++ if (ndim < 1 || dims[0] < 1 || n < 1)+ return construct_empty_array(elmtyp);++ deconstruct_array(array, elmtyp, elmlen, elmbyval, elmalign,+ &elms, &nuls, &nelm);++ nitem = dims[0]; /* total number of items */+ nelm /= nitem; /* number of elements per item */++ ielms = elms;+ inuls = nuls;++ /*+ * Shuffle array using Fisher-Yates algorithm. Iterate array and swap head+ * (ielms) with an randomly chosen item (jelms) at each iteration.+ */+ for (i = 0; i < n; i++)+ {+ j = (int) user_prng_uint64_range(0, nitem - i - 1) * nelm;+ jelms = ielms + j;+ jnuls = inuls + j;++ /* Swap all elements in item (i) with elements in item (j). */+ for (k = 0; k < nelm; k++)+ {+ elm = *ielms;+ nul = *inuls;+ *ielms++ = *jelms;+ *inuls++ = *jnuls;+ *jelms++ = elm;+ *jnuls++ = nul;+ }+ }++ memcpy(rdims, dims, ndim * sizeof(int));+ rdims[0] = n;++ result = construct_md_array(elms, nuls, ndim, rdims, lbs,+ elmtyp, elmlen, elmbyval, elmalign);++ pfree(elms);+ pfree(nuls);++ return result;+}++/*+ * Shuffle the elements of an array.+ */+Datum+array_shuffle(PG_FUNCTION_ARGS)+{+ ArrayType *array,+ *result;+ int16 elmlen;+ bool elmbyval;+ char elmalign;+ Oid elmtyp;+ TypeCacheEntry *typentry;+ int n;++ array = PG_GETARG_ARRAYTYPE_P(0);++ /* Return empty array immediately. */+ if (ARR_NDIM(array) < 1)+ PG_RETURN_ARRAYTYPE_P(array);++ n = ARR_DIMS(array)[0];++ /* There is no point in shuffling arrays with less then two items. */+ if (n < 2)+ PG_RETURN_ARRAYTYPE_P(array);++ elmtyp = ARR_ELEMTYPE(array);+ typentry = (TypeCacheEntry *) fcinfo->flinfo->fn_extra;+ if (typentry == NULL || typentry->type_id != elmtyp)+ {+ typentry = lookup_type_cache(elmtyp, 0);+ fcinfo->flinfo->fn_extra = (void *) typentry;+ }+ elmlen = typentry->typlen;+ elmbyval = typentry->typbyval;+ elmalign = typentry->typalign;++ result = array_shuffle_n(array, n,+ elmtyp, elmlen, elmbyval, elmalign);++ PG_FREE_IF_COPY(array, 0);++ PG_RETURN_ARRAYTYPE_P(result);+}++/*+ * Choose N random elements from an array.+ */+Datum+array_sample(PG_FUNCTION_ARGS)+{+ ArrayType *array,+ *result;+ int16 elmlen;+ bool elmbyval;+ char elmalign;+ Oid elmtyp;+ TypeCacheEntry *typentry;+ int n,+ nitem;++ array = PG_GETARG_ARRAYTYPE_P(0);+ n = PG_GETARG_INT32(1);+ nitem = (ARR_NDIM(array) < 1) ? 0 : ARR_DIMS(array)[0];++ if (n < 0 || n > nitem)+ ereport(ERROR,+ (errcode(ERRCODE_INVALID_PARAMETER_VALUE),+ errmsg("sample size must be between 0 and %d", nitem)));++ elmtyp = ARR_ELEMTYPE(array);+ typentry = (TypeCacheEntry *) fcinfo->flinfo->fn_extra;+ if (typentry == NULL || typentry->type_id != elmtyp)+ {+ typentry = lookup_type_cache(elmtyp, 0);+ fcinfo->flinfo->fn_extra = (void *) typentry;+ }+ elmlen = typentry->typlen;+ elmbyval = typentry->typbyval;+ elmalign = typentry->typalign;++ result = array_shuffle_n(array, n,+ elmtyp, elmlen, elmbyval, elmalign);++ PG_FREE_IF_COPY(array, 0);++ PG_RETURN_ARRAYTYPE_P(result);+}diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.cindex fc8f39a7a9..29dabbbc6a 100644--- a/src/backend/utils/adt/float.c+++ b/src/backend/utils/adt/float.c@@ -21,15 +21,13 @@
#include "catalog/pg_type.h"
#include "common/int.h"
-#include "common/pg_prng.h"
#include "common/shortest_dec.h"
#include "libpq/pqformat.h"
-#include "miscadmin.h"
#include "utils/array.h"
#include "utils/float.h"
#include "utils/fmgrprotos.h"
+#include "utils/user_prng.h"
#include "utils/sortsupport.h"
-#include "utils/timestamp.h"
/*
@@ -64,10 +62,6 @@ float8 degree_c_sixty = 60.0;
float8 degree_c_one_half = 0.5;
float8 degree_c_one = 1.0;
-/* State for drandom() and setseed() */-static bool drandom_seed_set = false;-static pg_prng_state drandom_seed;-
/* Local function prototypes */
static double sind_q1(double x);
static double cosd_q1(double x);
@@ -2749,30 +2743,8 @@ datanh(PG_FUNCTION_ARGS)
Datum
drandom(PG_FUNCTION_ARGS)
{
- float8 result;-- /* Initialize random seed, if not done yet in this process */- if (unlikely(!drandom_seed_set))- {- /*- * If possible, initialize the seed using high-quality random bits.- * Should that fail for some reason, we fall back on a lower-quality- * seed based on current time and PID.- */- if (unlikely(!pg_prng_strong_seed(&drandom_seed)))- {- TimestampTz now = GetCurrentTimestamp();- uint64 iseed;-- /* Mix the PID with the most predictable bits of the timestamp */- iseed = (uint64) now ^ ((uint64) MyProcPid << 32);- pg_prng_seed(&drandom_seed, iseed);- }- drandom_seed_set = true;- }-- /* pg_prng_double produces desired result range [0.0 - 1.0) */- result = pg_prng_double(&drandom_seed);+ /* user_prng_double produces desired result range [0.0 - 1.0) */+ float8 result = user_prng_double();
PG_RETURN_FLOAT8(result);
}
@@ -2792,8 +2764,7 @@ setseed(PG_FUNCTION_ARGS)
errmsg("setseed parameter %g is out of allowed range [-1,1]",
seed)));
- pg_prng_fseed(&drandom_seed, seed);- drandom_seed_set = true;+ user_prng_seed(seed);
PG_RETURN_VOID();
}
diff --git a/src/backend/utils/adt/meson.build b/src/backend/utils/adt/meson.buildindex ed9ceadfef..0372f5e4b7 100644--- a/src/backend/utils/adt/meson.build+++ b/src/backend/utils/adt/meson.build@@ -95,6 +95,7 @@ backend_sources += files(
'tsvector.c',
'tsvector_op.c',
'tsvector_parser.c',
+ 'user_prng.c',
'uuid.c',
'varbit.c',
'varchar.c',
diff --git a/src/backend/utils/adt/user_prng.c b/src/backend/utils/adt/user_prng.cnew file mode 100644index 0000000000..a541e955ef--- /dev/null+++ b/src/backend/utils/adt/user_prng.c@@ -0,0 +1,87 @@+/*-------------------------------------------------------------------------+ *+ * user_prng.c+ * Random number generator for user facing functions.+ *+ * Portions Copyright (c) 2022, PostgreSQL Global Development Group+ *+ *+ * IDENTIFICATION+ * src/backend/utils/adt/user_prng.c+ *+ *-------------------------------------------------------------------------+ */++#include "postgres.h"++#include "common/pg_prng.h"+#include "miscadmin.h"+#include "utils/user_prng.h"+#include "utils/timestamp.h"++/*+ * Process wide state vector used by all user facing random functions,+ * like random() or array_shuffle().+ */+static pg_prng_state user_prng_state;+static bool user_prng_state_set = false;++/*+ * Ensure the prng is seeded.+ */+static inline void+user_prng_ensure_seed(void)+{+ /* Initialize prng state, if not done yet in this process. */+ if (unlikely(!user_prng_state_set))+ {+ /*+ * If possible, initialize the state using high-quality random bits.+ * Should that fail for some reason, we fall back on a lower-quality+ * seed based on current time and PID.+ */+ if (unlikely(!pg_prng_strong_seed(&user_prng_state)))+ {+ uint64 now = (uint64) GetCurrentTimestamp();+ uint64 pid = (uint64) MyProcPid;++ /* Mix PID with the most predictable bits of the timestamp. */+ pg_prng_seed(&user_prng_state, now ^ (pid << 32));+ }++ user_prng_state_set = true;+ }+}++/*+ * Seed the prng.+ */+void+user_prng_seed(float8 seed)+{+ pg_prng_fseed(&user_prng_state, seed);++ user_prng_state_set = true;+}++/*+ * Select a random double from the range [0.0, 1.0).+ */+float8+user_prng_double(void)+{+ user_prng_ensure_seed();++ return pg_prng_double(&user_prng_state);+}++/*+ * Select a random uint64 from the range [min, max].+ */+uint64+user_prng_uint64_range(uint64 min, uint64 max)+{+ user_prng_ensure_seed();++ return pg_prng_uint64_range(&user_prng_state, min, max);+}diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.datindex a07e737a33..00c32c58e7 100644--- a/src/include/catalog/pg_proc.dat+++ b/src/include/catalog/pg_proc.dat@@ -1681,6 +1681,12 @@
proname => 'arraycontjoinsel', provolatile => 's', prorettype => 'float8',
proargtypes => 'internal oid internal int2 internal',
prosrc => 'arraycontjoinsel' },
+{ oid => '8464', descr => 'shuffle array',+ proname => 'array_shuffle', provolatile => 'v', proparallel => 'r', proisstrict => 't',+ prorettype => 'anyarray', proargtypes => 'anyarray', prosrc => 'array_shuffle' },+{ oid => '8465', descr => 'take samples from array',+ proname => 'array_sample', provolatile => 'v', proparallel => 'r', proisstrict => 't',+ prorettype => 'anyarray', proargtypes => 'anyarray int4', prosrc => 'array_sample' },
{ oid => '764', descr => 'large object import',
proname => 'lo_import', provolatile => 'v', proparallel => 'u',
diff --git a/src/include/utils/user_prng.h b/src/include/utils/user_prng.hnew file mode 100644index 0000000000..959c1d727d--- /dev/null+++ b/src/include/utils/user_prng.h@@ -0,0 +1,19 @@+/*-------------------------------------------------------------------------+ *+ * user_prng.h+ * Random number generator for user facing functions.+ *+ * Portions Copyright (c) 2022, PostgreSQL Global Development Group+ *+ * src/include/utils/user_prng.h+ *+ *-------------------------------------------------------------------------+ */+#ifndef USER_PRNG_H+#define USER_PRNG_H++extern void user_prng_seed(float8 seed);+extern float8 user_prng_double(void);+extern uint64 user_prng_uint64_range(uint64 min, uint64 max);++#endif /* USER_PRNG_H */diff --git a/src/test/regress/expected/arrays.out b/src/test/regress/expected/arrays.outindex 97920f38c2..67e6ca9ab2 100644--- a/src/test/regress/expected/arrays.out+++ b/src/test/regress/expected/arrays.out@@ -2447,3 +2447,69 @@ SELECT trim_array(ARRAY[1, 2, 3], 10); -- fail
ERROR: number of elements to trim must be between 0 and 3
SELECT trim_array(ARRAY[]::int[], 1); -- fail
ERROR: number of elements to trim must be between 0 and 0
+-- array_shuffle+SELECT setseed(0.1); -- ensure predictable results+ setseed +---------+ +(1 row)++SELECT array_shuffle('{NULL,1,2,3,4,5}'::int[]);+ array_shuffle +------------------+ {5,NULL,1,2,4,3}+(1 row)++SELECT array_shuffle('{NULL,1,2,3,4,5}'::int[]);+ array_shuffle +------------------+ {4,1,2,NULL,3,5}+(1 row)++SELECT array_shuffle('[-1:2][2:3]={{1,2},{3,4},{5,6},{7,8}}'::int[]);+ array_shuffle +---------------------------------------+ [-1:2][2:3]={{7,8},{3,4},{1,2},{5,6}}+(1 row)++SELECT array_shuffle('{{{1,2},{3,4}},{{5,6},{7,8}},{{9,10},{11,12}}}'::int[]);+ array_shuffle +------------------------------------------------+ {{{5,6},{7,8}},{{1,2},{3,4}},{{9,10},{11,12}}}+(1 row)++-- array_sample+SELECT setseed(0.1); -- ensure predictable results+ setseed +---------+ +(1 row)++SELECT array_sample('{NULL,1,2,3,4,5}'::int[], 3);+ array_sample +--------------+ {5,NULL,1}+(1 row)++SELECT array_sample('{NULL,1,2,3,4,5}'::int[], 3);+ array_sample +--------------+ {5,3,4}+(1 row)++SELECT array_sample('[-1:2][2:3]={{1,2},{3,4},{5,6},{7,8}}'::int[], 3);+ array_sample +---------------------------------+ [-1:1][2:3]={{1,2},{3,4},{5,6}}+(1 row)++SELECT array_sample('{{{1,2},{3,4}},{{5,6},{7,8}},{{9,10},{11,12}}}'::int[], 2);+ array_sample +----------------------------------+ {{{1,2},{3,4}},{{9,10},{11,12}}}+(1 row)++SELECT array_sample('{NULL,1,2,3,4,5}'::int[], -1); -- fail+ERROR: sample size must be between 0 and 6+SELECT array_sample('{NULL,1,2,3,4,5}'::int[], 7); --fail+ERROR: sample size must be between 0 and 6diff --git a/src/test/regress/sql/arrays.sql b/src/test/regress/sql/arrays.sqlindex 791af5c0ce..98c3993d9c 100644--- a/src/test/regress/sql/arrays.sql+++ b/src/test/regress/sql/arrays.sql@@ -755,3 +755,19 @@ FROM
SELECT trim_array(ARRAY[1, 2, 3], -1); -- fail
SELECT trim_array(ARRAY[1, 2, 3], 10); -- fail
SELECT trim_array(ARRAY[]::int[], 1); -- fail
++-- array_shuffle+SELECT setseed(0.1); -- ensure predictable results+SELECT array_shuffle('{NULL,1,2,3,4,5}'::int[]);+SELECT array_shuffle('{NULL,1,2,3,4,5}'::int[]);+SELECT array_shuffle('[-1:2][2:3]={{1,2},{3,4},{5,6},{7,8}}'::int[]);+SELECT array_shuffle('{{{1,2},{3,4}},{{5,6},{7,8}},{{9,10},{11,12}}}'::int[]);++-- array_sample+SELECT setseed(0.1); -- ensure predictable results+SELECT array_sample('{NULL,1,2,3,4,5}'::int[], 3);+SELECT array_sample('{NULL,1,2,3,4,5}'::int[], 3);+SELECT array_sample('[-1:2][2:3]={{1,2},{3,4},{5,6},{7,8}}'::int[], 3);+SELECT array_sample('{{{1,2},{3,4}},{{5,6},{7,8}},{{9,10},{11,12}}}'::int[], 2);+SELECT array_sample('{NULL,1,2,3,4,5}'::int[], -1); -- fail+SELECT array_sample('{NULL,1,2,3,4,5}'::int[], 7); --fail--
2.37.3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-general@postgresql.org
Cc: martin.kalcher@aboutsource.net, andres@anarazel.de, coelho@cri.ensmp.fr, dean.a.rasheed@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andrew@dunslane.net, john.naylor@enterprisedb.com, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()
In-Reply-To: <193caac5-941e-58b8-65e6-351f777ebd25@aboutsource.net>
References: <CAEZATCVOJHxWOG7DvEjkL_Y-h6f-HK-VkFpsdP76pa6y7xsW7Q@mail.gmail.com> <459f6008-90bc-bc52-6f11-e68570e03ac0@aboutsource.net> <CAEZATCXCFyr_cpkMygqSiiiHXgZWaXSumwL9=Xz5n7wwzBvaEw@mail.gmail.com> <583b6409-df52-86d1-8c0a-ce8e74863ad7@aboutsource.net> <036ba529-1f25-d7b5-c5ad-e6c852d928df@aboutsource.net> <alpine.DEB.2.22.394.2207240929220.1359119@pseudo> <f5af7698-d1eb-bdf4-9969-82b18ab4f8cf@aboutsource.net> <alpine.DEB.2.22.394.2207242132460.1359119@pseudo> <fe7a6a81-5c1b-aaae-922f-cb86be324373@aboutsource.net> <8fabf9e7-3422-58b0-93f6-d0976d4679df@aboutsource.net> <20220922152320.ukx6teo7wa7cuwkv@awork3.anarazel.de> <193caac5-941e-58b8-65e6-351f777ebd25@aboutsource.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox