From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter <pmc@citylink.dinoex.sub.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?)
Date: Fri, 10 Jan 2020 15:38:07 -0500
Message-ID: <20200110203807.GC3195@tamriel.snowman.net> (raw)
In-Reply-To: <16362.1578684322@sss.pgh.pa.us>
References: <20200109181822.GA74698@gate.oper.dinoex.org>
<7042.1578595681@sss.pgh.pa.us>
<20200109205319.GA85142@gate.oper.dinoex.org>
<15232.1578605504@sss.pgh.pa.us>
<20200110022342.GA92515@gate.oper.dinoex.org>
<12348.1578679149@sss.pgh.pa.us>
<16362.1578684322@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> I wrote:
> > I haven't run it further to ground than that, but there's definitely
> > something fishy here. Based on just these results one would be hard
> > pressed to say if it's our bug or FreeBSD's, but your report that you
> > don't see the failure with PG 11 makes it sound like our problem.
>
> Ah, I have it: whoever wrote pg_GSS_read() failed to pay attention
> to the fact that setting errno is a critical part of its API.
> Sometimes it returns -1 while leaving errno in a state that causes
> pqReadData to draw the wrong conclusions. In particular that can
> happen when it reads an incomplete packet, and that's very timing
> dependent, which is why this is so ticklish to reproduce.
Ah-hah. Not sure if that was Robbie or myself (probably me, really,
since I rewrote a great deal of that code). I agree that the regression
tests don't test with very much data, but I tested pushing quite a bit
of data through and didn't see any issues with my testing. Apparently I
was getting pretty lucky. :/
> I'll have a patch in a little while.
That's fantastic, thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-general@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, pmc@citylink.dinoex.sub.org, pgsql-hackers@lists.postgresql.org
Subject: Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?)
In-Reply-To: <20200110203807.GC3195@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox